GithubHelp home page GithubHelp logo

gavin-yyc / colorconvert Goto Github PK

View Code? Open in Web Editor NEW
21.0 21.0 6.0 89 KB

color convert rgb2hsl rgb2hsv hsl2rgb hsv2rgb

Home Page: http://gavin-yyc.github.io/colorconvert/

JavaScript 69.10% HTML 30.90%

colorconvert's People

Contributors

gavin-yyc avatar tdug avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

colorconvert's Issues

转换问题

感谢制作这个工具!
不过我刚做了一些RGB2HSL, HSB的转换。为了验证准确性,转换回去看了一下。发现RGB2HSL中L的值一直是有一些问题,H和S正确,RGB2HSB正确。转换回去的功能上HSB2RGB整体有一些问题。因为没有读代码,主要是发出来也希望后续的使用者会注意到这个问题。

rgb2hsl方法,有一处写错了

第98行,计算s的第三个if,应该改成(max - min) / (2 - (max + min)),参考wiki

		//计算s
		if ( l == 0 || max == min ) {
			s = 0;
		}else if ( 0 < l && l <= 0.5 ) {
			s = ( max - min ) / ( max + min );
		}else if ( l > 0.5 ) {
			s = ( max - min ) / ( 2 - ( max - min ) ); // 这里有误
		};

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.