GithubHelp home page GithubHelp logo

rgbobj's People

Contributors

issotm avatar rangi42 avatar

Stargazers

avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

rangi42

rgbobj's Issues

Add CI

  • Build, lint and clippy on commit
  • Automate release publication
  • Automate building Windows binaries

Example usage

To better promote/show off the tool, it would be cool to add some example usage/output

Print the actual object file version

Right now it's hard-coded as 9. After the next rgbds-obj release is published, it will expose an object.version() field which we can use here.

Thread panic as unbound `clap` dependency picks latest 3.2+ which has behavior change

In Homebrew, we saw a thread panic when testing a rebuild of rgbds/rgbobj during a rust update (Homebrew/homebrew-core#98823)

==>/usr/local/Cellar/rgbds/0.5.2/bin/rgbobj -A -s data -p data output.o
  thread 'main' panicked at 'Must use `Arg::allow_invalid_utf8` with `_os` lookups at `[hash: 754F87C87F12EDF4]`', /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.com-1ecc6299db9ec823/clap-3.2.5/src/parser/matches/arg_matches.rs:1732:13

The issue appears to be due to changes in newer clap >= 3.2 (clap-rs/clap#3826). Since the Cargo.toml doesn't specify an upper bound and there is no Cargo.lock, the build picks up newer version (3.2.5) and causes this issue at runtime.

The actual issue for thread panic should probably be fixed, but in mean time, it would be nice to provide a Cargo.lock and/or update Cargo.toml with an upper bound (3.0.0-beta.2, <3.2) or fixed (=3.0.0-beta.2) restriction to allow reproducible build.

clap-3.0.0-beta.2 does not work on rustc below 1.54.0 

kayshinonome@latitude-e6430 ~/Code/rgbobj $ cargo b
   Compiling clap v3.0.0-beta.2
error[E0658]: arbitrary expressions in key-value attributes are unstable
 --> /home/kayshinonome/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-3.0.0-beta.2/src/lib.rs:8:10
  |
8 | #![doc = include_str!("../README.md")]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #78835 <https://github.com/rust-lang/rust/issues/78835> for more information

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: could not compile `clap`

To learn more, run the command again with --verbose.
kayshinonome@latitude-e6430 ~/Code/rgbobj $

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.