The none-ls-luacheck.nvim's discuss from gbprod

none-ls-luacheck.nvim's Issues

improve readme with actual command to configure luacheck linter

the none_ls.builtins.diagnostics.luacheck.with({ was not working even when following this website's README.

seems like

sources = { 
   ...
     require("none-ls-luacheck.diagnostics.luacheck").with({
      extra_args = { '--ignore 21/_.*' }
     }),
}

does the deed

Why not having all external sources in a single repo

@gbprod suggestion:

It's ok if not all external sources live in none-ls-extras.nvim.
But I would suggest having all the external sources authored by you in a single repo.

Practical example

Let's say currently, I want to load all your external sources using none-ls-autoload.nvim.

{
  "zeioth/none-ls-autoload.nvim",
  event = "BufEnter",
  dependencies = {
    "williamboman/mason.nvim",
    "nvimtools/none-ls-extras.nvim", -- To install external sources from a repo.
    "gbprod/none-ls-shellcheck.nvim",
    "gbprod/none-ls-luacheck.nvim",
    "gbprod/none-ls-php.nvim",
    "gbprod/none-ls-psalm.nvim",
    "gbprod/none-ls-ecs.nvim"
  },
  opts = {
    external_sources = { -- To indicate where to find a external source.
      -- diagnostics
      'none-ls-shellcheck.diagnostics',
      'none-ls-luacheck.diagnostics.luacheck',
      'none-ls-php.diagnostics.php',
      'none-ls-psalm.diagnostics',

      -- formatting
      'none-ls-ecs.formatting',
    },
  },
},

We can observe:

Several dependencies had to be installed (which is verbose).
The external source path is different on each of your sources, which can lead to confusion.
source paths don't currently follow the none-ls path convention of package_name.method.mason_package_name.

Respecting path naming conventions

Instead, the directory structure should be conventional like this

'gbprob-none-ls.diagnostics.shellcheck',
'gbprob-none-ls.diagnostics.luacheck',
'gbprob-none-ls.diagnostics.php,
'gbprob-none-ls.diagnostics.psalm',

-- formatting
'gbprob-external-sources.formatting.ecs',