gca3020 / gaboardgamegeek Goto Github PK

Hi there,

with the recent version of SWXMLHash it doesn't work anymore.
GABoardGameGeek has a dependency to SWXMLHash and requires 3.0.0 (SWXMLHash ~> '3.0.0').
But the recent version of SWXMLHash is 4.0.0.
So could you update the repo so that its supporting SWXMLHash 4.0.0?

Thanks!

First, thanks for the library, I've been using it for a while and it's great!

The problem is that it is outdated, I managed to make it work on my old iMac modifying the pod file to get older versions of Alamofire and WSXMLHash. But now I'm working with a new Mini, new OSX, new Swift, the hassle was getting to big.
I'm not a programmer, not by a long stretch, but I managed to hunt down the problems, and everything falls in place with just 4 edits in one file. Problem is, I can barely manage git repositories on my own, I have no idea how to show my changes to others (pull requests???), so I'll go old school (stone age old school).

the file is ApiAdapter.swift
line 69 -> AF.request(baseUrl, parameters: params)
line 74 -> case .success(let value):
line 79 -> closure(.success(value))
line 106 -> let xmlIndexer = XMLHash.parse(xml)

(please, don't tell anybody on stack overflow about this, I already have a super noob reputation :) )

The above changes get rid of the errors, and the library seems to work. There are a few warnings on the Deployment Targets and Swift 5, I managed tot week those manually in Xcode, and have no idea where to look for those in the code.

Can you please (please, please, please, please) find the time to update the master branch?

Swift enumerations support assigning string constants to their cases. Rather than declaring a bunch of let constants for the URL base addresses, it will allow stronger type checking to pass them as enumerations.

Thanks for the API!

I have two errors when I do a search with several words:
"7 wonders" or "Pandemic legacy", I have no results when I print searchResults... With just "wonders" it's working.
And when I type just a number I have no results too :/

With the AlamoFire update changing the error handling, the error details are no longer passed through the connectionError enum. It would be nice to add some details, or perhaps just wrap around the entire AFError to include it, so the user could display a valid error message when something is wrong with the network.