gcwnow / gcwconnect Goto Github PK

Some WiFi routers are configured to use MAC address whitelists. Therefore it would be useful if GCW Connect could show the MAC address of the WiFi module of the unit it runs on.

This bug is resulting from changes made in c872c89

Detailed bug description: The presence of AP configuration files saved with previous versions of gcwconnect that did not URL-escape filenames can cause gcwconnect to crash. This occurs when their ESSID contained characters that were previously backslash-escaped but are now either URL-escaped (special chars) or not escaped at all (a dash, for instance). Gcwconnect will parse and list the APs in these files, but any attempts to connect through them or delete them from the list will result in a crash.

Example:
An AP named HOME-1234 would previously have been saved to 'HOME-1234.conf', whereas now it would be saved to or loaded from 'HOME-1234.conf'. If you attempt to connect to HOME-1234 with this older file present, it crashes and this error results:
Traceback (most recent call last):
File "./gcwconnect.py", line 1591, in
shutil.copy2(netconfdir + quote_plus(ssid) + ".conf", sysconfdir+"config-"+wlan+".conf")
File "/usr/lib/python2.7/shutil.py", line 130, in copy2
File "/usr/lib/python2.7/shutil.py", line 82, in copyfile
IOError: [Errno 2] No such file or directory: '/usr/local/home/.local/share/gcwconnect/networks/HOME-0942.conf'

Proposed solution:
Save AP configurations in a different subfolder than 'networks/' in /usr/local/home/.local/share/gcwconnect/ , perhaps 'saved_aps/'. If gcwconnect detects the presence of the old networks/ subfolder, it's obviously from an older firmware and should move each of its configuration files to the new folder, renaming them with the new URL-escaping method based on the ESSID value inside each. The old networks/ subfolder can then be removed.

In other places of the utility, text also has poor legibility and an unprofessional appearance.