GithubHelp home page GithubHelp logo

advent's People

Contributors

geeh avatar

Watchers

 avatar  avatar

advent's Issues

[ZF3][RFC] View refactoring

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/3935
User: @MatyCZ
Created On: 2013-03-02T15:28:49Z
Updated At: 2014-06-12T10:51:43Z
Body

  • Model options is now situated in separated classes
  • Renderer options is now situated in separated classes too
  • Model options passed to constructor now change model behaviour (options don't have any effect before update)
  • CS fixes
  • Code cleanup
  • Some helpers was modified
  • Create a lot of unexsist property in test classes
  • Create a lot of new tests

    Comment

    User: @prolic
    Created On: 2013-03-02T19:33:37Z
    Updated At: 2013-03-02T19:33:37Z
    Body
    looks good on first sight

    Comment

    User: @weierophinney
    Created On: 2013-03-11T21:39:20Z
    Updated At: 2013-03-11T21:39:20Z
    Body
    I think there are some great ideas here. However, you've removed methods that existed on the view models, and also removed methods from interfaces -- which means that functionality that was consumed before no longer will work. In other words, it's not backwards compatible.

That said, I still think they're good ideas; I've simply changed the milestone to 3.0.0, as that will be the earliest we can make these changes.


Comment

User: @MatyCZ
Created On: 2013-06-12T10:09:52Z
Updated At: 2013-06-12T10:09:52Z
Body
There is one Test which fails but I don't understand why:

Zend\View\ViewTest::testModelFromEventIsUsedByRenderer


[ZF3][RFC] View refactoring

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/3935
User: @MatyCZ
Created On: 2013-03-02T15:28:49Z
Updated At: 2014-06-12T10:51:43Z
Body

  • Model options is now situated in separated classes
  • Renderer options is now situated in separated classes too
  • Model options passed to constructor now change model behaviour (options don't have any effect before update)
  • CS fixes
  • Code cleanup
  • Some helpers was modified
  • Create a lot of unexsist property in test classes

* Create a lot of new tests

Comment

User: @prolic
Created On: 2013-03-02T19:33:37Z
Updated At: 2013-03-02T19:33:37Z
Body

looks good on first sight

Comment

User: @weierophinney
Created On: 2013-03-11T21:39:20Z
Updated At: 2013-03-11T21:39:20Z
Body
I think there are some great ideas here. However, you've removed methods that existed on the view models, and also removed methods from interfaces -- which means that functionality that was consumed before no longer will work. In other words, it's not backwards compatible.

That said, I still think they're good ideas; I've simply changed the milestone to 3.0.0, as that will be the earliest we can make these changes.

Comment

User: @MatyCZ
Created On: 2013-06-12T10:09:52Z
Updated At: 2013-06-12T10:09:52Z
Body
There is one Test which fails but I don't understand why:

Zend\View\ViewTest::testModelFromEventIsUsedByRenderer

[ZF3][RFC] View refactoring

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html

Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/3935
User: @MatyCZ
Created On: 2013-03-02T15:28:49Z
Updated At: 2014-06-12T10:51:43Z
Body

  • Model options is now situated in separated classes
  • Renderer options is now situated in separated classes too
  • Model options passed to constructor now change model behaviour (options don't have any effect before update)
  • CS fixes
  • Code cleanup
  • Some helpers was modified
  • Create a lot of unexsist property in test classes

* Create a lot of new tests

Comment

User: @prolic
Created On: 2013-03-02T19:33:37Z
Updated At: 2013-03-02T19:33:37Z
Body

looks good on first sight

Comment

User: @weierophinney
Created On: 2013-03-11T21:39:20Z
Updated At: 2013-03-11T21:39:20Z
Body
I think there are some great ideas here. However, you've removed methods that existed on the view models, and also removed methods from interfaces -- which means that functionality that was consumed before no longer will work. In other words, it's not backwards compatible.

That said, I still think they're good ideas; I've simply changed the milestone to 3.0.0, as that will be the earliest we can make these changes.

Comment

User: @MatyCZ
Created On: 2013-06-12T10:09:52Z
Updated At: 2013-06-12T10:09:52Z
Body
There is one Test which fails but I don't understand why:

Zend\View\ViewTest::testModelFromEventIsUsedByRenderer

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.