geekyshow1 / djangoauthapi1

Hi, I'm Rajesh Kumar

I am Full Stack Web and Android App Developer. I am also an Educator. I teach on having 400k+ Subscribers.

Tech Stack

Languages

Frontend Framework and Lib

Backend Framework and Lib

Database

Mobile Framework

Other

Let's Connect

My GitHub Stats

djangoauthapi1's Issues

Serializer class causes issue saying User() has not attribute password2

Issue Description :

mysite_web  | Attributes are : OrderedDict([('password', 'root'), ('password2', 'root')])
mysite_web  | Internal Server Error: /auth/reset_password/
mysite_web  | Traceback (most recent call last):
mysite_web  |   File "/usr/local/lib/python3.11/site-packages/rest_framework/serializers.py", line 962, in create
mysite_web  |     instance = ModelClass._default_manager.create(**validated_data)
mysite_web  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
mysite_web  |   File "/usr/local/lib/python3.11/site-packages/django/db/models/manager.py", line 87, in manager_method
mysite_web  |     return getattr(self.get_queryset(), name)(*args, **kwargs)
mysite_web  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
mysite_web  |   File "/usr/local/lib/python3.11/site-packages/django/db/models/query.py", line 656, in create
mysite_web  |     obj = self.model(**kwargs)
mysite_web  |           ^^^^^^^^^^^^^^^^^^^^
mysite_web  |   File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 567, in __init__
mysite_web  |     raise TypeError(
mysite_web  | TypeError: User() got unexpected keyword arguments: 'password2'
mysite_web  |
mysite_web  | During handling of the above exception, another exception occurred:

Use update instead of save when saving new password

In below code, we are using .save() method. But as a standard practice, we should rather .update() the password.

class UserChangePasswordSerializer(serializers.Serializer):
  password = serializers.CharField(max_length=255, style={'input_type':'password'}, write_only=True)
  password2 = serializers.CharField(max_length=255, style={'input_type':'password'}, write_only=True)
  class Meta:
    fields = ['password', 'password2']

  def validate(self, attrs):
    password = attrs.get('password')
    password2 = attrs.get('password2')
    user = self.context.get('user')
    if password != password2:
      raise serializers.ValidationError("Password and Confirm Password doesn't match")
    user.set_password(password)
    user.save()
    return attrs