geewynn / blockchain-developer-bootcamp-final-project Goto Github PK

Hi Godwin Ekainu – I am Kuldeep, a mentor who is assisting with the grading. Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, Please provide your Ethereum address for NFT certification. It is missing in the repo. Here's your feedback in the meanwhile:

Frontend Comments:

• Frontend is simple and good work on it.
• Rinkeby testnet
• Frontend is not deployed anywhere. Try to use Github pages to host it.
• I am able to build locally to test the project.

Testing comments:

• Structured properly using Describe.
• All testcase scenarios seem to be covered.

Contract Comments:

• Smart Contract work is fine. A lot of methods will lead to high contract size. Please try to modularise code for Smart Contracts.
• Access control used extensively. Maybe instead of writing Roles.sol, openzeppelin's access-control contract can be used here. Inter-contract execution too works fine here.
• Modifiers used only for validation looks good. Specific solidity version is fixed.
• Only ownable has been used.

Overall:

• Good to have either a MetaMask ""Switch Network"" button or an easier way to users to switch or at least not render content before. Handle account change to update the data according to the account selected on UI
• UI is simple and works well, though it can be cleaner. Smart contract can be modularised. Fine work on testing. Overall a good project but it lacked public deployment.

Hope you enjoyed the learning journey so far and can continue building on this.