geokrety / geokrety-website

Open source item tracking for all caching platforms - This is the actual code beside geokrety.org

GeoKrety.org

GeoKrety.org is a free online service for object tracking in GPS games like geocaching or opencaching. You can track small items, books, coins, pets, or humans with us.

This repository contains the source code running behind GeoKrety.org. If you encounter any security issues, please contact us directly at [email protected].

Getting Started

To get started with the GeoKrety.org source code, please refer to the following files:

• INSTALL.md: Installation instructions.
• CONTRIBUTING.md: Guidelines for contributing to this project.

Installation

For detailed installation instructions, please check out INSTALL.md.

License

This project is licensed under the MIT License.

Contact

If you have any questions or need to report security issues, please contact us directly at geokrety gmail com.

Credits

Powered by Fat-Free Framework

Contributing

We welcome contributions from the community of individuals of all expertise levels. If you'd like to contribute to GeoKrety.org, please review our CONTRIBUTING.md for guidelines on how to get started.

Contributors

Happy coding!

geokrety-website's Issues

Theme refresh

[Imported from bitbuket#49]

Code now include bootstrap, but current layout has not been adapted to follow bootstrap constraints. Templates need to be adapted to use the right css classes. Theme should be responsible.

Edit:
WIP in branch feature/new-theme

Preview this branch: https://new-theme.staging.geokrety.org/

API: comment on geokret require reference number. Maybe it shouldn't

[Imported from bitbuket#92]

For logging the geokret with API it is necesary to provide the secret reference number. Maybe we can skip asking for the reference number?

Issue based on a requests from opencaching.pl team.

kontakt.php to refresh

PR #130 ==> preview here

• link to english / french google forum
• Twitter official account
• irc channel
• support email: fix image
• update last help section: add FB group (French+Dutch one) and G+ Geokrety community
• add left menu 'contact-us'

---

(out of this issue scope)

• note about FB: create international FB Group
• improve CONTRIBUTING.md link and in this file add a section "Notes for users" : mini how-to check/search/report issue/improvement

[FR] Retain language preferences in label generator

[From direct mail]

It would be nice if the label generator could remember the parameters defined.

• Label template
• Help languages

No way to leave a race

[Imported from bitbuket#43]

Currently, it is impossible to leave a race, even if not started. Does it make sense to allow cancellation from a race?

Mobile page is not mobile friendly

The page http://192.168.125.64:8082/m/qr.php?nr=xxx is not well designed to be viewed on mobile.

Also, strings are not marked for gettext usage.

improve datepicker style

From #18

On the ruchy.php page:

improve datepicker style

Change link to download GeoKrety Toolbox

GKT has been moved to a dedicated repository. We have change url on page https://geokrety.org/toolbox.php and clean old version stored in this repo. We could add a redirect 301 in the webserver to not break existing links.

I suggest to use a direct link to the repo like https://github.com/geokrety/GeoKrety-Toolbox/blob/master/GeoKrety.Toolbox.user.js

Geokret widget: generate gkuser image with stats

[Imported from bitbuket#54]

Someone (user:BSLLM) asked me via mail if there is something like found for TB:

The idea is to have a dynamic image generator that can be used to display GK status on some external webpage.

Ex from GC: http://img.geocaching.com/stats/tb.aspx?guid=05bc5b48-e360-435c-9bf6-38ea0a5fd59d

Ex on a profile page for TB https://www.geocaching.com/profile/?guid=a9201139-3fc8-409e-ac9c-bc47089b585f

No translation for "Go!"

Is it possible to add the Button "Go!" in translations?

Access to exports.xml is broken

The page https://geokrety.org/api.php refer to a link to obtains exported data. "To get older data check: here."

The page https://geokrety.org/rzeczy/xml/ is not accessible. Link should point to the cdn.

ErrorException: Allowed memory size: Full export of database

Calling an "export type 1" for long duration break on over memory consumption.

https://geokrety.org/export.php?modifiedsince=20000510032102&kocham_kaczynskiego=********

https://sentry.kumy.org/geokrety/geokrety-legacy/issues/547/

ErrorException: Allowed memory size of 134217728 bytes exhausted (tried to allocate 123015360 bytes)
  File "db.php", line 191, in handleFatalError
    $result = $this->mysqli->query($sql);
  File "templates/sentry-php-master/lib/Raven/ErrorHandler.php", line 0
    Raven_ErrorHandler->handleFatalError

race.php: cant join race

I would like to join a race I just created (?raceid=13).

• txt length is limited to 6 chars, but now GK ref number is 7 length
• if I enforce 7 chars (by using developpers tools), then backend (race_add) refuse my code GK10936 "Ce n'est pas votre GeoKret"

Add an info box on top of GK page when waiting for adoption

Our GK mass generator offer the possibility to adopt GK. The current link to the adopt page is not very visible.

I propose to add an alert message on top of the GK page including explanation and link to the adoption page.

Add a donation link

Following mail conversation.

In order to collect eventual donations from our users, we have to:

• Create a paypal account
• Add a link on the website
• Post a news

Update go2geo.php

go2geo could use a update for nodes because it is outdated. Most OC sites have HTTPS now. Below is part of go2geo.php and edit this to new suggestion. I do not know if there are other files that should be changed for this.

• Countrycode OS is now part of German site and is now also OC.

• Countrycode OJ does not exist anymore.

• Countrycode OL does not exist anymore.

  $prefiksy['2']['OP'] = 'https://opencaching.pl//searchplugin.php?userinput=';
  $prefiksy['2']['OC'] = 'https://www.opencaching.de//searchplugin.php?userinput=';
  $prefiksy['2']['OK'] = 'https://opencache.uk//searchplugin.php?userinput=';
  $prefiksy['2']['OU'] = 'http://www.opencaching.nl/searchplugin.php?userinput='; (New)
  $prefiksy['2']['OU'] = 'http://www.opencaching.ro/searchplugin.php?userinput='; (New)
  $prefiksy['2']['OZ'] = 'https://opencaching.cz//searchplugin.php?userinput=';
  $prefiksy['2']['OS'] = 'http://www.opencaching.se/searchplugin.php?userinput='; (Does not exist anymore)
  $prefiksy['2']['ON'] = 'http://www.opencaching.no/searchplugin.php?userinput=';
  $prefiksy['2']['OJ'] = 'http://www.opencaching.jp/searchplugin.php?userinput='; (Does not exist anymore)
  $prefiksy['2']['OL'] = 'http://www.opencaching.lv/searchplugin.php?userinput='; (Does not exist anymore)
  $prefiksy['2']['OU'] = 'http://www.opencaching.us/searchplugin.php?userinput=';

Field waypoint stay greyed when using "use geolocation"

From #18

On the ruchy.php page:

"3. Nouvel emplacement issue"

Step1) input waypoint
Step2) click on "Utiliser la géolocalisation internet"
Then we can revert position and go back to "Waypoint" use ?

(was already the case in previous version)

Have a second link to fill the form

From #18

On the ruchy.php page:

"3. Nouvel emplacement" improvement

use 'name of cache' 'Verifier' button
Results are showed on the right panel
would be very great to have 2 links
1 link to the cache (we have already)
1 link with cache CODE to fill the form with one click

Automate import of new translations

For a better continuous delivery, we should automate import of new translations from crowdin.

Translations for country and cache types

Could it be possible to add translations for countries and cache types?

GeoKret comment length limited without warning

https://geokrety.org/konkret.php?id=65085#log1330856

Hi,
I was trying to add a looooong comment on a given GeoKret. see example above.
I finish my input and push submit button.
As result I got a cutted message.

Would be very nice to prevent this kind of data loss: prevent submit action and inform the end-user that he should review his input.

(I could try to fix that asap )

PL help page : 404

While switching to PL language, in help menu "Pomoc" gives 404.
(expecting "help_generate.php?help=pl" link instead)

Failed to create with home location

https://sentry.kumy.org/geokrety/geokrety-legacy/issues/550/

ErrorException: mysqli_query() expects parameter 1 to be mysqli, null given
  File "register.php", line 97, in handleError
    $result = mysqli_query($link, $sql);
  File "templates/sentry-php-master/lib/Raven/ErrorHandler.php", line 0, in mysqli_query
    Raven_ErrorHandler->handleError
  File "register.php", line 97
    $result = mysqli_query($link, $sql);

Add a menu link directing to the adoption page

Following #39, what about adding a link to the adoption page directly in the left menu.

What should be it's place?

It should be displayed only for authenticated users.

Donate paypal in French

Perhaps it is better when connect to paypal to use English or browser language. Now i see French :-(

waypoints are not working

some of the waypoints are not working, e.g.
OP8RRA, OP8R8Q, OP8RRE, OP8R8S, OP8R8R, OP8R8N, OP8R8M
... e.g. OP8S4F, OP8S4G, OP8S4H etc...
:(

ErrorException: sprintf(): Too few arguments

https://sentry.kumy.org/geokrety/geokrety-legacy/issues/605/

ErrorException: sprintf(): Too few arguments
  File "mypage.php", line 252, in handleError
    $statystyki_obce = sprintf(_('%s has moved <b>%s</b> GeoKrets on a total distance of <b>%s</b> km.'), $user, $geokretow_w_puli, $droga_geokretow_obcych);
  File "templates/sentry-php-master/lib/Raven/ErrorHandler.php", line 0, in sprintf
    Raven_ErrorHandler->handleError
  File "mypage.php", line 252
    $statystyki_obce = sprintf(_('%s has moved <b>%s</b> GeoKrets on a total distance of <b>%s</b> km.'), $user, $geokretow_w_puli, $droga_geokretow_obcych);

Hover on "Name" input text show a popup that is behind Date input

From #18

On the ruchy.php page:

"4. Données supplémentaires" issue

Hover on "Name" input text show a popup that is behind Date input

Improve search engines indexation

Improve Geokrety search engine optimization.

Following actions could be done:

• "enhance pages semantic",
• check current robots.txt https://github.com/geokrety/geokrety-website/blob/master/robots.txt
  probably responsible for the non indexation of geokrety.
• enhanced sitemap.

Most important content:

• Geokret details : https://github.com/geokrety/geokrety-website/blob/master/konkret.php
• Help pages

Edit home position is broken

The map is broken with message: Oops! Something went wrong. This page didn't load Google Maps correctly. See the JavaScript console for technical details.

The console shows:

Google Maps API error: InvalidKeyMapError https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error js:38:430
Google Maps API warning: InvalidKey https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key util.js:228:12
Google Maps API warning: SensorNotRequired https://developers.google.com/maps/documentation/javascript/error-messages#sensor-not-required util.js:228:12

phplint errors with php 7.x

Enabling phplint with php 7 reveal many "Deprecated issues". Most of them are in included libraries. We have to check if libraries upgrade will fix the issues.

See build https://travis-ci.org/geokrety/geokrety-website/builds/368394974

Missing translations on main page

Some translations are not visible on main page and show English language. I believe this happened last weekend.

Some untranslated lines

There are some more untranslated lines on https://geokrety.org/country_stat.php

Security bypass in export2.php

geokrety-website/export2.php

Line 80 in 8ab5f12

if (($jak_stare_dane > $limit_czasu_s) and ($g_kocham_kaczynskiego != $kocham_kaczynskiego) and ($od > 0) and (count($_GET) == 1)) { // jeśli modifiedsince jest jedynym argumentem...

Security can easily be bypassed if there is more than one query parameter.

GDPR: update 'Terms of service'

add some sentence about GDPR into the 'Terms of service': which personnal data are stored

Feature Request - Rate limit `export*.php`

We started to talk about that in #10 and #11.

The export*.php are quite time consuming. We should deploy some kind of rate limiting on those endpoints.

It seems possible to achieve this using NGinx

Some partners should be able to do lot of queries to synchronize their database. This include at least opencaching* sites, geokretymap.org.

Untranslated string

From #18

On the ruchy.php page:

"4. Données supplémentaires" issue

commentaire "max length" (en/fr??)

2 red error icons shown

From #18

On the ruchy.php page:

"2. Objet voyageur" issue : 2 red error icons (1 expected?)

question (minor) adduser.php / mcrypt_encrypt warning on success

Hi
While trying on local instance, I got this warning on register:

Unable to reproduce on rec.geokrety.org

Seems not linked to konfig-xxx

do you confirm: it's only when userid is very small ??

Waypoint number result on logpage

When search by cache name sometimes there are more caches with same or partly same search names in it. Loggers cannot select the correct waypoint to addl in left field without first go (via link) to the cachepage.

Perhaps add waypoint to result, so user can copy/past to waypoint field. Or by klick on suggested cache the correct waypoint goes to waypoint field.

Edit username

Sometimes people do ask how to change their username. On most sites you can change your username. Perhaps it can be made that users can change their username on the GK site also.

contributors quickstart howto with docker-compose

provide a quick start for website contributor (readme or wiki).

Branch: feature/docker-compose

Scope of this issue:

• separate website code from install files
  • check non-regression for travis_ci
  • check non-regression for integ/prod installation (kumy?)
  • travis translation dedicated steps neeed to continue to work
• ( readme/installation.md ) howto start local version of the website (ie. to test improvement or bugfix)
  • check user subscribe is working locally (pending boly38)
  • improve markdown content
• ( readme/4programmers.md ) team good practice
  • add tips about commit format

improvement idea (not required as acceptance criteria as it could be done later)

• pull request requirements
• some word about friend projects
• add installation.md howto section when using linux and docker directly
• (compose) test the way to mount docker volume (between window host and docker-machine) doc

Allow some code/markup in geokret description content

As end-user I would like to improve GeoKret description field (ex image, colors, link+label...: simplified html) like the geocaching cache description.

Not sure about:

• postpone to future GK portal ?
• is this improvement really needed ? (to give your opinion about this improvement add +1/-1 icon to this text)

No check to prevent registration on a started race

[Imported from bitbuket#42]

Even if the UI doesn't allow to register a GK to an already started race, it is technically possible to bypass this rule.

No translations for.....

There are missing some translations for different pages. Next picture shows one of them :-)

hall of fame image broken

https://geokrety.org/halloffame.php
bottom of this page includes broken image for tools.

---

work branch: feature/halloffame

---

• improve config 'icon_width'
• integrate into target page (demo)
• move icons files to CDN and update related config url
• squash, rebase, PR

Wrong graphics on german help page

When accessing https://www.geokrety.org/help_generate.php?help=de#Chooselogtype (in german) the log type icons are incorrect. When using the page in english, everything seems OK.
No idea whether this is a bug in the page code or in hyperlinks coming in from translations.

In fact it is a repitition of the geokrety type icons (see above):

Geokrets on the map - image broken

The following page should contain an image https://geokrety.org/mapa.php

https://geokrety.org/mapki/world.png is broken

New "logging form" - bugs

In Google English ;)
Big buttons are probably a nod to phones, it does not look very nice on the computer.

1. Unfortunately, the login of moles by the cache name does not work on the new site. Ie. searches the box but the OP number is not completed :(
2. if I am not logged in appears (less visible than before, it should remain red) message in English "Although it is possible ...."
3. in general many messages (previously in Polish) are now in English
4. "Date of operation": on the right there is a kind of button that seems to open the calendar, it does not happen.
5. "GeoKreta Identification" - there used to be a name, now only TC
   Probably it was supposed to be good and functionally worse than it was :(

In Polish:
Duże przyciski chyba są ukłonem w stronę telefonów, na komputerze nie wygląda to zbyt ładnie.

1. Niestety na nowej stronie nie działa logowanie kretów według nazwy kesza. Tzn. wyszukuje skrzynkę ale nie uzupełnia się numer OP :(
2. jeśli jestem niezalogowany pojawia się (mniej widoczny niż poprzednio, powinien pozostać czerwony) komunikat w j.angielskim "Although it is possible...."
3. w ogóle wiele komunikatów (wcześniej po polsku) teraz jest w angielskim
4. "Data operacji": po prawej jest taki jakby przycisk, który wydaje się powinien otwierać kalendarz, tak się nie dzieje.
5. "Identyfikacja GeoKreta" - kiedyś była nazwa, teraz tylko TC
   Pewnie miało być dobrze a wyszło funkcjonalnie gorzej niż było :(

JpGraphExceptionL: Either X or Y data arrays contains non-numeric values. Check that the data is really specified as...

https://sentry.kumy.org/geokrety/geokrety-legacy/issues/554/

JpGraphExceptionL: Either X or Y data arrays contains non-numeric values. Check that the data is really specified as numeric data and not as strings. It is an error to specify data for example as '-2345.2' (using quotes).
  File "jpgraph-3.5.0b1/src/jpgraph_errhandler.inc.php", line 113, in RaiseL
    throw new JpGraphExceptionL($errnbr,$a1,$a2,$a3,$a4,$a5);
  File "jpgraph-3.5.0b1/src/jpgraph.php", line 5408, in __construct
    JpGraphError::RaiseL(25070);
  File "jpgraph-3.5.0b1/src/jpgraph_line.php", line 39, in LinePlot
    parent::__construct($datay,$datax);
  File "tabela_statystyki_rysuj.php", line 46, in wykresuj
    $lineplot =new LinePlot($y, $x);
  File "tabela_statystyki_rysuj.php", line 79
    wykresuj("all_gk_", $data, $gk_, "Date", "Geokretów total", "");