GithubHelp home page GithubHelp logo

Comments (8)

SDymon avatar SDymon commented on July 17, 2024 1

In that case I think the issue will be resolved.

from geokrety-website.

kumy avatar kumy commented on July 17, 2024

If someone want to make a PR
it's around here
https://github.com/geokrety/geokrety-website/blob/main/website/public/app-ui/css/app.scss#L51-L53

from geokrety-website.

SDymon avatar SDymon commented on July 17, 2024

Если кто-то хочет сделать пиар, это здесь https://github.com/geokrety/geokrety-website/blob/main/website/public/app-ui/css/app.scss#L51-L53 .

I don’t understand which parameter regulates the height of the map window. I think it needs to be doubled.

from geokrety-website.

kumy avatar kumy commented on July 17, 2024

Then height: 800px on quoted line should do the trick.

from geokrety-website.

kumy avatar kumy commented on July 17, 2024

Just thought: as such it will also affect the map height on mobile. the CSS should be made to have a specific size on desktop and another on mobile (400px) is enough for mobile.

from geokrety-website.

SDymon avatar SDymon commented on July 17, 2024

In this case, it should be saved in the user settings, as well as amount of geokret's displayed on the page. At the moment, this does not work when re-authorizing (this functionality simply does not exist)

from geokrety-website.

kumy avatar kumy commented on July 17, 2024

In this case, it should be saved in the user settings

hum, storing the prefered map height in the user setting is a bit complicated, as the css are not managed by php. And that would not make the sizes different on desktop and mobile.

I suggest to define the value twice, one with the default value for desktop, and a second enclosed by @media (max-width: 991px) {} for mobile (we may have other sizes for tablets...

At the moment, this does not work when re-authorizing (this functionality simply does not exist)

Sorry what do you mean? I can't get your thought with this issue context.

from geokrety-website.

SDymon avatar SDymon commented on July 17, 2024
  1. I absolutely agree with the proposal to store settings separately for the desktop and separately for mobile.
  2. Perhaps I did not mention earlier and did not suggest the following defect for correction. At the moment, when viewing "My Inventory", 10 pieces are displayed by default. It is not comfortable. It is advisable that the setting of the quantity of displayed geokret's be saved.

from geokrety-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.