geometrically / gravestones Goto Github PK

Reproduction:

• Die to ender dragon
• It destroys the gravestone
• You gain gravestone as an item
• Your items ARE GONE FOREVER

Minecraft version: 1.16.5
Mod version: 1.7
Loaded Mods: Fabric API, Gravestones

Issue behavior:
Dying in any way on a bedrock block at any Y-level does not generate a gravestone. Replacing even the lowest level block of bedrock with any other block (such as stone), and dying on that block generates a gravestone. Placing a piece of bedrock at Y-64 and dying on it does not generate a gravestone.

A few mods use the extra inventory slots those provide. But currently when you die, those items get thrown on the ground instead. Support for those mods would be awesome, especially considering Better Graves doesn't have proper support either.

Minecraft: 1.16.1
Gravestones: 1.3.1
The modpack used is AoF 3 1.1.1

See crash log https://paste.ee/p/u3dOs, seems to be thrown in https://github.com/Geometrically/Gravestones/blob/master/src/main/java/net/guavy/gravestones/Gravestones.java#L96 when it tries to place a block outside the world.

When dying and picking up your grave, items stored in Backslots' slots are deleted. This is quite annoying, especially since the slots are for tools. Wouldn't want to lose your netherite pick when you crash into a wall while flying, now would you?

MC Ver.: Fabric 1.16.3

Crashlog: None, doesn't crash the game, just deletes items

Any item in a slot created by mods using the Curios API (like the ones mentioned down below) does not get transferred to a gravestone, and is dropped on the floor. Tested on the client and server. No crash reports (or suspicious console messages) are available.
Mod Versions:
Fabric API 0.23.0+build410-1.16
Gravestones 1.5
Curios API 0.0.8-1.16.3
Curio of Undying 1.1.0-1.16.3
Curious Elytra 1.1.0-1.16.3

So, I'm on a server who has your gravestones on its server, I had 30 experience levels on me when I died... and when I broke the gravestone to retrieve my stuff I got 40 levels in return... I proceed to intentionally die 3 more times to see if it's consistent, and it was, but after the 5th time doing it I started losing levels.

I was wondering if there's something wrong with the Gravestones, because it was giving me levels, but isn't anymore...

gravestones v1.11.1
fabric v0.14.6-1.18.2
Minecraft 1.18.2

upon retrieval of items, no xp is ever returned to the player even after adjusting the slider option

Gravestone tried spawn in a water block and therefore broke, I would assume.

gravestone "spawned" at death

apparent location of "spawn"

empty gravestone placed down, after picking up from floating on top of the water. breaking it only pops it as an item.

I died to a creeper ~2 seconds after entering the end, no gravestone, lost everything

There was a BUG between the Graves and all of half-block [I think].

Died in lava in the Nether, lava source block was removed where I died but Gravestone was never generated. Lost all items.

I'm playing on the fabric SMP and twice now I've been blown up by a creeper and the explosion destroys the grave the spawns. The first time it got blown up and dropped a blank grave item that I can place and break with no loot. The second time it didn't seem to drop an item.

I tried updating it myself but I couldn't retrieve items from the grave lol.

I am using the Artifacts mod in my modpack. If you die with an equipped item from this mod, then put another item in the same slot before looting the grave, then during the looting of the mogiga, the previously worn item will be replaced and disappear irrevocably. Can you fix this?

Sorry for my bad english.

After I die I consistently do not get my iron chestplate back, it's the only thing absent that I can tell. So i just end up crafting another. I am using the trinkets mod by the way, which adds an elytra slot next to the chestplate slot. Otherwise great mod, although my friends complained if you die in the void the gravestone doesn't spawn at like y:10 or something.

I've had some issues with the mod a couple of times, but usually destroying the gravestone once, then equipping backpack, then destroying it second time - fixed stuff.
But today I've lost everything inside my backpack. Items were duplicated - moving them over each other made them merge. Finally gravestone disappeared after I put everything I got in a chest, I've got back my exp but insides of backpack - gone.

Gravestones 1.9
Campanion 1.3.5
MC 1.16.5

[19:22:28] [Server thread/FATAL]: Error executing task on Server
java.lang.UnsupportedOperationException: null
	at java.util.AbstractList.remove(Unknown Source) ~[?:1.8.0_281]
	at net.minecraft.class_2371.remove(class_2371.java:65) ~[intermediary-server.jar:?]
	at java.util.AbstractList$Itr.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.SubList$1.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.Collection.removeIf(Unknown Source) ~[?:1.8.0_281]
	at com.terraformersmc.campanion.compat.CampanionGravestonesCompat.setInventory(CampanionGravestonesCompat.java:31) ~[campanion-1.3.5.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.RetrieveGrave(GravestoneBlock.java:161) ~[gravestones-v1.9.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.method_9576(GravestoneBlock.java:68) ~[gravestones-v1.9.jar:?]
	at net.minecraft.class_3225.method_14266(class_3225.java:248) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_21717(class_3225.java:222) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_14263(class_3225.java:197) ~[intermediary-server.jar:?]
	at net.minecraft.class_3244.method_12066(class_3244.java:1008) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_12361(class_2846.java:40) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_11054(class_2846.java:10) ~[intermediary-server.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[intermediary-server.jar:?]
	at net.minecraft.class_3738.run(class_3738.java:18) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:144) ~[intermediary-server.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:761) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:155) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:118) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:743) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:737) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18857(class_1255.java:127) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:722) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:674) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[intermediary-server.jar:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]
[19:22:36] [Server thread/FATAL]: Error executing task on Server
java.lang.UnsupportedOperationException: null
	at java.util.AbstractList.remove(Unknown Source) ~[?:1.8.0_281]
	at net.minecraft.class_2371.remove(class_2371.java:65) ~[intermediary-server.jar:?]
	at java.util.AbstractList$Itr.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.SubList$1.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.Collection.removeIf(Unknown Source) ~[?:1.8.0_281]
	at com.terraformersmc.campanion.compat.CampanionGravestonesCompat.setInventory(CampanionGravestonesCompat.java:31) ~[campanion-1.3.5.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.RetrieveGrave(GravestoneBlock.java:161) ~[gravestones-v1.9.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.method_9576(GravestoneBlock.java:68) ~[gravestones-v1.9.jar:?]
	at net.minecraft.class_3225.method_14266(class_3225.java:248) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_21717(class_3225.java:222) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_14263(class_3225.java:197) ~[intermediary-server.jar:?]
	at net.minecraft.class_3244.method_12066(class_3244.java:1008) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_12361(class_2846.java:40) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_11054(class_2846.java:10) ~[intermediary-server.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[intermediary-server.jar:?]
	at net.minecraft.class_3738.run(class_3738.java:18) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:144) ~[intermediary-server.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:761) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:155) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:118) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:743) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:737) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18857(class_1255.java:127) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:722) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:674) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[intermediary-server.jar:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]
[19:23:01] [Server thread/FATAL]: Error executing task on Server
java.lang.UnsupportedOperationException: null
	at java.util.AbstractList.remove(Unknown Source) ~[?:1.8.0_281]
	at net.minecraft.class_2371.remove(class_2371.java:65) ~[intermediary-server.jar:?]
	at java.util.AbstractList$Itr.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.SubList$1.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.Collection.removeIf(Unknown Source) ~[?:1.8.0_281]
	at com.terraformersmc.campanion.compat.CampanionGravestonesCompat.setInventory(CampanionGravestonesCompat.java:31) ~[campanion-1.3.5.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.RetrieveGrave(GravestoneBlock.java:161) ~[gravestones-v1.9.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.method_9576(GravestoneBlock.java:68) ~[gravestones-v1.9.jar:?]
	at net.minecraft.class_3225.method_14266(class_3225.java:248) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_21717(class_3225.java:222) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_14263(class_3225.java:197) ~[intermediary-server.jar:?]
	at net.minecraft.class_3244.method_12066(class_3244.java:1008) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_12361(class_2846.java:40) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_11054(class_2846.java:10) ~[intermediary-server.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[intermediary-server.jar:?]
	at net.minecraft.class_3738.run(class_3738.java:18) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:144) ~[intermediary-server.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:761) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:155) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:118) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:743) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:737) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18857(class_1255.java:127) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:722) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:674) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[intermediary-server.jar:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]
[19:23:22] [Server thread/FATAL]: Error executing task on Server
java.lang.UnsupportedOperationException: null
	at java.util.AbstractList.remove(Unknown Source) ~[?:1.8.0_281]
	at net.minecraft.class_2371.remove(class_2371.java:65) ~[intermediary-server.jar:?]
	at java.util.AbstractList$Itr.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.SubList$1.remove(Unknown Source) ~[?:1.8.0_281]
	at java.util.Collection.removeIf(Unknown Source) ~[?:1.8.0_281]
	at com.terraformersmc.campanion.compat.CampanionGravestonesCompat.setInventory(CampanionGravestonesCompat.java:31) ~[campanion-1.3.5.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.RetrieveGrave(GravestoneBlock.java:161) ~[gravestones-v1.9.jar:?]
	at net.guavy.gravestones.block.GravestoneBlock.method_9576(GravestoneBlock.java:68) ~[gravestones-v1.9.jar:?]
	at net.minecraft.class_3225.method_14266(class_3225.java:248) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_21717(class_3225.java:222) ~[intermediary-server.jar:?]
	at net.minecraft.class_3225.method_14263(class_3225.java:197) ~[intermediary-server.jar:?]
	at net.minecraft.class_3244.method_12066(class_3244.java:1008) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_12361(class_2846.java:40) ~[intermediary-server.jar:?]
	at net.minecraft.class_2846.method_11054(class_2846.java:10) ~[intermediary-server.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[intermediary-server.jar:?]
	at net.minecraft.class_3738.run(class_3738.java:18) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:144) ~[intermediary-server.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:761) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:155) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:118) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:743) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:737) ~[intermediary-server.jar:?]
	at net.minecraft.class_1255.method_18857(class_1255.java:127) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:722) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:674) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[intermediary-server.jar:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]

Items in the special inventorio slots get deleted when dying and claiming grave

Players on my server are exploring and dying far from home. They often just have a guess of the general direction their grave would be in.

Would it be possible to add an item that lets players find their nearest grave? From a gameplay perspective, i would love if this comes with a cost. A crafting cost and/or a usage cost. An item like the eye of ender comes to mind, where its cost to use is a potential chance for it being destroyed after use. In this example, the crafting recipe could be an enderpearl and a bone.

If this is out of the scope for the mod, would you consider adding a line to the log each time a grave is spawned, with its coordinates? That way we can guide our players to the general area of their graves manually.

It would be cool if this mod added an obituary or basically a paper with death coordinates just like the Forge counter part of this mod! :)

As title says. Even with items in the inventory. Using latest Gravestones mod version for 1.16.

So, i was playing with some friends in a server, and one of them died. Then, someone accidentally broke his gravestone, and, when we placed it back on the floor, the items weren't there, and he had netherite. How do i fix it??? I already made a comment like this one in the CurseForge page.

latest.log

please find the log file attached.

Here is a list of all the mods that the server is running:

i recommend implementing a log which contains a history of which items were contained within which graves.
This way, in the event of this error, or any user error, there is a log of all items what were lost.
this should makeit easier for server owners to restore a players lost items.

As title says. Related commit fa97f7b

Example:

The items in the special inventory slots that inventorio adds don't appear when the gravestone is broken/claimed (I lost all my tools and food in my survival world because of this)

Single-player use works well.

In my Fabric server, the mod doesn't seem to load on startup (I have other mods that load fine). And when a player dies, nothing happens.

What is the process for use on the server side?

basically its like the mod never existed in the first place, I suspect a mod is interfering with the gravestones, but I don't know which. i tried on different world but same issue appears. heres my modlist

modlist.txt

No idea where I should report it so imma just put it on all three githubs I guess.

Using
Inventorio https://github.com/Lizard-Of-Oz/Inventorio
Gravestones https://github.com/Geometrically/Gravestones/issues
Requiem https://github.com/Ladysnake/Requiem

If you die while possessing a mob, weird stuff happens.

• a grave gets created, but most of the items just fall out like normal rather than go into the grave
• your currently selected hotbar slot, offhand slot gets deleted
• your currently selected toolbar slot (i was mining while it happened) gets duped

My inventory before I died

My inventory after I died BUT before I broke the grave (all these items were on the ground)

My inventory after picking up what was in the grave too

When I die on the water or in the water the Gravestone disappears and it is impossible to recover my items, is there a way to make the gravestone indestructible ?

On death, trinkets on the player's body are NOT in the gravestone and NOT dropped on the ground. They are simply deleted from existence. Relevant versions and mods:

Minecraft 1.16.5
Fabric Loader 0.11.2
Fabric API 0.31
Gravestones 1.9
Trinkets 2.6.7
Artifacts 2.3.0

none of the options to collect items seems to get the items, breaking it just gives the stone itself. using on latest AOF3 version.

generated a gravestone as item that could be picked up; did neither disappear on breaking, nor release any items. All items lost.

When using the mod on the server, if the client doesn't have the mod they can't see their grave.

Otherwise, the mod works! The grave is there, it's just invisible. I've tested it a few ways. If I know where the grave is, I can jump on top of it, crouch, and get my stuff back.

Can an option be added to create a vanilla friendly gravestone? Maybe something with armor stands and the players head?

I don't know if this is a mod incompatible but when I died the items still in my inventory, and then dig the gravestone, this causing a duplicate all items in my inventory

here is my list installed mod

Minecraft 1.16.1 fabric 0.8.8 build 202 API ver. 0.14.1 Gravestones 1.3.2

[FabricLoader] Loading 134 mods: [email protected]+3fa9f7c502, [email protected], [email protected]+build.202, [email protected], [email protected], [email protected], [email protected]+1.16, [email protected]+a71b305302, [email protected], [email protected]+12a8474c7c, [email protected]+build.35, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]+c6a8ea8902, [email protected], [email protected], [email protected], [email protected]+build.372-1.16, [email protected], [email protected], [email protected]+e00ecb5f02, [email protected]+build.48, [email protected]+f362c86e02, [email protected]+build.17, [email protected], [email protected]+build.7, [email protected], [email protected]+5794386e02, [email protected], [email protected], [email protected]+059ea86602, [email protected]+7066030f7c, [email protected]+b7f9825d02, [email protected], [email protected]+build.1, [email protected]+e16a977402, [email protected], [email protected], [email protected], [email protected]+f41e209802, [email protected], [email protected]+arne.1, [email protected], [email protected], [email protected], [email protected], [email protected]+1.16-pre2, [email protected]+0eb9ac7, [email protected], [email protected]+52d3083602, [email protected]+7dba2d6c02, [email protected], [email protected]+b764ce9902, [email protected], [email protected]+438f963602, [email protected]+dfdb52d602, [email protected], [email protected], [email protected]+eae12eb802, [email protected]+1.15.2, [email protected]+1.16, [email protected], [email protected], [email protected]+1.16-pre2, [email protected], vanilla-hammers@${version}, [email protected], [email protected]+045df74f02, [email protected], [email protected]+e00ecb5f02, [email protected], [email protected]+b7f9825d02, [email protected], [email protected]+eae12eb802, [email protected], [email protected], [email protected], [email protected]+b7084faa02, [email protected], [email protected], [email protected]+b0993bc102, [email protected], [email protected], [email protected]+5a0f9a6002, [email protected], [email protected]+059ea86602, [email protected]+0a6f2a7002, [email protected], [email protected], [email protected], [email protected]+b50ffc7b02, [email protected]+5ce5339802, [email protected]+j1.2.0, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]+4d66bed502, [email protected], [email protected], [email protected]+16acbe5b02, [email protected], [email protected], [email protected], [email protected]+5341049002, [email protected]+346247d702, [email protected], [email protected], [email protected], [email protected]+059ea86602, [email protected], [email protected]+a4c57d8e02, blue_endless_jankson@+, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]+16acbe5b02, [email protected]+da175ad602, [email protected]

Could you give a warning that gravestone are not lava proof?

Is there a backup of my inventory somewhere that I am missing?

Despite having the experience percentage set to 75% XP restored on retrieval, no XP is given to the player once the grave is retrieved. Both mods are installed for the client and the server, and the client config matches the server config.

Server config:

{
"mainSettings": {
"enableGraves": true,
"enableGraveLooting": false,
"sendGraveCoordinates": false,
"minimumOpLevelToLoot": 4,
"retrievalType": "ON_USE",
"dropType": "PUT_IN_INVENTORY",
"xpPercentage": 0.75
}
}

Is there a way for the gravestone to be indestructible by any means unless players interact with them? Many scenarios tend to make the gravestones disappears.

Dying inside a ladder near the nether roof caused no gravestone to spawn on death, all items disappeared

While testing Gravestones with Trinkets and Bunch o' Trinkets I found an item duplication issue. On death with full inventory, armor, and trinket slots, all items were correctly placed in the gravestone. However the trinkets were also dropped on the ground. On returning to the gravestone I was able to retrieve all the items as expected, but the duplicate trinkets were also on the ground to pick up.

Recently observed this happening to fellow players on a 1.16.5 server. Not sure this is intended behaviour but should be fixable by adding a dragon_immune tag. I might even write a PR soon if I'm able.

If a player dies on top of a gravestone (such as in lava from tping back to last death) the last grave is overwritten and a new grave is spawned causing everything to be lost.