gergely-nagy / react-pricing-table Goto Github PK

I want to remove button(signup, try for free) from the pricing table.

I think it'd be nice to support custom components for the PricingSlot price & title (possibly elsewhere too, these seem like the most important to be customisable to me).

I started working on this, I'll publish the branch to my fork soon (I want to test it more & write an example, possibly tests too).

Would you be open to this ?

Here's how it currently looks like:

<PricingSlot
    priceText="$ 200"
    priceAccessor={customPrice}
>

const customPrice = ({ className, text }) => {
	return (
		<li className={className}>
			<span>Starting at</span>
			<span>{text}</span>
		</li>
	)
}

The className & text props are "tags" & this.props.priceText respectively. Not sure we should pass them to custom components, but then again why not ? And I've made pretty much the same thing for the title, allowing for custom title component.

Thoughts ?

Would be great if you could add more features.

• Carousel
• Variable pricing (With a slider)

Also if you can add better UI and templates

• With carousel
• With animations

Also, is there a way to contribute. If I send a pull request would you accept it?

Is there any way to easily accommodate for React-router server side rendering w/ Webpack (example setup https://alligator.io/react/react-router-ssr/)? Trying to squeeze some SEO, and despite my best efforts with some pretty gnarly hacks I still get window is not defined

Error:

... /node_modules/react-pricing-table/lib/react-pricing-table.min.js:6
ReferenceError: window is not defined

Some other peeps who seemed to have same issue on other react components but fixed it -
airbnb/lottie-web#440