gerteunis / openssl-osx-pod Goto Github PK

Hi,

for the last few days I tried to fix the issue of installing / updating our Pods.
Long story short: I think the install script needs to be modified, as it tries to download the OpenSSL source like this:

curl "https://openssl.org/source/openssl-${VERSION}.tar.gz"

But OpenSSL.org is now redirecting to its www subdomain and curl does not follow redirects by default and downloads the HTTP status page instead. The correct link is:

https://www.openssl.org/source/openssl-${VERSION}.tar.gz

It would be great if you could update the link or add the -L option to the curl call, which should follow the redirect AFAIK.

Cheers,
Lukas

Current pod is broken, consider changing to the latest openssl version. As I mentioned in #5, pointing to release tag (here in this repo, or openssl releases) would be much more safe, no new openssl release will break the pod in this way anymore.

Installing OpenSSL-OSX (1.0.204.1)

[!] Error installing OpenSSL-OSX
[!] /usr/bin/curl -f -L -o /var/folders/kh/9rw5rwln3_74r_g69jn93t8h0000gn/T/d20160117-26482-1l5tnba/file.tgz https://openssl.org/source/openssl-1.0.2d.tar.gz --create-dirs

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (22) The requested URL returned error: 404 Not Found

openssl.org says, that the current download url is https://openssl.org/source/openssl-1.0.2e.tar.gz and all the previous versions are being placed into https://openssl.org/source/old/openssl-*.tar.gz

Wouldn't it be better to attach an archive to release tag and not being dependent on openssl.org?

The download URL (https://openssl.org/source/openssl-${VERSION}.tar.gz) is specified in the s.source and also downloaded with curl inside the s.prepare_command. Isn't it supposed to be downloaded by CocoaPods and verified with the SHA1 checksum provided? The curl command also doesn't appear to have the same checksum verification.

See title

See title

When I go to install on a new machine, I get this:

Installing OpenSSL-OSX (1.0.204.1)

[!] Error installing OpenSSL-OSX
[!] /usr/bin/curl -f -L -o /var/folders/ps/q06206rd5130ps8s6f09zdg4000086/T/d20160104-61691-1ni01qa/file.tgz https://openssl.org/source/openssl-1.0.2d.tar.gz --create-dirs

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (22) The requested URL returned error: 404 Not Found

It looks like 1.0.2d was taken down and replaced with 1.0.2e. Can you please update?