GithubHelp home page GithubHelp logo

Comments (12)

onebeastchris avatar onebeastchris commented on May 30, 2024 2

While it probably is the direct cause, the only way that code should open an inventory would be if Geyser thinks that any other inventory is already open.
What I suspect is happening is that the inventory close handler is sending a close confirmation to the client before clearing the current inventory in Geyser. I'll try to take a look at this later today

from geyser.

onebeastchris avatar onebeastchris commented on May 30, 2024

Does this issue also occur with this build?
https://github.com/GeyserMC/Geyser/actions/runs/8296491137

from geyser.

DimaSergeew avatar DimaSergeew commented on May 30, 2024

Does this issue also occur with this build? https://github.com/GeyserMC/Geyser/actions/runs/8296491137

In the latest version of Geyser, I was receiving numerous complaints about this issue. In this version, as demonstrated, there have been significantly fewer complaints, but some still exist and the bug remains unresolved.

from geyser.

Hahaa13 avatar Hahaa13 commented on May 30, 2024

Double click and error
And chest,inventory,... cannot open

from geyser.

Folas1337 avatar Folas1337 commented on May 30, 2024

I've also had two users report the same issue with the inventory freezing or in other words being unable to open inventories.

One user has given me some more details:

  • He first opened the inventory manually then closed it manually
  • The game seems to have force-opened the inventory for him again as if it hadn't understood that it was closed
  • He then closes it again and afterwards this bug happens

He is then unable to open his own inventory or any containers but he can apparently open shulker boxes which then look as if they were opened but he can still move freely.

Edit 1: Here's a video this one user has shared: https://media.discordapp.net/attachments/1043999734735581214/1221818163096850503/812fb867-0e18-4287-abe2-7da283edbe91.mov?ex=6613f5d6&is=660180d6&hm=85fc613f6b67eed1f5193bb39e46bef4e00924b8dd8e34837c87d2c78ed7e072&
This time however it wasn't him manually closing it but it appears to be reopening just before it finally closes

More info might be added as we investigate but that's all I have for now.

from geyser.

Trihienkun avatar Trihienkun commented on May 30, 2024

Is there any way to fix this error?

from geyser.

R00tB33rMan avatar R00tB33rMan commented on May 30, 2024

I can reproduce this issue. Occurs with a large sum of my users. The evidence provided in the initial report explicitly represents what I've been facing.

from geyser.

qrvgqwe avatar qrvgqwe commented on May 30, 2024

here's the problem 112f4dd

from geyser.

onebeastchris avatar onebeastchris commented on May 30, 2024

Able to replicate. Unfortunately i don't have enough time at the moment to try and resolve the root cause (where Geyser doesn't seem to react fast enough to inventories being opened/closed). I've made a PR that reverts the commit linked here - thanks for the research btw, appreciate it.

from geyser.

DimaSergeew avatar DimaSergeew commented on May 30, 2024

Able to replicate. Unfortunately i don't have enough time at the moment to try and resolve the root cause (where Geyser doesn't seem to react fast enough to inventories being opened/closed). I've made a PR that reverts the commit linked here - thanks for the research btw, appreciate it.

  • I noticed another 1 problem, I use the plugin TrydeSystem, and when a player cancels a transaction screen hip player becomes black, and he needs to restart the game, I noticed that such a problem is not in GeyserMC in ptacha where added 1.20.60
  • now I put the latest build with the inventory fix cancelled and the problem still remains

from geyser.

DimaSergeew avatar DimaSergeew commented on May 30, 2024

Able to replicate. Unfortunately i don't have enough time at the moment to try and resolve the root cause (where Geyser doesn't seem to react fast enough to inventories being opened/closed). I've made a PR that reverts the commit linked here - thanks for the research btw, appreciate it.

I can spend a couple of days of my time and check all patches after 1.20.60 and find the one that broke the inventory system

from geyser.

onebeastchris avatar onebeastchris commented on May 30, 2024

Besides this commit, no other major changes have been done that would impact the inventory system.
If you want to troubleshoot and find the root cause - feel free to. As for the trading issue, create a new issue with reproduction steps

from geyser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.