GithubHelp home page GithubHelp logo

Published 1.5.1 broke public API about rspirv HOT 8 CLOSED

kvark avatar kvark commented on July 18, 2024
Published 1.5.1 broke public API

from rspirv.

Comments (8)

antiagainst avatar antiagainst commented on July 18, 2024 1

That comment was made quite some time ago when we saw the first breakage. Things do change and I'm certainly not trying to hold back improvements. :) We had similar discussions in another thread later (see here) where I suggested to retire the spirv_headers create and use the spirv crate instead to have a clean slate for using semver. This might be the time to really push towards that.

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024 1

@antiagainst Agreed, filed #197 for further discussion around how to proceed :-)

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

spirv_headers don't follow semantic versioning so breakage like this is sort-of unavoidable without some changes to the policy of this project :-(

We've run into this before with #117

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

For reference - required_capabilities and required_extensions got moved into Operand instead because there can be multiple capabilties or extensions required.

from rspirv.

kvark avatar kvark commented on July 18, 2024

Wait, #117 was actually fixed, and sanity was restored. Are you saying that the current breakage is intended?

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

In #117 a workaround got introduced to not break semver, however in this case I'm not sure we can (see previous comment).

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

It's specifically this comment that explains why we're in this spot though I'm not a big fan (for obvious reasons).

from rspirv.

ErichDonGubler avatar ErichDonGubler commented on July 18, 2024

Given that #197 is closed now, does that this mean issue is resolved?

from rspirv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.