Comments (2)
Hi, I had a brief look into this and wondered whether to fix it by adding signed/unsigned integer literals to the parser. Right now, the parser discards the sign of the tracked type when parsing literals:
https://github.com/gfx-rs/rspirv/blob/master/rspirv/binary/parser.rs#L312-L318
Generating signed integer literals at this point and correctly applying them throughout the code would fix this issue. The integer literals are already a specialization away from SPIRV's JSON grammar, so I don't think this change would break with spec. But introducing/changing literals might affect the parser's contracts to other code. If that direction sounds right, I can create a PR with my changes.
from rspirv.
I've added a PR which only touches the disassembler. Modifying the parser as proposed above will break client code, if it expects matches on LiteralIntXX
to mean all (= signed + unsigned) integer literals in the binary.
If breaking client code is okay for the convenience of no longer needing to track OpTypeInt
, then I can create a very drafty alternative PR. But reading through your other issues, it might make more sense to handle this in SR rather than DR.
from rspirv.
Related Issues (20)
- Floating-point literals should store bits in integers, not use host f32/f64. HOT 2
- New spirv_headers release HOT 1
- ImageFormat::Rgb10a2ui uses inconsistent casing. HOT 4
- Published 1.5.1 broke public API HOT 8
- Switch spirv_headers to SemVer HOT 5
- Rename "required_capabilities" for clarity
- `IdResult` and `IdResultType` on SR?
- Publish rspirv 0.8 ? HOT 1
- LiftContext::convert struggles with linked multi-stage SPIRV
- Unable to retrieve decorations in structured representation HOT 3
- Store all instructions in one `Vec`?
- LiftContext::lift_op responsible for ~25% of the generated llvm ir
- spirv: Vulkan SDK based versioning HOT 6
- LICENSE files in package subdirs HOT 3
- Update spirv's version of bitflags to 1.0.4
- Multiple operations with same opcode HOT 4
- Bug: selection_merge ends block.
- Release `spirv:0.3.0+sdk-1.3.243.0` not on crates.io HOT 17
- Removal of `FromPrimitive` in enums broke instruction parsing in spirq HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rspirv.