giistr / giistr Goto Github PK

What I did:

1. Visit https://giistr.com/
2. Enter my dev token into the input
3. https://giistr.com/home loads listing all my starred repos
4. Refreshing the page shows an xml file with the content

   <Error>
       <Code>AccessDenied</Code>
       <Message>Access Denied</Message>
       <RequestId>randomString</RequestId>
       <HostId>aBigRandomString</HostId>
   </Error>

But then loading the site with just https://giistr.com loads https://giistr.com/home with all my content perfectly.

Other info:
Browser: Firefox 66.0.2
OS: Ubuntu 18.04 LTS
Network: No Proxy or VPN

Edit:
Even the https://giistr.com/about behaves the same way. Pages can be viewed through links from the header of the page. But refreshing the page after they've loaded (except the main https://giistr.com) shows the above mentioned XML error.

From what I can see, Github user OAuth access tokens are stored in localStorage. Third party JS (e.g. from a node module or analytics scripts) will have access to the access code. Have you folks thought about storing the access tokens and making the requests to Github server side (as a just-in-case thing)? At the moment it's just public data users are giving access to, but it would protect you if you ever wanted to ask users for more permissions.

The codebase is really nice, by the way. I enjoyed reading through it!

Controlling which links open in a new tab or not using Ctrl+click doesn't seem to work: All issues always open in a new tab, but clicking the about link will always open in the same tab. Hovering over the 'links' also doesn't show the target URL.

Please make the links real links and allow Ctrl-click to work.

I just tried clicking "Signup with github" in the top right corner of the /about page and it doesn't seem to do anything.