Wrong name for toolbar tool about git-cola

[pkzc]

The "Stage All Untracked" action is only staging new (untracked) files, as originally intended. I just added a new "Stage Changed Files To Commit" action to handle staging just modified files. That new action should do what you're describing.

Just one more thing: I would suggest to call the new operation "Stage All Modified" instead of "Stage Changed Files To Commit" because

1. it follows the pattern of "Stage All Untracked" making it easier to comprehend,
2. in the GUI, the files affected by the operation are listed under the title "Modified" as shown in the attached picture.

[davvid]

Thanks for the heads-up! I'll get this patched shortly (before the next upcoming release).

[davvid]

Interestingly, I wasn't able to reproduce this behavior.

The "Stage All Untracked" action is only staging new (untracked) files, as originally intended. I just added a new "Stage Changed Files To Commit" action to handle staging just modified files. That new action should do what you're describing.

I'm kinda surprised that you're seeing different behavior. Here's where the two commands are registered. They're definitely hooked up to the correct commands at this level:

git-cola/cola/widgets/toolbarcmds.py

Lines 180 to 189 in a290ba5

	'Commit::StageModified': {
	'title': 'Stage Changed Files To Commit',
	'action': cmds.run(cmds.StageModified),
	'icon': 'add',
	},
	'Commit::StageUntracked': {
	'title': 'Stage All Untracked',
	'action': cmds.run(cmds.StageUntracked),
	'icon': 'add',
	},

Let me know if the latest version behaves differently. In theory it shouldn't, but we'll see. Thanks for the heads-up.

[pkzc]

You are right, it's a bit more complicated, after some experiments I can report this:

I have in the [gui] section of the git config file this:
displayuntracked = false
When I comment this out, then git-cola shows the untrackeds, and the "Stage All Untracked" stages exactly the untrackeds, the modified ones are left in place.

However, when I put back that line in the config, I get back the behavior that I originally reported.

[davvid]

Alrighty, that totally explained it. Thanks for the tip about gui.displayuntracked. That setting caused the tool to go into a fallback code path that stages all files (because the list of files to stage will always be empty), which is obviously something we don't want to do.

This has been corrected.