the commit button randomly becomes blank about git-cola

[sthalik]

Using the pre-commit hook doesn't reproduce the issue in 18f2591 that disabled the button, but I can confirm seeing the progress bar in the current version (which is 4fe1790).

[davvid]

We can reopen if you see this again. cheers

[davvid]

Thanks for the heads-up. We have a somewhat-new behavior where we replace the "Commit" button with a progress bar "button" that takes its place. It's supposed to reset itself back to a normal commit button as soon as the git commit action completes.

When this happens are you seeing the button disable itself completely and it never returns? Another thing we do (but this is long-standing) is that the "Commit" button disables itself when the "Subject" field has not yet been filled in. I can see in the screenshot that you do have something in that field, so it should be enabled.

My immediate thought is that we shouldn't hide the "Commit" button but rather display a temporary progress bar in the dock titlebar area instead.

[sthalik]

When this happens are you seeing the button disable itself completely and it never returns?

Yes.

My immediate thought is that we shouldn't hide the "Commit" button but rather display a temporary progress bar in the dock titlebar area instead.

Please note that I'm unable to reproduce the bug (it's only happened 2 to 3 times across a week or two).

[davvid]

I pushed in a change that makes it so that we stop hiding the Commit button. This should help in case there's some subtle behavior around hiding widgets that's causing it to lose its icon and text.

Let me know if you're able to reproduce this with the latest from git. Thanks for reporting this before I tagged the next release. I'll let this cook for a another week or so before I do that. cheers!

[davvid]

In case it helps reproduce this issue, you can use a git pre-commit hook to slow down git commit. Create an executable script at .git/hooks/pre-commit with this content:

#!/bin/sh
echo pre-commit hook
sleep 3

That'll make git commit take 3 seconds to run, which is long enough to get the progress bar to appear.