github / webpack-config-github Goto Github PK

github-graphql-relay-example could use this configuration.

I don't like how the current config needs to mutate the ENV vars in order have getGraphQLProjectConfig work as expected. It would be nice if you could pass something to getGraphQLProjectConfig as a fallback like getGraphQLProjectConfig('production'). Even better would be avoiding a hard coded naming requirement and selecting the first endpoint by default. Often there will only be one, no need for anyone to have to configure a name in that case.

How to create server.js for project like examples/relay? Any "webpack" solution not working.

config.devtool = 'source-map'

is crashing for some reason.

CC: @koddsson

The relay-compiler includes many hard coded console.log statements that look at out place in the webpack logging stream.

https://github.com/facebook/relay/blob/9b7c7d0fecdd831b6d67edd4346ccd028660613d/packages/relay-compiler/graphql-compiler/codegen/CodegenRunner.js#L230
https://github.com/facebook/relay/blob/9b7c7d0fecdd831b6d67edd4346ccd028660613d/packages/relay-compiler/graphql-compiler/codegen/CodegenRunner.js#L237
https://github.com/facebook/relay/blob/9b7c7d0fecdd831b6d67edd4346ccd028660613d/packages/relay-compiler/graphql-compiler/codegen/CodegenRunner.js#L315
https://github.com/facebook/relay/blob/9b7c7d0fecdd831b6d67edd4346ccd028660613d/packages/relay-compiler/codegen/RelayFileWriter.js#L261-L267

CC: @koddsson

Settings watchman to true will crash unless the user has watchman installed. Not a great experience as watchman is an external dependency. Users may not have it installed or environments like production or CI systems won't either. If its truly required, it would be nice if it was an npm dependency. Not sure what the best way to integrate this is.

CC: @koddsson

On a simple example, Runner.compileAll is called at least twice.

https://github.com/danielholmes/relay-compiler-webpack-plugin/blob/19959b855b34ec6f0a0d6db27a3ae597b3286a88/src/index.js#L97-L105

Actual logged output.

$ cd examples/relay
$ webpack
Parsed default in 0.00s

Writing default
Writer time: 0.03s [0.03s compiling, 0.00s generating, 0.00s extra]
Unchanged: 0 files
Written default in 0.03s
Parsed default in 0.00s

Writing default
Writer time: 0.00s [0.00s compiling, 0.00s generating, 0.00s extra]
Unchanged: 0 files
Written default in 0.00s

CC: @koddsson