githubtraining / continuous-delivery-aws

This repository is the source for the Learning Lab course, GitHub Actions: Continuous Delivery

Course: GitHub Actions: Continuous Delivery with AWS

This repository powers the Learning Lab course GitHub Actions: Continuous Delivery with AWS.

Every Learning Lab course is made up of:

• a course repository, and
• a template repository

The course repository is written in YAML and Markdown. The template repository could be written in any language that supports the learning objectives.

For more information on the goals of this course, check out the course-details.md.

Contribute

See something we could improve? Check out the contributing guide in the community contributors repository for more information on the types of contributions we ❤️ and instructions.

We ❤️ our community and take great care to ensure it is fun, safe and rewarding. Please review our Code of Conduct for community expectations and guidelines for reporting concerns.

License

All Learning Lab course repositories are licensed under CC-BY-4.0 (c) 2019 GitHub, Inc. The template repositories associated with each course may have different licenses.

When using the GitHub logos, be sure to follow the GitHub logo guidelines

continuous-delivery-aws's Issues

Issue with Node 8.x and failing builds

For the Course maintenance swarm event, I attempted to take this course to replicate two issues that had been reported. While taking the course, I found the following issue:

• There's an issue with Node CI, version 8.x. I ran into it on Step 4.

Remind learners to clean up resources at the end of the course

We cannot destroy AWS resources through GitHub Actions, but we should at least remind learners to destroy them manually.

Suggested by @haokanga in the community forum.

Possible dead link

A user mentioned me in their pull request to let me know that after step 9, "At this point in the course, deploy-prod.yml does not exist and the provided link is dead", referencing this link.

New course banner does not go away or update

description

I start testing this course and noticed right away that there is a new version right when I started. when clicking the Renew you registration button, it refreshes but does nothing to the original repo.

Curious if anyone else is seeing this.

steps to reproduce

1. Sign for the course from the https://lab.github.com/githubtraining/continuous-delivery-with-github-actions link.
2. Click the renew button
3. Note nothing changes and banner remains

Broken ‘Get help’ link on the sidebar

This link appears to be broken: https://github.community/t5/GitHub-Learning-Lab/bd-p/learn.

A response for step 6 is skipped

Current behavior

The main course page lists Approve pull request as Step 6 (highlighted in screenshot)

Whereas in the course content, Approve the pull request has been erroneously numbered as Step 7. Due to this, the numbering of the steps in the course content are ahead of the main course page by 1, starting with Step 7: Approve the pull request.

Solution

Change step numbers 7, 8, 9, 10, 11, 12 in the course content to step numbers 6, 7, 8, 9, 10, 11 respectively so that they match the main course page.

Clarify instructions before instructing the user to move to the next page

For the Course maintenance swarm event, I attempted to take this course to replicate two issues that had been reported. While taking the course, I found the following issue:

• Somewhere around Step 6, there was a box that said, "click here to go to your next step." But, there was more text below below this comment that was important. I saw "Click here" and my 👀 and head immediately stopped reading and I just clicked the link This sent me down a confused path for a good 10 minutes.
  I finally went back and read the page thoroughly and found the additional instructions and screenshot. My suggestion is to remove the first one-liner step that I clicked on since the next step has the same link.

Clarify instructions for AWS reason

For the Course maintenance swarm event, I attempted to take this course to replicate two issues that had been reported. While taking the course, I found the following issue:

• The instructions state to just type in a region but it is harder than that. You need to look up the region code on AWS for this to work. Also, it would be great if there were steps listed to help you troubleshoot when you add the "staging" label and you don't get the desired outcome. I got the region wrong. Tried to fix it, tried to re-run jobs...it was all still failing. I went and dug into the code and saw that the region change needed to be on main, so I tried to fix it there. Ended up confused and ran out of time so I wasn't able to complete the course.

BUG: Course blocked at step 6/7

A bug has been reported in Halp and in the Community forum, stating that the course is blocked after step 6/7.

Examples:

• Swaraj2904/github-actions-continuous-delivery#2
• bsa-coder/github-actions-continuous-delivery#2
• andpberr/github-actions-continuous-delivery#2

It appears the user approves the PR, the bot merges, but then the course freezes.

One user also reported a merge conflict in this PR, but that doesn't seem consistent across all bugs.

cc @ps-programs @mattdavis0351 👀

nodejs8.10 deprecated for AWS Lambda

Since Feb 3, nodejs8.10 has been deprecated for AWS Lambda.

On the initial Staging deployment, deploying to AWS failed for me:
CREATE_FAILED AWS::Lambda::Function MainFunction The runtime parameter of nodejs8.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs12.x) while creating or updating functions. (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidPar ameterValueException;

I changed the node version to nodejs12.x and staging workflow passed. However for the production flow nodejs12.x failed with:

Run docker://admiralawkbar/aws-nodejs:latest
...
...
Building resource 'MainFunction'
Error: 'nodejs12.x' runtime is not supported
ERROR! Failed to build SAM application!

Fix suggestion: Update node version to either nodejs10.x OR update both node version to nodejs12.x and deployment mechanism for production workflow to using github/deploy-nodejs@master

Clarification needed in step 1

Hello, I am running through this because this may be interesting content to share GitHub Universe next week in the Actions Hackspace.

My comments below are a direct correlation with this Workspace in mind.,

Is the content complete?

I ask because while evaluating it, I am finding the steps a bit confusing.

I am also presented with multiple branches when I start. I have not seen another lab course start like this.

Confusion

The instructions state I should edit the staging-workflow.yml file, but only the following files are include in the CHANGETHIS folder

• ci.yml
• approval-workflow.yml
• deploy-staging.yml

Changing the deploy-staging.yml works, but multiple files threw me off at the happy path.

Suggestion

1. I can open a PR to fix the content, but I might suggest also using quicklinks similar to how the hello world action lab works. That experience seemed really nice and I would love to see that same experience here.

2. I can open a separate PR for that to start the discussion. Curious if there was a reason that method wasn't used.

Course broken

We've taken this course down for the time being because of some issues that aren't allowing learners to complete it. The current state is that sam-template.yml, which gets introduced by the learner in one of the PRs uses

      Runtime: nodejs12.x

When the learner tries to deploy their app, they get the following error from the workflow:

Building resource 'MainFunction'
Error: 'nodejs12.x' runtime is not supported
ERROR! Failed to build SAM application!
ERROR:[
Build Failed]

We know this runtime was working before, so I consulted @mattdavis0351 and we think the issue has to do with the https://github.com/github/deploy-nodejs action.

Stuck at step 6

Hello, first of all I want to say that I’m loving these tutorials.

I’ve gotten stuck at step 6 twice now. After approving the PR, the bot merges, but no response after.