Comments (3)
This is actually caused by the "dynamic existence" of installer/preview:docker
. It only exists when the right arguments are passed at linking stage.
Options:
Make components:all
dynamic.
Doesn't require a leeway change, but significantly increases the complexity of our build set up because we have to duplicate conditions.
Add optional dependencies which are ignored if they're not present
For example (notice the ?) at the end:
deps:
- installer/preview:docker?
from leeway.
This is actually caused by the "dynamic existence" of installer/preview:docker. It only exists when the right arguments are passed at linking stage
In the dynamic component (here) I had ensured that I created a package with the same name in either case as an attempt to avoid this situation. So I thought that there might be a bug in Leeway where dynamic components weren't evaluated in all conditions. I tried to make a minimal example here but I haven't been able to reproduce the bug yet.
from leeway.
This is actually caused by the "dynamic existence" of installer/preview:docker. It only exists when the right arguments are passed at linking stage
In the dynamic component (here) I had ensured that I created a package with the same name in either case as an attempt to avoid this situation.
That's smart!
Actually in that case I'd prefer not to merge #103, just to not add this complexity needlessly.
So I thought that there might be a bug in Leeway where dynamic components weren't evaluated in all conditions. I tried to make a minimal example here but I haven't been able to reproduce the bug yet.
I just tried to reproduce using the steps described by Gero. I have not been able to reproduce this either.
Random thought: this might be some odd dependency on the order of a map. Just thinking that because that's the only thing introducing non-determinism in the linking process.
from leeway.
Related Issues (20)
- 'leeway build' fails to run `yarn` scripts HOT 4
- Output download log only when using --debug command
- Provide tab-completion for `leeway run`
- sha256Hash fails to hash symlink to directory HOT 1
- Document ephemeral packages HOT 1
- Retire ephemeral packages in favour of scripts
- Remove deprecated "typescript" package type
- Add vet warning when including `node_modules` in the source list
- Parallelize leeway vet
- Leeway vet doesn't return a non-zero exit code on failures
- Improve testability
- Decide on future of graphview
- golangci-lint is not part of the environment manifest
- Allow running multiple Leeway scripts in parallel HOT 3
- Packages build because they're deps of a script don't get uploaded to the remote cache
- Cannot parse Git status when files are renamed
- Extend `vet` so that it produces a warning if any .gitignore files are in the srcs input to a package.
- Implement leeway remote caching for S3
- Allow cross architecture docker builds with docker buildx HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leeway.