'leeway build' fails to run `yarn` scripts about leeway

[mads-hartmann]

I'll take a look - @andrew-farries I'll reach out it I need help reproducing this 🧡

[mads-hartmann]

@andrew-farries and I had a look - Leeway can't find mocha because it's not part of the package.json used by the Leeway package. The reason yarn test works if you invoke it directly from the folder is because mocha is present in the top-level node_modules so it's detected and used by yarn - in the Leeway build the top-level node_modules isn't available (as it should be).

The solution is to add mocha as a direct dependency to the package.

@andrew-farries I'm closing this, but I'm happy debugging further tomorrow if needed (we didn't get the tests running - when we added mocha to the package it tried to run the tests build failed for another reason, likely due to other missing dependencies or version-mismatch with the version of mocha we selected)

[csweichel]

The behaviour in the sample case works as designed.
Because there's an install entry in the commands section, leeway executes that command instead of yarn install. Subsequently the dev packages are not installed. Removing the install command fixes the build.

[andrew-farries]

Thanks. The example repo wasn't a good reproduction of the problem that exists in the Gitpod repo in that case.

In Gitpod's ws-manager-api/typescript component the BUILD.yaml doesn't override the install entry but leeway is unable to run yarn test when dontTest is set to false:

https://github.com/gitpod-io/gitpod/blob/4c3007af75cbf46dc965e172776995b6e9d8612c/components/ws-manager-api/typescript/BUILD.yaml

The error is the same (can't find mocha), but in that case it looks as though the dev packages should be installed correctly.