GithubHelp home page GithubHelp logo

githubandroidsdk's Issues

Payload relationship is undefined

GithubEvent objects all have a Payload field, but this is completely unrelated to all the *Payload beans that existed in the project before, and breaks usages where we previously casted the payload object to the appropriate type. What's their relationship, and how should these new Payload objects be used considering they don't share all the same fields as their previous Payload variants (such as ref_type, target, or gist).

Release and distribution

Alright now we can use the lib without compiling it locally. So do we want to use maven (jcenter) or should we implement JitPack. JitPack might be simpler for you but maven might be cleaner. It's up to you. The third option is to just release a .arr to the GitHub repo.

I know I'm a little bit stressed but I'd love to be able to use it at the GitHub app over at forkhubs :D

Add documentation

As this project is listed on the GitHub developers page, and being the only Android SDK / API for GitHub, could you provide documentation to show how this can be used.

Ideally something similar to the example on this project's README, but showcasing all of the features and how they can be used in Android.

Plugin is too old, please update to a more recent version

Plugin is too old, please update to a more recent version, or set ANDROID_DAILY_OVERRIDE environment variable to "693e8a773f76c66153c045392447148610fc80ef"

FAILURE: Build failed with an exception.

* Where:
Build file '/home/wsdjeg/forks/GithubAndroidSdk/build.gradle' line: 26

* What went wrong:
A problem occurred evaluating root project 'GithubAndroidSdk'.
> Failed to apply plugin [id 'com.android.library']
   > Could not create plugin of type 'LibraryPlugin'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 3.054 secs

ExecuteSync still planned?

Is this something we want to implement? It looks like we would have to add two Service methods for every api call.

Nothing wrong with it just asking cause it's only returning null for the moment

Update the readme

Just now I tried to use this library but gradle couldn't get it with 'compile 'com.github.alorma:github-sdk:2.1.0' but when changing to 'compile 'com.github.alorma:github-sdk:+' it works because the latest version is 2.1.2 .

CommitComment gets downcast to GithubComment when parceled

Say you have a CommitComment and want to pass it as a parcel object in a bundle. When parceled, the only parceling implementation is in the parent GithubComment, which parcels its subset of the data into a GitHubComment and only passes that. Result is a crash on the other side when you try to pull out a CommitComment and only get a GitHubComment

[TEST]

Test issue requested by owner

RequestTokenClient executeSync() always returns null

RequestTokenClient overrides the execute() method (I believe) in order to bypass the requirement to have a token prior to making the call. Thought the executeSync method does not reflect the same change and instead always returns null.

Implement Parcelable.Creator in GithubComment

Presently, GithubComment has a writeToParcel() implemented but no Parcelable.Creator. As a result, it ends up inheriting that from ShaUrl. So any GithubComment you put in the Parcel gets downcasted to ShaUrl resulting in a crash if you attempt to get a GithubComment from the Parcel.

Failed to resolve

Error:Failed to resolve: GithubAndroidSdk:GitskariosCore:unspecified

Any ideas? Only happens on 2.1.0

How to use this sdk?

I need to get github user details from my android application. is it possible to get user informations, if i use this sdk? . i could not get enough information from READ ME page. could anyone help me?

Observables shouldn't choose subscribeOn schedulers

All the observables currently automatically choose Schedulers.io(). This is bad IMO, as this prevents users from using their own scheduler for these. subcribeOn will basically only work once, so it can't be overloaded.

Example:

Schedulers.io() basically spins off a new thread every time there's a new task. Not everyone wants this, and it's not uncommon to use your own bounded IO scheduler when developing in a more limited environment (aka mobile apps)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.