Comments (14)
Talked this through with @SimonCropp during our gym session this morning:) and we haven't solved this yet.
The only thing that comes to mind is a tag on develop with a known name, "start-next-major" or similar?
I don't like a tag since that clutters the "releases" on github with useless cruft so if anyone has a better algorithm I'm all for it!!
Side note:
In theory it would work with just keep on working since when you create a release-{nextmajor}.0.0 branch it would be correctly versioned and when you merge to master develop would jump to {nextmajor}.1.0. This has the big caveat that during the release of {nextmajor}.0.0 the develop branch will still be stuck in a lower version , {currentmajor}.{currentminor+1}.0 which would be very confusing.
from gitversion.
The way GitHubFlowVersion does it is it looks for a file in the root of the repo called NextVersion.txt
, if that file exists, and the version is higher than the computed version then it takes precedence.
That way a pull request can bump the major/minor and when it gets merged the SemVer of the CI automatically bumps.
from gitversion.
That would work. That said I'd really would want to avoid adding uneeded
files to the repo is possible. How about some special keyword/syntax in the
commit message?
git commit -m "I had to change the api [BreakingChange]"
or
git commit -m "I had to change the api [BumpMajor]"
With the above we don't need a file and you can still bump from a pull by
marking it a breaking change?
Thoughts?
On Wed, Jan 8, 2014 at 10:47 PM, Jake Ginnivan [email protected]:
The way GitHubFlowVersion does it is it looks for a file in the root of
the repo called NextVersion.txt, if that file exists, and the version is
higher than the computed version then it takes precedence.That way a pull request can bump the major/minor and when it gets merged
the SemVer of the CI automatically bumps.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/66#issuecomment-31876238
.
from gitversion.
That would be better for a few reasons:
- No additional files
- If both [BreakingChange] and [MinorChange] are present or multiple [MinorChange]/[BreakingChange], we simply bump the major semver by 1. Means two people bumping major between releases will not be a problem
It could also tie into the release notes and be a keyword that it could pickup as additional metadata about the change?
from gitversion.
It could also tie into the release notes and be a keyword that it could pickup as additional metadata about the change?
Definitely, though arguable there should be an issue for that commit tagged with "breaking change" or similar?
from gitversion.
Now we just have to trick @nulltoken to wave his magical lib2git wand to make all this happen? :)
from gitversion.
True, may not know if it is breaking or just major until you get to implementing the issue.
I have code in GitReleaseNotes which scans commit messages for regexes already (it finds issue numbers then cross references against closed issues since last tag)
I'm happy to pick this up once #60 is pulled in, because this is required for the transition to GitVersion anyways :)
from gitversion.
Now we just have to trick @nulltoken to wave his magical lib2git wand to make all this happen? :)
@JakeGinnivan I was about to answer "Yes", but it looks like you've been faster than me 😉 Please, let me know if I can help you with anything
from gitversion.
@nulltoken review #60 :) need feedback as it changes a bunch of stuff around GitFlowVersion's SemVer classes
from gitversion.
The GitHubFlow side supports NextVersion.txt
, if everyone is happy with that approach, we can make it available for both GitFlow and GitHubFlow then close off this issue?
from gitversion.
Not a big fan of adding text files but I'd say this is definitely one of the valid strategies for NextVersion we should support!
from gitversion.
We need to add documentation for NextVersion.txt, then close this issue.
We could also open another issue to add support for bumping via commit messages?
Breaking: I broke stuff
bumps major
Feature: New thing
bumps minor?
from gitversion.
+1 one on a new issue just to track it at least
On Sun, Mar 30, 2014 at 8:01 PM, Jake Ginnivan [email protected]:
We need to add documentation for NextVersion.txt, then close this issue.
We could also open another issue to add support for bumping via commit
messages?Breaking: I broke stuff bumps major
Feature: New thing bumps minor?
Reply to this email directly or view it on GitHubhttps://github.com//issues/66#issuecomment-39033450
.
from gitversion.
#137 is tracking
from gitversion.
Related Issues (20)
- [Improvement]: Rename TrunkBased Version Strategy to Mainline HOT 1
- [Improvement]: Create TaggedSemanticVersionService class HOT 1
- [ISSUE]: gitversion/execute@1 task uses branch from wrong repository
- [Improvement]: Finalizing the configuration of GitFlow and GitHubFlow workflow and align with the Mainline version strategy HOT 1
- [ISSUE]: n unexpected error occurred: LibGit2Sharp.LibGit2SharpException: No error message has been provided by the native library HOT 2
- [BUG]: GitVersion (in Azure Devops) calculating wrong version when building a tag HOT 9
- Verifies the contents of `configuration.md` against the default serialized configuration
- [ISSUE]: Regex Capture Groups don't work correctly on release branch. HOT 3
- gitversion from container image default behaviour differs from other installation methods HOT 5
- [Documentation]: Documenting the GitFlow workflow and create sequence diagrams HOT 1
- [ISSUE]: Gitversion failing in teamcity run configuration HOT 1
- [ISSUE]: Can't make GitVersion work in conjunction with WiX Toolset 4.0/5.0 HOT 3
- Forced push breaks GitVersion
- [ISSUE]: GitVersion AzDo task appears to be stuck at version 5.0.1 HOT 1
- [ISSUE]: Plan Migration to .NET 7.0+ SDK HOT 1
- [ISSUE]: NotImplementedException in TrunkBased-Workflow HOT 1
- [Feature]: Support of multi mainline branches in the Mainline version strategy
- [ISSUE]: Unable to get Main branch to update WeightedPreReleaseNumber HOT 1
- [ISSUE]: `init` command still shown in the help output HOT 2
- [Documentation]: Documenting the GitHubFlow workflow and create sequence HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitversion.