Problem using nuget pack -includedependencies with assemblies using GFV about gitversion

[andreasohlund]

Since we use ripple we lean on the update dependencies feature of create-packages

http://darthfubumvc.github.io/ripple/commands/createpackages/

It works brilliantly for us

[thirkcircus]

ah, right.
started a spike ealier this week for ripple-ising our main solution here, another good reason to use it... 😉
thanks, makes sense.

[JakeGinnivan]

From the looks of it, this issue can be closed.

Reopen or post a comment if this is not the case

[pms1969]

Just for future reference, if you add an AssemblyInformationalVersion to your projects AssemblyInfo.cs, your package versions should be correct when doing nuget pack. (just had this exact same problem and eventually found the AssemblyInformationalVersion)

[MarkZuber]

This problem still exists. AssemblyInformationalVersion needs to be set to NuGetVersion (e.g. 1.2.3-unstable0004) instead of the longer version with the SHA in it. Otherwise, NuGet doesn't set the dependency properly in the creation (as described in the original post).

Really need to be able to specify/override what goes into AssemblyInformationalVersion so that we can make this work.

[MarkZuber]

From nuget docs (https://docs.nuget.org/create/versioning)

If building a package from a project (.csproj or .vbproj), use the AssemblyInformationalVersionAttribute to specify the version.

[assembly: AssemblyInformationalVersion("1.0.1-alpha")]

NuGet will pick up this value instead of the one specified in the AssemblyVersion attribute (this attribute does not support SemVer which is why a different attribute was needed).

[JakeGinnivan]

Makes sense, thanks for clarifying.

[MarkZuber]

Happy to guinea pig a fix to this. I've been digging through the code, but not sure the best way to wire this in. Maybe something in the yaml config? or a command line parameter?

[JakeGinnivan]

Seeing as it is solution specific I think the yml file is a better idea. Not sure the best approach. Maybe some sort of string interpolation which you can use variables gitversion generates. I thought we had something in there but don't have time to look into it right now

[MarkZuber]

I was thinking something similar to how it's wired up for the assembly version property where you can specify in the yml: Major, MajorMinor, MajorMinorPatch, etc. Have a similar config property for assemblyfileversioninfo-format whre you can say "gitversion" or "fullinfoversion" or something like that...

[MarkZuber]

I just sent a Pull Request for this to GitTools/Master with some additional unit tests. would be interested for you to take a look at the approach when you get time.

#658

thanks!
mark

[JakeGinnivan]

This is fixed by #660 right?

Am closing this, if thats not the case then let me know @MarkZuber

[MarkZuber]

Yes. It's fixed by that cl. Thanks!

Sent from the internets.

On Jan 19, 2016, at 1:46 AM, Jake Ginnivan [email protected] wrote:

This is fixed by #660 right?

Am closing this, if thats not the case then let me know @MarkZuber

—
Reply to this email directly or view it on GitHub.