GithubHelp home page GithubHelp logo

drupal-starter's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

drupal-starter's Issues

`sudo` errors on Gitpod

Selection_999(450)

Not sure if it has any meaning in our case? (Site is still installed properly in the end of the process)

Use dedicated tasks in Robofile

Currently the Robofile isn't using all the capabilities of Robo. That is, there could be nicer use of existing tasks instead of $this->_exec('some bash commands'). We still enjoy writing those scripts in PHP rather than bash, but it could be improved.

Migrate Users and Article [5h]

Let's have it similar to our other client projects, so upon ddev restart we'd get some users and content.
Would be nice for the Articles to have tags and an image

Basic mail testing

DDEV provides Mailhog, which features a JSON API. So it's quite easy to invoke those HTTP endpoints from PHPUnit tests and assert mail sending. This would treat Mailhog as a high level mock.

Improve release notes [4h]

Desired format

Release 1.11

  • Issue one (#11111)
    • Pull request one (#22222)
    • Pull request two (#444444)
  • Issue Two (#999999)
    • Pull request (#1234567)

Contributors:

  • User1
  • User2
  • User3

(authors of the issues and the pull requests enumerated above)

Technical notes

It will mean that the release notes script will require a personal access token to GitHub to gather all this information. I can save it locally to avoid to enter it again and again

Add Redis

We should rely on Redis caching out of the box. For small projects, it makes no harm, for large projects, it helps a lot.

Add Hero and Card Paragraphs [6h]

Following a discussion with @amitaibu we'll be adding some paragraphs to basic pages.

Tasks

  • Add paragraphs module (also update to use PEVB with Paragraphs integration)
  • Add Hero paragraph
  • Add Card and Cards paragraphs
  • Add/Update frontend components as needed
  • Add Pluggable entity view builders for the paragraphs to use the frontend components
  • Add paragraphs field to Basic Page with options to add Hero and Cards paragraphs (Card is only addable through Cards paragraph)
  • Add some migrated basic page content with paragraphs

Theme is very slow to compile

First up, thank you for sharing the development of this project, it's brilliant.

On a fresh gizra/drupal-starter DDEV installation, the ddev robo theme:compile-debug command takes about 30 seconds to complete. This feels very slow when working on frontend tasks.

The same happens when using the ddev robo theme:watch-debug command, which basically invokes the theme:compile-debug on every change.

The Just-In-Time Mode from Tailwind, however, advertises lightning fast build times... even the biggest projects in about 800ms, so I was wondering what could be done to speed it up (or whether it's ultra fast for everyone else and this is just an issue with my setup, I use a Macbook).

For starters, we could shave off about 5 seconds by removing the drush cache:rebuild, since Twig and Drupal caching are often disabled anyway during development.

image

Check PHP syntax of custom code

PHPCS doesn't check php syntax, missing test coverage will not detect this either.

There is an interesting project called https://github.com/VKCOM/noverify that I've been trying to check syntax errors locally. Let's see if this can be automated.

A fatal error waiting to be discovered by someone:

Screenshot-2020-07-16-17-06-23

Put the theme on drupal.org

It might be interesting, as Tailwind is relatively new, it might be a publicly available base tailwind theme.

Migrations dependencies are not respected

Dependencies defined in .yml files like this:

dependencies:
  enforced:
    module:
      - server_migrate
    migration:
      - user
      - tags
      - media_image

Does not seems respected. The right syntax seems to be:

migration_dependencies:
  required:
      - user
      - tags
      - media_image
  optional: []

Create ddev commands for theme compiling and watching

Issue

In current setup we have 2 commands for theme - ddev tw(theme watching) and ddev robo theme:compile(theme compiling), I suggest to make 2 ddev commands which will have similar namings - ddev theme:watch and ddev theme:compile

Set homepage after migration

Issue

Upon clean installation we set the homepage to be /homepage on /admin/config/system/site-information . But if we check \Drupal::service('path.matcher')->isFrontPage(); it will return False. If we then manually change the URL and then back to /homepage and click save, then under the hood it changes it to the internal path (e.g. /node/21).

Selection_999(1065)

Task

  1. Confirm my findings
  2. Instead of setting it via config, after the migration is executed, we can set it.

Provide server_theme's themes from server_general so it

Just thought of this as it's been in the back of my mind for a bit.

If we try to render entities in Views module's Preview window just as one example, the entities don't render because the server-theme-card.html.twig template cannot be found (for example) when using Claro/Seven.

This can be resolved if we just server_theme_theme (server theme's hook_theme) to server_general_theme and copy all the server-theme-* templates to be in the module's templates folder. This way in server_theme we're overriding templates provided by a module, and since they're provided from a module they should work in any theme such as Seven.

Automatic deployment - never go back in time [3h]

Right now it's possible that automatic deployment reverts already deployed changes.
Deployment jobs might be created like this:
Job A
Job B

But executed in this order:
Job B
Job A

Then changes from Job B are reverted essentially.
To prevent that, we could store the timestamp of the Git commit in the artifact repository to ensure that we never deploy outdated code.

Organize style-guide [4h]

  • Divide into wrapped/ non-wrapped area
  • Add JS to collapse all elements on load
  • Click on title or some Expand/ collpase all buttons
  • Or if in the url we'd have the Id of the element (e.g. /style-guide#element-to-open)

Add common paragraph types [8h]

We seem to rebuild those types almost every site, which could be good examples:

  • Hero image
  • Related content carousel. Let's use our slick, but convert the use of classes (e.g. carousel-wrapper) to attributes (<div data-carousel-wrapper ...>). So it's easier to spot those settings.

@andreytroeglazov for whenever you have some spare time ๐Ÿ˜„

Kernel Tests are not working

There was 1 error:

1) Drupal\Tests\server_general\Kernel\ServerGeneralTest::testDummy
PHPUnit\Framework\Exception: PHP Fatal error:  Uncaught PHPUnit\Framework\Exception: Could not read "phpunit.xml.dist".

Add XML sitemap

  • Install and enable XML sitemap
  • Add Menu links from Main menu - And perhaps Articles node type too? @amitaibu how should we configure it?

Should we install pathauto + redirect too @amitaibu ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.