gkware-e-k-streamguru / tftp Goto Github PK

In TFTPServer/main.cpp, there are several places where CloseHandle() is called, and then ReleaseClient() may be called, which may also do an additional CloseHandle() is the handle is not of value INVALID_HANDLE_VALUE. This may cause a kernel exception on windows/msc builds.

in static void ReleaseClient(CLIENT *pClient) in TFTPServer/main.cpp,

the line:
memset(pClient,0x00,sizeof(pClient));
should be:
memset(pClient, 0x00, sizeof(CLIENT));
so the entire structure memory gets zeroed, not just a pointer-size's worth.

This might also be an issue in other places where memset() is used.

In findClient() in TFTPServer/main.cpp
the session time out determination is suspect.
I think it should be more like:

	DWORD dwExpiration = g_Clients[i].dwLastSignOfLife + TFTP_SESSION_TIMEOUT;
	if (    g_Clients[i].eOpcode 
		 && (g_Clients[i].dwLastSignOfLife < dwNow)

// && (g_Clients[i].dwLastSignOfLife < dwExpiration) //error?
&& (dwNow >= dwExpiration) //better, since 'now' has hit the expiration time?
)
{