globalfishingwatch / frontend Goto Github PK

Hi there,

I've noticed some changes in the data download in the past 3-4 weeks. No geometry datasets are available for download even for registered users.
In registered log in mode, I'm trying and failing to:

1. Download ship tracks for specific ship (worked last time for download on 22nd Jan) -> no download button available.
2. Download EEZ limits.

Download works for gridded data.

I guess this might be one of the culprits?
[https://github.com/GlobalFishingWatch/frontend/commit/54bf793a16e50de94fa207fbbd41234bb1da3a0d] #1234

Can you please check?
It has been reported by multiple users.

Hi there
I am unable to use https://globalfishingwatch.org/data-download/ and the server returns a 500 error instead of listing the datasets

Could this be resolved ?

Why non-hyperlinked "10 more"?

Coming from map-components/issues/64 this issue resume the main points of that conversation and opens the conversation in this repo.

Brainstorm 23/01/2020:

• Tests all existing generators - mapbox gl style check for each of them as a minimum

• Playground to test layers, we could even include a layer template for each type

• Generators need documentation

  • Typescript already provides the first level of documentation
  • Describe better methods using https://github.com/Microsoft/tsdoc

• Error handling: generators should throw when bad inputs are given

• We need a core generator class that generators extend:

  • Manage standard style behaviours : visibility, interactive, selected/highlighted states with default and overrides system
  • Common utilities set: color handling/conversion
  • Handle overrides done by dataviews-client
  • Pass global parameters : start/end. others?

• InteractionManager as done in the Books project:

  • Based on LayerManager input parameters
  • Responsible for generation of interactiveLayerIds
  • Handles feature interaction priority
  • Prepares popup data in a standard way
  • Overwrites style generated by LM depending on selectedFeatures and highlightedFeatures for each layer?
  • Manages map cursor states?
  • Handles cluster interactivity? (ie zoom to zoom level X when feature is clustered, do whatever when feature is not clustered)
  • selectedFeatures: support multiple features and expressions (might be overkill for now)

• LegendManager / Legend component

  • Reads standardised legend data generated by LayerManager in map style

• Attributions / AttributionManager

map-styler

• compose (params -> GL style)
• sort (GL style -> GL style)
• getFeatures (GL style -> GL style with selected features, selected features info, interactiveLayerIds)
• getAttributions (GL style -> attributions)
• getLegends (GL style -> legends)