Comments (5)
NB -- this will also apply to RegionScatterLayers (once they are implemented). We can fix both at once.
from glue.
I would guess that changing the offending line to polar = getattr(layer._viewer_state, 'using_polar', False)
should be enough to fix this, but I admittedly haven't tried it.
from glue.
That would deal with this particular error, but there are other calls to layer._viewer_state
in this to fix.
from glue.
Ah yeah, looks like there are similar calls for other scatter viewer state properties (full sphere, degrees)
from glue.
I don't know when exactly this broke, but this is clearly something that I didn't check on when I added the support for the full-sphere and angle unit functionality. I can confirm that doing e.g.
polar = getattr(layer._viewer_state, 'using_polar', False)
full_sphere = getattr(layer._viewer_state, 'using_full_sphere', False)
degrees = getattr(layer._viewer_state, 'using_degrees', False)
will make things work for a scatter layer in an image viewer.
I'm not sure what adding support for region layers would entail - if the behavior for those is significantly different we could use a dispatch function for the layer export. Not ideal, but we do need some kind of check on the viewer state so we can properly handle any pretransforms that the exporting viewer is using.
from glue.
Related Issues (20)
- Include fast-histogram in dependencies
- Not starting from command prompt HOT 10
- Document and improve load_plugins
- can't open ipython terminal HOT 4
- how to install Plugins in glue.exe HOT 1
- data calculate in IPYTHON HOT 1
- Dropdown entry for "Actual Size" in plot layer options HOT 1
- Tables with skycoords HOT 3
- X and Y problems with ScatterRegions
- TST + BUG: dev testing is not picking up numpy-dev HOT 1
- TST: Python 3.12
- DOC: Broken link, where did it go?
- DOC: Conda installation HOT 2
- In some images, full-size masked subset can cause IndexError
- glue 1.19.0 broke jdaviz (cubeviz) HOT 3
- TypeError: setValue expects int, gets float during splash screen progress update HOT 1
- Calling load_plugins multiple times results in duplicate entries HOT 1
- pip installation instructions do not include gui
- Data Load Error Trying to Open FITS Table
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glue.