gmiclotte / melvor-scripts Goto Github PK

TheAlpacalypse:
"Have you considered bundling eta/combat sim as packages? I'm wondering how best to bundle those into SEMI on a longer term basis"

https://docs.npmjs.com/creating-node-js-modules

Since last night I can not use Melvor ETA anymore, it brings the tab to 100% CPU and makes clicking anything impossible, even killing the tab through Chromes task manager takes a while, while I'm used to it beeing instant.

I can successfully select the character, then the page gets redrawn, and the "confirm AFK" dialog appears. This is when everything hangs. I am not able to confirm that dialog, nor clicking outside of it, only killing the tab helps.

I am also using the "Melvor Idle Combat Simulator Reloaded" to get the menu entry for configuration, not the tool itself. It doesn't make any difference whether this tool is activated or not, but I already realized if it is activated, its menu item is not available.

Yesterday I started firemaking, and the tooltip showed me, that I reach level 99 about two hours after getting up. I should have some spare logs left after that

When I started I had 8k to 10k yew logs IIRC.

Today I get up, and look at the progress and I see that not only I will not reach level 99 with my yews at all but require ~500 more of them, but also that burning all the logs I have now will take an additional ~90 minutes.

Despite the fact that I gained some mastery levels which should have sped up my burning rates. Sadly I do not remember yesterday evenings level anymore…

I turned the unlimited mod on but I still got the text: 18 hours is the maximum offline progression.

Is this than a bug?

• 3 10 Ent Crow +20% Runecrafting Preservation Chance when creating Staves. {summoningSynergy_3_10: 20}
• 4 9 Mole Pig +25% base burn chance in Cooking. Grants 100 Coal Ore when burning Food. {summoningSynergy_4_9: 25}
• 4 18 Mole Bear While the Perfect Swing Potion is active in Mining, all Mining Nodes have +20 Max HP. {summoningSynergy_4_18: 20}
• 5 11 Octopus Leprechaun -50% Thieving Skill Interval for Fisherman only. Also grants +2 Base Thieving Item Qty from Fisherman only. {summoningSynergy_5_11: 1}
• 5 17 Octopus Salamander While creating Dragon Gear in Smithing, grants +5% Smithing Preservation chance. {summoningSynergy_5_17: 5}
• 5 19 Octopus Devil +5% Cooking Mastery XP. -10% Cooking Skill XP. {decreasedSkillXP: Array(1), increasedMasteryXP: Array(1)}
• 9 10 Pig Crow +5% chance to preserve resources in Cooking, and when creating Runes in Runecrafting. {increasedSkillPreservationChance: Array(1), summoningSynergy_9_10: 5}
• 9 16 Pig Monkey Crafting Recipes that require Dragonhide now use -1 quantity to create. Recipe cost cannot go below 1. {summoningSynergy_9_16: 1}
• 9 17 Pig Salamander -0.1s Skill Interval for Cooking & Smithing. {summoningSynergy_9_17: 100}
• 9 19 Pig Devil +8% Firemaking & Cooking Mastery XP. -10% Firemaking & Cooking Preservation Chance. {increasedMasteryXP: Array(2), decreasedSkillPreservationChance: Array(2)}
• 10 17 Crow Salamander +10% Smithing & Runecrafting Preservation Chance. {increasedSkillPreservationChance: Array(2), summoningSynergy_10_17: 10}
• 10 19 Crow Devil Grants +10 Fire Runes while creating Elemental Runes. -5% Runecrafting Skill XP. {summoningSynergy_10_19: 10, decreasedSkillXP: Array(1)}
• 16 17 Monkey Salamander +33% chance to preserve resources in Crafting when creating Rings or Amulets only. {summoningSynergy_16_17: 33}
• 17 19 Salamander Devil -3 Coal required for Smithing Item production. {summoningSynergy_17_19: 3}
• 18 19 Bear Devil While using the Controlled Heat Potions, +5% Firemaking Skill XP and Bonfire duration is doubled. Charges are used per Firemaking action. {summoningSynergy_18_19: 1}

irrelevant:

• 3 4 Ent Mole +2% chance per action in Woodcutting to gain a random Gem. {summoningSynergy_3_4: 2}
• 3 5 Ent Octopus +3% Increased Special Item chance in Fishing. +3% Increased chance to obtain a Bird Nests in Woodcutting. {summoningSynergy_3_5: 3}
• 3 9 Ent Pig +1% chance to receive +1 Cooked Food in Cooking. Cannot be doubled. {summoningSynergy_3_9: 1}
• 3 11 Ent Leprechaun When successfully pickpocketing the Lumberjack in Thieving, grants +1 Bird Nest instead of GP. {summoningSynergy_3_11: 1}
• 3 16 Ent Monkey In Woodcutting, +1% chance for a random Silver or Gold Jewelry to drop instead of a Bird Nest. {summoningSynergy_3_16: 1}
• 3 17 Ent Salamander +5% chance to gain +1 Base Logs from Woodcutting, or produced Items from Smithing. {summoningSynergy_3_17: 5}
• 3 18 Ent Bear While the Bird Nest Potion is active in Woodcutting, grants +1 minimum Bird Nest. {summoningSynergy_3_18: 1}
• 3 19 Ent Devil 15% of Woodcutting Skill XP is earned as Firemaking Skill XP. Chance to double Logs is halved. {summoningSynergy_3_19: 15}
• 4 5 Mole Octopus When receiving a Gem from Mining or Fishing, there is a +15% chance to get another random Gem. {summoningSynergy_4_5: 15}
• 4 10 Mole Crow Base quantity for Rune Essence in Mining is doubled. {summoningSynergy_4_10: 1}
• 4 11 Mole Leprechaun When successfully pickpocketing the Miner in Thieving, +10% chance to get a random Gem. {summoningSynergy_4_11: 10}
• 4 16 Mole Monkey Base quantity for Silver Ore & Gold Ore is doubled in Mining. {summoningSynergy_4_16: 1}
• 4 17 Mole Salamander +15% chance to receive a smithed verion of the Ore you are Mining. {summoningSynergy_4_17: 15}
• 4 19 Mole Devil +10% chance to recieve a Diamond per action in Firemaking. {summoningSynergy_4_19: 10}
• 5 9 Octopus Pig +75% chance to recieve an extra Fish as a Cooked version while Fishing. {summoningSynergy_5_9: 75}
• 5 10 Octopus Crow In Runecrafting, when creating a Combination Rune that requires Water Runes as an ingredient, produce +5 extra Combination Runes. {summoningSynergy_5_10: 5}
• 5 16 Octopus Monkey 33% chance to gain a random Gem while creating Jewelry in Crafting. {summoningSynergy_5_16: 33}
• 5 18 Octopus Bear +200% charges when using the Fishermans Potion. Bonus is applied when new Potion is activated. Charges are used each Fishing action. {summoningSynergy_5_18: 200}
• 9 11 Pig Leprechaun The Chef in Thieving now deals no damage to you. {summoningSynergy_9_11: 1}
• 9 18 Pig Bear Generous Cook Potions now provide +200% charges. This bonus is applied when a new potion is activated. {summoningSynergy_9_18: 200}
• 10 11 Crow Leprechaun Successfully pickpocketting the Miner in Thieving will now grant +1 Rune Essence. {summoningSynergy_10_11: 1}
• 10 16 Crow Monkey +10% chance to double when creating Leather, Hard Leather or Dragonhide Armour in Crafting. {summoningSynergy_10_16: 10}
• 10 18 Crow Bear While the Elemental Potion is active in Runecrafting, grants a chance to get random Combination Runes. The chance and quantity is equal to that of the Elemental Potion. {summoningSynergy_10_18: 1}
• 11 16 Leprechaun Monkey Upon receiving an item in Thieving, grants GP equal to 2000% of its sale price. {summoningSynergy_11_16: 20}
• 11 17 Leprechaun Salamander Upon successfully pickpocketting an item from the Miner in Thieving, 50% chance to receive a random Bar. {summoningSynergy_11_17: 50}
• 11 18 Leprechaun Bear +3% chance to obtain a single Herb Sack while Thieving the Farmer, on top of the original item obtained. {summoningSynergy_11_18: 3}
• 11 19 Leprechaun Devil While Thieving any NPC, 50% chance to grant +100% GP, 35% chance to grant 4x Items, or 15% chance to receive no items or GP at all. {summoningSynergy_11_19: 1}
• 16 18 Monkey Bear Crafting Potions now last twice as long. Bonus is applied when a new potion is activated. Charges are used per Crafting action. {summoningSynergy_16_18: 1}
• 16 19 Monkey Devil Burning Logs in Firemaking grants GP equal to 400% of its base sale price. {summoningSynergy_16_19: 300}
• 17 18 Salamander Bear While using the Seeing Gold Potion in Smithing, double Silver & Gold Bar output. {summoningSynergy_17_18: 1}

With 0.9.0 I have the issue that there is basically no usable displayed data for firemaking.

Its stats do not change as I change different logs, and it always shows, that I had no ressources.

With 0.8.8 the info got at least updated properly after the first log got burned, though this isn't happening anymore with 0.9.0

out of curiosity, how hard would it be to make your scripts use @include? They are incompatible with FireMonkey because it wants scripts to use either @include and @exclude OR @match and @exclude-match, and AFAICT TamperMonkey doesn't support @exclude-match. (It also needs @inject-into page but that's trivial)
I can easily change it myself and so could anyone else, of course (just two lines), so it's not a actual problem :)

small/quick redraw/flash of the interface numbers when pot ends and then there is still the disappearing when spending pool xp

ETA does not take this into account yet

I'd like to request a setting to specify the max amount of time you'd like to calculate for offline progress.

Could help with phone users, for example, that can't calculate offline progress after a certain amount of days without crashing the app. Also for people that simply just want to limit it for various play reasons.

For example, input 72 hours; any offline progress beyond this does not get calculated (similar to vanilla ignoring anything beyond 24 hours).

Consumption of potions and tablets is not simulated (unlike charge stones), but we could give an estimate of the amount required to reach the 4 types of targets.

Clicking Yellow Party Hat gives you more Yellow Party Hats.

It uses combat magic bonus xp instead

In getXpRates, the code initializes rates to an empty hash {} but then tries to += an undefined property on it. This results in it being NaN.

you might want to consider adding a check to ETA to prevent loading twice, since this has been a common issue ever since Time Remaining was added to SEMI (Maybe even show a warning telling them to disable the one in SEMI)

• Visua

On my system, fishing with the Pirate's List Ring equipped caused the tab to freeze and stop responding when ETA is loaded.

The changelog for Melvor v0.19.1 mentioned a fix to this ring:

[FIXED] Pirate's Lost Ring providing an inconsistent Skill XP bonus.

It looks like https://github.com/gmiclotte/melvor-scripts/blob/master/ETA/ETA.js#L1117 is looking for a fishingBonusXP attribute.
xpMultiplier += items[CONSTANTS.item.Pirates_Lost_Ring].fishingBonusXP / 100;
From what I can see, this isn't present any more and was replaced with modifiers, although I can't tell the syntax used in the new array well enough to propose a fix.
xpMultiplier += items[CONSTANTS.item.Pirates_Lost_Ring].modifiers.increasedSkillXP[0][1] / 100;
would probably work, but doesn't scale to other items without knowing the schema used in the modifiers array. I don't see anything linking the 15 value to fishing XP for example.

modifiers:
  increasedSkillXP: Array(1)
    0: Array(2)
      0: undefined
      1: 15

The full item taken from my console in Chrome:

items[667]

attackBonus: (3) [0, 0, 0]
canEquip: true
category: "Fishing"
damageReduction: 0
defenceBonus: 0
description: "+15% Fishing XP when equipped."
equipmentSlot: 7
fishingCatchWeight: 10
hasStats: true
id: 667
magicAttackBonus: 0
magicDamageBonus: 0
magicDefenceBonus: 0
media: "assets/media/bank/pirates_lost_ring.svg"
modifiers:
  increasedSkillXP: Array(1)
    0: Array(2)
      0: undefined
      1: 15
      length: 2
      __proto__: Array(0)
    length: 1
    __proto__: Array(0)
  __proto__: Object
name: "Pirates Lost Ring"
rangedAttackBonus: 0
rangedDefenceBonus: 0
rangedStrengthBonus: 0
sellsFor: 17500
strengthBonus: 0
type: "Special"
__proto__: Object

• flat min/max hit (in|de)creases
• flat HP (in|de)creases
• flat HP regen (in|de)creases
• maybe others ?

suggestion for the obstacle filter script: have it track the items we need to build the desired obstacle course, factoring in mastery, agility cape, etc
sucks having to keep track of all the raw materials i need to collect every time I change configurations

• Saint1090