gmosx / dart-inflection Goto Github PK

Great tool!
Not sure if this is the type of issue to report here, but some pluralizations aren't correct. For example:

• deer to deers
• bison to bisons
• aircraft to aircrafts
• goose to gooses

I tested the method with several of irregular-pluralizing nouns from this website.

Could we add a CHANGELOG.md ?

Four comments for the library-level variables like PLURAL.

1. use a type annotation:

final Converter<String, String> Plural = new PluralEncoder._()

2. use camel case instead of all caps for the name

3. use a library-private constructor.

4. consider a const constructor, which is really nice for this case

Optional:

5. Consider making these classes callable, so you can do:

Pluralize('input') as an alternative to Pluralize.convert('input')

To do so, add a String call(String input) method to your converters.

Cheers!

First off, super cool! Thanks for contributing this library.

I wasn't sure what the inflector was. If you have time, more examples in the README would help explain what this is.

Also, while you're in there, maybe include a note on how to file issues.

Cheers!

Have you thought about hooking this up to a CI system (drone / travis)? It makes it pretty easy to get tests running on each PR.