gmurphey / ember-cli-addon-audit Goto Github PK

Should probably be sorted by name by default, but could be nice to sort by score.

Would be nice to exclude things that come with the default blueprint like ember-cli-babel.

Need to think about what the ranges should be.

For example:

ember-cli-addon-audit --threshold=5

Would only report addons that scored 5 and below.

Goes without saying...

Hi! I like the idea of this addon, thank you for creating it. I do have a couple of concerns I think we should collaborate on:

• The API being used is not public. I have yet to feel comfortable supporting an API for Ember Observer as public with the limited time and resources I have for it. Some thing that could get around this would be using the badge images, which have predictable names, but I am not sure that images can be displayed on the cli.

• The current design can leak the names of private addons into Ember Observer's logs. They'll 404 on the API but the requests made will be in the logs and possibly aggregated into our error tracking service. It could also leak the set of addons used in an app. I think this could be mitigated with a warning.