GithubHelp home page GithubHelp logo

carpet-autocraftingtable's Introduction

carpet-autoCraftingTable

autoCraftingTable extension for carpet-mod. Implementation based on Skyrising's implementation for autoCraftingTable for QuickCarpet - implemented here as an extension for fabric-carpet mod.

When enabled, all crafting tables will contain block entites making them immovable. This means that items will also be stored inside the crafting table.

carpet-autocraftingtable's People

Contributors

crec0 avatar evermoreobsolete avatar fxmorin avatar gnembon avatar nikitacartes avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

carpet-autocraftingtable's Issues

Issues with crafting book

When a player interacts with a crafting table and uses the crafting book to craft an item, if you are just left clicking on the sprite for the item, the items in the table will remain at 1 for each slot needed for crafting.

What happens if the mod is installed and removed later on?

What if I play for a while with the mod, place some crafting tables and later on decide I don't want the addon anymore. What does happen to my crafting tables in-game? Do they convert back to normal ones? Or is the world unusable?

Hopper sorter causes item to craft even though it doesn't pull the item

Here's the setup: a hopper pointing into the auto crafting table and a hopper underneath the crafting table. The hopper underneath has all its slots filled with 1 gold block so it cannot accept anything but a gold block. The hopper on the side is filled with 9 gold ingots. When the ingots start flowing into the table, the first ingot is immediately crafted into 9 gold nuggets, even though the hopper underneath hasn't actually pulled it. (Nothing has removed the 9 nuggets from the output slot, therefore the ingot should not have been crafted.) This means that the 9 nuggets stay in the output slot of the crafting table, and nothing else can be crafted until these nuggets are manually removed.

This means that it is impossible to use hopper sorters with recipes whose top left slot is an item with a solo crafting recipe. This affects a lot of recipes: iron blocks, gold blocks, lapis blocks, melon blocks, chests, signs, bookshelves, note blocks, golden apples, anvils, barrels, blast furnaces, beehives, and cauldrons.

This also causes a minor visual glitch where if you are looking at the crafting table's gui while the item is crafted, the item disappears as you would expect it to if a hopper did pull it, but when you click the output or close and reopen the gui the item is there.

craftingtableglitch

Block entities don't render in 1.19.3 when autocraftingtable extension is added

With a Fabric 1.19.3 (0.75.1+1.19.3) and Carpet (1.19.3-1.4.93+v221230) server, no other server mods, no other client mods, banners and player heads render as their defaults (magenta banner, white banner, Steve, etc.) unless I break the block & re-place it. If I do break and re-place it, it resets back to default when the server resets. The same issue occurred on all 1.19.3 versions of Fabric & Carpet I tried, but autocrafting has only been 1.19.3-1.4.91 (Not sure if there are other versions I can try).

(Feature request) movable table + inv shifting

My reccomend would be that (if possible) the crafting table is movable With piston while also shifting inventories without needing to enable mbe bc that kinda Breaks too much stuff.

So basically the Feature would be MBE Just for crafting table (by default With the table Extension)

Incompatible with clients without the mod and with Fabric API on 1.20+ or exactly 0.79.0

carpet:autocraftingtable is being regsynced, so the client will complain it doesn't know about it.

Idk if you need Fabric API on the server (any version).

I think this is also currently an issue if there's other mods that affect the registry but not autocraftingtable, given it seems to have been a bug in Fabric API that is being fixed on 1.20 (kept in 1.19.4 for backwards compat with mods working because of the bug).

Item duplication with latest fabric API

Looks like the latest fabric API (0.38.0) causes the crafting table not to remove recipe items, thus making it such that the resultant item can be taken infinitely.

Backdating to 0.37.2 removed this issue.

1.17.1 Error executing task on client

MC: 1.17.1

This error happens on the client when opening a crafting table when autocrafting is enabled.

java.lang.IndexOutOfBoundsException: Index 46 out of bounds for length 46
	at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]
	at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]
	at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266) ~[?:?]
	at java.util.Objects.checkIndex(Objects.java:359) ~[?:?]
	at java.util.ArrayList.get(ArrayList.java:427) ~[?:?]
	at net.minecraft.class_2371.get(class_2371.java:47) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_1703.method_7611(class_1703.java:275) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_1703.method_7610(class_1703.java:583) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_634.method_11153(class_634.java:1034) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_2649.method_11439(class_2649.java:44) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_2649.method_11054(class_2649.java:11) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:21) ~[intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:151) [intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) [intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:125) [intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_1255.method_5383(class_1255.java:110) [intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1075) [intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:728) [intermediary-minecraft-1.17.1-client.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:217) [intermediary-minecraft-1.17.1-client.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?]
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:234) [fabric-loader-0.11.6.jar:?]
	at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:153) [fabric-loader-0.11.6.jar:?]
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:28) [fabric-loader-0.11.6.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]```

"Careful Restoration" advancement does not trigger

The title says it all. I was trying to get the Careful Restoration advancement on a server with autoCraftingTable enabled, and somehow it wouldn't trigger. After disabling this mod it did work though.

Update to 1.16.4

I want to use this feature for survival 1.16.4 but currently if I use the 1.16.3 version it's just disabling the crafting table, please update.

movability side effects

Issue:
Just having the carpet-autoCraftingTable extension+carpet installed affects the following
(which it should not):

  • the fletching table & smithing table become immovable
    (possibly more, these are the ones I have tested)
  • the crafting table becomes immovable even though the autoCrafting carpet rule is false

Tested in two fresh instances:

  • 1.18 (fabric loader 0.12.8)
    with only carpet mod 1.4.56 & carpet-autocraftingtable 1.4.56
  • 1.17 (fabric loader 0.12.8)
    with only carpet mod 1.4.56 & carpet-autocraftingtable 1.4.43

Easy dupe with crafting table in unloaded chunk

Reproduction steps:

  1. Place items in crafting table
  2. Get into minecart and start leaving
  3. Open crafting table while you'rัƒ close to it (First screenshot)
  4. Drive long distance (~500 blocks on server with view-distance=16) and pick up items from crafting table (Second screenshot)
  5. Go back to crafting table and find two copies of the items: in inventory and crafting table (Third screenshot)

image
image
image

Item Pulling Order

I found an issue when crafting honey blocks and how they could be left on the table but there seems to be wider issue so I have closed the honey block specific issue and opened this ticket for the general case. (Honey block issue #12 )

If a crafted item can't be pulled because the hopper below it is filled with other items, then the input items are consumed but the output item is stuck on the table. This can lead to the output item being 'deleted' if items for another recipe are added.

It is not made explicit in the documentation, but I am assuming that the intention of this mod is that items are crafted when they are pulled by the bottom hopper and that any other behaviour is not intended as it leads to ambiguity.

My take on this is a check is needed to ensure there is space in the bottom hopper for the output item prior to the item being crafted.

no opening gui

When I use the 1.16.3 version to 1.16.4 it's just disabled my crafting table

Fix Fletching table

For some reasons with autocrafting table make fletching table a TE and it can't be moved

Missing Reference Map in 20w06a version

placing the mod jar in mods folder yields

Feb 09 00:03:03 ArchAngel bash[551537]: [00:03:03] [main/INFO]: Loading for game Minecraft 20w06a
Feb 09 00:03:03 ArchAngel bash[551537]: [00:03:03] [main/INFO]: [FabricLoader] Loading 5 mods: [email protected], [email protected], [email protected], [email protected]+build.184, [email protected]
Feb 09 00:03:03 ArchAngel bash[551537]: [00:03:03] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8 Source=file:/srv/fabric-minecraft/fabric-server-launch.jar Service=Knot/Fabric Env=SERVER
Feb 09 00:03:03 ArchAngel bash[551537]: [00:03:03] [main/WARN]: Reference map 'carpet-autocraftingtable-refmap.json' for modid.mixins.json could not be read. If this is a development environment you can ignore this message
Feb 09 00:03:04 ArchAngel bash[551537]: [00:03:04] [main/FATAL]: Mixin apply failed modid.mixins.json:CraftingTableBlockMixin -> net.minecraft.class_2304: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on onActivateActionResult could not find any targets matching 'onUse' in net.minecraft.class_2304. No refMap loaded. [PREINJECT Applicator Phase -> modid.mixins.json:CraftingTableBlockMixin -> Prepare Injections ->  -> handler$zfp000$onActivateActionResult(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]
Feb 09 00:03:04 ArchAngel bash[551537]: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on onActivateActionResult could not find any targets matching 'onUse' in net.minecraft.class_2304. No refMap loaded. [PREINJECT Applicator Phase -> modid.mixins.json:CraftingTableBlockMixin -> Prepare Injections ->  -> handler$zfp000$onActivateActionResult(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]

on server launch

Item duplication with Fabric API 0.40.1

Hello.

After enabling /carpet autoCraftingTable true, I put on the crafting table and it won't dissapear after the craft. Example: I put an iron ingot, it produces 9 iron nuggets but then, it won't stop making nuggets from that iron ingot.

I'm using the following version so you can reproduce the bug:

carpet-autocraftingtable-1.17.1-1.4.43.jar
fabric-api-0.40.1+1.17.jar
fabric-carpet-1.17.1-1.4.46+v210918.jar

Thanks

Unable to start server with autocraftingtable

Following error occurs when starting a Minecraft server enabled with Fabric.
Mods installed:

  • Carpet-Autocraftingtable-1.19.1-1.4.83.jar
  • fabric-api-0.68.1+1.19.3.jar
  • fabric-carpet-1.19.3-1.4.91+v221027.jar
[11:10:10] [main/ERROR]: Failed to start the minecraft server
java.lang.RuntimeException: Mixin transformation of net.minecraft.class_2966 failed
        at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427) ~[fabric-loader-0.14.11.jar:?]
        at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) ~[fabric-loader-0.14.11.jar:?]
        at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.11.jar:?]
        at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145) ~[fabric-loader-0.14.11.jar:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
        at net.minecraft.server.Main.main(Main.java:99) ~[server-intermediary.jar:?]
        at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.11.jar:?]
        at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.11.jar:?]
        at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) ~[fabric-loader-0.14.11.jar:?]
        at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) ~[fabric-loader-0.14.11.jar:?]
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
        at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ~[fabric-loader-0.14.11.jar:?]
        ... 9 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Callback method registerTableBeforeRegistryFreeze(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V in carpet-autocraftingtable.mixins.json:BootStrapMixin from mod carpet-autocraftingtable failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap carpet-autocraftingtable-refmap.json
        at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
        at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ~[fabric-loader-0.14.11.jar:?]

Release for 1.17 crashes in MC 1.17.1

The mod crashes the server as soon as you put an item in the crafting table.

---- Minecraft Crash Report ----
// Oh - I know what I did wrong!

Time: 7/7/21, 8:09 PM
Description: Exception in server tick loop

java.lang.NoSuchMethodError: 'void net.minecraft.class_2653.<init>(int, int, net.minecraft.class_1799)'
        at carpet_autocraftingtable.AutoCraftingTableContainer.method_7609(AutoCraftingTableContainer.java:46)
        at carpet_autocraftingtable.CraftingTableBlockEntity.method_5431(CraftingTableBlockEntity.java:160)
        at net.minecraft.class_1735.method_7668(class_1735.java:66)
        at net.minecraft.class_1735.method_7673(class_1735.java:62)
        at net.minecraft.class_1735.method_32755(class_1735.java:146)
        at net.minecraft.class_1703.method_30010(class_1703.java:405)
        at net.minecraft.class_1703.method_7593(class_1703.java:284)
        at net.minecraft.class_3244.method_12076(class_3244.java:1390)
        at net.minecraft.class_2813.method_12191(class_2813.java:55)
        at net.minecraft.class_2813.method_11054(class_2813.java:11)
        at net.minecraft.class_2600.method_11072(class_2600.java:21)
        at net.minecraft.class_3738.run(class_3738.java:18)
        at net.minecraft.class_1255.method_18859(class_1255.java:151)
        at net.minecraft.class_4093.method_18859(class_4093.java:23)
        at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:788)
        at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:164)
        at net.minecraft.class_1255.method_16075(class_1255.java:125)
        at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:770)
        at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:764)
        at net.minecraft.class_1255.method_5383(class_1255.java:110)
        at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:748)
        at net.minecraft.server.MinecraftServer.handler$zgc000$modifiedRunLoop(MinecraftServer.java:2899)
        at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:676)
        at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:270)
        at java.base/java.lang.Thread.run(Unknown Source)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- System Details --
Details:
        Minecraft Version: 1.17.1
        Minecraft Version ID: 1.17.1
        Operating System: Linux (amd64) version 5.8.0-59-generic
        Java Version: 16.0.1, AdoptOpenJDK
        Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), AdoptOpenJDK
        Memory: 3127515648 bytes (2982 MiB) / 6442450944 bytes (6144 MiB) up to 6442450944 bytes (6144 MiB)
        CPUs: 8
        Processor Vendor: GenuineIntel
        Processor Name: Intel Core Processor (Skylake, IBRS)
        Identifier: Intel64 Family 6 Model 94 Stepping 3
        Microarchitecture: Skylake (Client)
        Frequency (GHz): -0.00
        Number of physical packages: 8
        Number of physical CPUs: 8
        Number of logical CPUs: 8
        Graphics card #0 name: unknown
        Graphics card #0 vendor: unknown
        Graphics card #0 VRAM (MB): 0.00
        Graphics card #0 deviceId: unknown
        Graphics card #0 versionInfo: unknown
        Virtual memory max (MB): 9980.18
        Virtual memory used (MB): 5811.99
        Swap memory total (MB): 4022.00
        Swap memory used (MB): 0.00
        JVM Flags: 2 total; -Xms6G -Xmx6G
        Player Count: 1 / 20; [class_3222['Phil535'/110, l='ServerLevel[world]', x=234.04, y=64.00, z=727.22]]
        Data Packs: vanilla, file/afk display v1.1.0.zip, file/track raw statistics v1.4.0.zip
        Is Modded: Definitely; Server brand changed to 'fabric'
        Type: Dedicated Server (map_server.txt)

Recipes don't update with an item filter beneath the crafting table 1.4.56

When making an item filter beneath the autocrafting table, it will only accept the first recipe put into the table. From what it appear, it seems as if the first recipe is actually crafted and stored in the output slot, not allowing any other recipes to be crafted.
2022-01-16_19 34 48

This is not the case for a locked hopper under the crafting table. It works perfectly fine with that.

Potential issues with upgrading worlds to 1.18

After a long time spent troubleshooting, I believe that Carpet AutoCraftingTable may cause chunk corruption when upgrading a 1.17.1 world to 1.18. The issue seems to specifically be related to tile entities, in corrupted chunks, tile entities will become invisible and containers will lose their items.

Steps to recreate bug:

  1. Download world
  2. Optimize in vanilla 1.17.1
  3. Optimize on vanilla 1.18
  4. Open world
  5. Go to 51 ~ 311

Seemed to fix the issue:

  1. Download world
  2. Optimize in vanilla 1.17.1
  3. Go to 51 ~ 311
  4. Optimize in vanilla 1.18
  5. Open world
  6. Tile entities in that chunk shouldn't be corrupted

Sorry for not giving a more descriptive issue, but I don't understand the bug enough to give more info.

Potential related / caused by MC-244164.

Items Pulled in Wrong Order When Crafting Honey Blocks

When crafting honey blocks the glass bottles that are left on the table can be the first items to be taken off.

If a honey block is setup and hopper placed under the crafting table then everything functions as expected and the honey block appears first followed by the glass bottles. However if all the bottom hopper's slots contain glass bottles then the glass bottles are pulled from the table first and the honey block is left on the table. The honey block can then be pulled if a slot in the bottom hopper is cleared.

It is not made explicit in the documentation, but I am assuming that the intention of this mod is that items are crafted when they are pulled by the bottom hopper and that any other behaviour is not intended as it leads to ambiguity. Honey blocks are, I believe, unique in that they leave behind items on the crafting grid and I'd expect this to be an edge case.

Is honeyblock crafting broken?

carpet 1.4.100+v230314 & autocraftingtable 1.4.57 on 1.19.4 shows this
image
But loses the recipe when I add another item:
image

Checked in single player

Item duplication glitch

When the GUI of the crafting table is open and the player is teleported away so that the table itself is unloaded, the GUI remains open. It's possible to remove items from the GUI and the same items will stay in the crafting table once the player returns and loads the chunks again.

[Suggestion] Accept Input from Recipe Selection Only

Selecting a recipe from the recipe book should have that recipe stay displayed on the crafting table, preventing hoppers or dispensers from adding items that are not in the selected recipe.

This way there's no need for overly complicated redstone to craft something, if the recipe has all the necessary items, it will craft that 1 item.

Upload to CurseForge/Modrinth

Right now this isn't uploaded to either platform, so, it has to be downloaded from GitHub manually. Would be nice to see it released there as well.

1.4.56

Does the 1.4.56 version work with 1.17.1?

Auto Crafting Table doesn't unlock recipes when an item is crafted

In vanilla (and if autoCraftingTable rule is set to false), if you craft an unknown recipe, it becomes unlocked (by "unlocked" I mean "added to character's list of known recipes").
It's useful for datapacks; they rely on that to implement custom recipes with NBT in an output item.

With autoCraftingTable rule enabled, however, recipes don't unlock, and thus "recipe_unlocked" trigger never fires, and datapacks using it break.

Tested in 1.15.0

doesn't work in 21w15a Snapshot

I get the generic
ERROR
Game crashed
An unexpected issue occurred and the game has crashed. We're sorry for the inconvenience.
Exit code: 0

Update to 1.18.2

Could you update this extension to 1.18.2? Would be much appreciated.

Server with carpet-autoCraftingTable kicks users after joining

An error is left to the player:
Registry remapping failed: Received ID map for minecraft:block_entity_type contains IDs unknown to the receiver!
- carpet:crafting_table
This always happens, independent of the autoCraftingTable rule.
The server console is as follows (from a Multicraft server):
30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.newIOException(Errors.java:122) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.ioResult(Errors.java:146) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.FileDescriptor.writevAddresses(FileDescriptor.java:155) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.writeBytesMultiple(AbstractEpollStreamChannel.java:316) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWriteMultiple(AbstractEpollStreamChannel.java:523) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWrite(AbstractEpollStreamChannel.java:434) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:934) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:529) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:398) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:308) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at java.lang.Thread.run(Thread.java:748) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.newIOException(Errors.java:122) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.ioResult(Errors.java:146) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.FileDescriptor.writevAddresses(FileDescriptor.java:155) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.writeBytesMultiple(AbstractEpollStreamChannel.java:316) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWriteMultiple(AbstractEpollStreamChannel.java:523) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWrite(AbstractEpollStreamChannel.java:434) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:934) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:529) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:398) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:308) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at java.lang.Thread.run(Thread.java:748) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.newIOException(Errors.java:122) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.ioResult(Errors.java:146) 30.01 19:21:42 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.FileDescriptor.writevAddresses(FileDescriptor.java:155) 30.01 19:21:43 [Multicraft] Skipped 26620 lines due to rate limit (30/s) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at java.lang.Thread.run(Thread.java:748) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.newIOException(Errors.java:122) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.ioResult(Errors.java:146) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.FileDescriptor.writevAddresses(FileDescriptor.java:155) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.writeBytesMultiple(AbstractEpollStreamChannel.java:316) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWriteMultiple(AbstractEpollStreamChannel.java:523) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWrite(AbstractEpollStreamChannel.java:434) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:934) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:529) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:398) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:308) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at java.lang.Thread.run(Thread.java:748) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.newIOException(Errors.java:122) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.ioResult(Errors.java:146) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.FileDescriptor.writevAddresses(FileDescriptor.java:155) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.writeBytesMultiple(AbstractEpollStreamChannel.java:316) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWriteMultiple(AbstractEpollStreamChannel.java:523) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollStreamChannel.doWrite(AbstractEpollStreamChannel.java:434) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:934) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:529) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:398) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:308) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at java.lang.Thread.run(Thread.java:748) 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer 30.01 19:21:43 [Server] Netty Epoll Server IO #15/INFO [STDERR]: at io.netty.channel.unix.Errors.newIOException(Errors.java:122)
The server runs the following mods:

  • SimpleHarvest 1.0.4
  • Carpet autoCraftingtable 1.3.0
  • Carpet Extra 1.3.5
  • Everything is a hat 1.0.4
  • Fabric API 0.4.29 Build 290
  • Fabric Carpet 1.3.6
  • G4mespeed 1.0.4
  • hopperOptimizations 0.1.11
  • Phosphor 0.3.6

Event order direction/location/machine specific?

When multiple hoppers feed a crafting table that has an unlocked hopper beneath it, the end result is inconsistent. Sometimes it appears the update order for that tick is:

1 side hopper pushes -> Table crafts -> bottom hopper pulls -> Other side hopper pushes -> Table crafts -> bottom hopper pulls

Other times it is:

1 side hopper pushes -> Other side hopper pushes -> Table crafts -> bottom hopper pulls

An example is shown below. If 1 stone block is released from the side hoppers at the same time, sometimes 2 stone buttons are created, and other times a single stone pressure plate is created, depending on location, etc (or something).

image

Unmovable fletching table

For 1.19.2 the crafting feature makes fletching table unmovable. Currently this would break the raid farm we are using.

Is this by design or a bug?

Can't push crafting table

To make a automated farm you have to push a crafting table with a piston but the mod has disabled this. Is this a bug or is this intentionally?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.