GithubHelp home page GithubHelp logo

prop-types warning about react-tunnel HOT 5 OPEN

gnoff avatar gnoff commented on April 20, 2024 1
prop-types warning

from react-tunnel.

Comments (5)

natew avatar natew commented on April 20, 2024

Would you release a fix if I submit a PR?

from react-tunnel.

alanshaw avatar alanshaw commented on April 20, 2024

this now errors Cannot read property 'object' of undefined

any chance you can publish a new version with the fix?

from react-tunnel.

agrcrobles avatar agrcrobles commented on April 20, 2024

Hey there, I found this library fits is super well with my needs!

I had done some minors tweaks mostly on the tests and published react-tunnel-16 and made it work finely with CRA still need to figure how to make it work with react-native + react 16.

I will send a PR once I have the tests passing.

from react-tunnel.

gnoff avatar gnoff commented on April 20, 2024

@agrcrobles I'll look for the PR

Please note however that this lib is subject to the same limitations of context that say react-router is where a connected component can easily block updates. Have you looked at https://github.com/ReactTraining/react-broadcast instead? it implements a subscription model to avoid this and I would probably use this lib for my own future needs for this reason alone.

If you aren't using shouldComponentUpdate then react-tunnel should still work well but that's a fairly large limitation.

from react-tunnel.

agrcrobles avatar agrcrobles commented on April 20, 2024

Thanks for the advice @gnoff!
I will probably end up using react-broadcast as you are suggesting, but since a new version of react-context is comming up most likely all libraries will need an upgrade.

I will send a PR with my current stuffs as of now, as I made it work with CRA and react version 16.2.

from react-tunnel.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.