gnoff / react-tunnel Goto Github PK

remove configuration props {forwardProvided, allowOverload}
Stop auto-providing arbitrary props on Provider

add new Provider prop: provide: (parentProvided) => provided | plainObject

if provide is a function it receives the the provided in context (only makes sense if this Provider is nested) and returns an object to be provided. It would be up to the caller to forward some/all/no parent provided values.

if the Provider is top level then parentProvided will be undefined

if provide is an object then that object will be provided in this provider. This means that to forward props from parent providers you must do so explicitly

Questions

1. should provided forwarding happen by default?

My injected component was not rerendering. I believe based on cursory review that inject should be using shallowEqualScalar on both provided and props (instead of shallow equal on just provided)

Get this when using react-tunnel:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

from:

function createProvider(React) {
  var Component = React.Component;
  var PropTypes = React.PropTypes;