gnosly / fluent-sequence Goto Github PK

.gitignore includes .idea folder, but idea/vcs.xml was (accidentally?) added in c9197db.

Overriding toString, hasCode, and equals methods kinda looks like reimplementing case classes.

The current value of mutable.TreeMap[String, Fixed2dPoint] is not really used by itself, instead it's always converted into a Map[String, Fixed2dPoint].

I suggest to return map.toMap to make it immutable.

EventBook looks like a Builder to me: elements get appended to an accumulator field which value is treated as immutable when returned to anyone else outside the class scope.

I suggest to turn events into a private field and to provide a getter method that returns an immutable List.

I'll provide a PR soon.

Most of the settings found in publish.sbt could be omitted because of default values and of build.sbt settings which the plugin reads metadata from. File could be reduced to the following:

import xerial.sbt.Sonatype._

publishTo := sonatypePublishTo.value

sonatypeProjectHosting := Some(GitHubHosting(
  user = "gnosly",
  repository = name.value,
  fullName = "Fabrizio Giovannetti",
  email = "[email protected]"
))

licenses := Seq("Apache 2" -> url("http://www.apache.org/licenses/LICENSE-2.0.txt"))