GithubHelp home page GithubHelp logo

go-epub's People

Contributors

1l0 avatar amandacameron avatar bhasfe avatar bmaupin avatar chengshusss avatar fmartingr avatar gonejack avatar hmelder avatar lucasew avatar missdeer avatar monirzadeh avatar moyamejiasr avatar nitxy avatar owulveryck avatar pgundlach avatar propan avatar stuartmscott avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

go-epub's Issues

automatic file naming should clean filenames properly

When calling epub.EmbedImages() the added images are automatically named from the library. The problem is that the images are not cleaned when they come from URLs.

For example, a image of name: image.jpg?width=300 will try to create the same filename in the system, and some do not support symbols like that.

An example of this can be seen at: https://github.com/go-shiori/shiori/actions/runs/7819243851/job/21331283455?pr=837#step:5:369

The offending line: https://github.com/go-shiori/go-epub/blob/main/epub.go#L629-L630

Another possibility is to always create random filenames when calling EmbedImages(), since it's automatic nobody should care.

`AddCSS` not refer new css inside document

currently AddCSS just add file and that to manifest but not add that on document too, maybe it is not bad if we have option for that.
this make files not pass epubcheck

AddImage with same custom filename from diffrent source not add to epub

What is the problem?

if user try to add different or one file with same filename go-epub not add the second one.

	e.AddImage("path/to/file1.jpg", "filename.jpg")
	e.AddImage(t"path/to/file2.jpg", "filename.jpg")

What do you expected?

add second file with a new name and show a warning to the user

Can't append subsection to a subsection

Processing of chapters into subchapters does not work correctly in the AddSubSection function, I get an error like ParentDoesNotExistError, I cannot correctly process more complex nesting.

feature: allow localizing strings

It would be nice if it was possible for user of the API to provide translations for English strings that are currently hardcoded. There is at least Table of contents. Maybe more.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.