goatcorp / dalamud Goto Github PK

I'm having a small issue where the game momentarily loses focuses whenever a duty pops if I have the in-game features turned on. I don't have anything fancy turned on, no discord channel notifications or anything like that, but when it pops and it goes to tell me what the duty is in the in-game chat window, I notice it loses focus for just a brief second before immediately giving it back. This is a pretty obvious hitch since I play the game in fullscreen so everything freezes for a second. It didn't used to do this some number of versions ago. The issue does not happen if I play with in-game features disabled.

I've never had an issue with it dropping focus and then never giving it back, but it's a mild inconvenience every time I queue for a duty so I've been resorting to turning off in-game features to avoid this since I don't really need to know in the in-game chat what duty I just queued for now that roulette duties are no longer readable. This does however make other in-game features unavailable to me.

I'm liable to hit the autoformat button on any file I come across. Can the .editorconfig file be updated with the style options generated by the "Generate .editorconfig file from settings" button in VS?

Related to #19

Sample items with wrong results include "Revolver" and "Deathbringer" (and I believe most job gear that has a normal variant plus something like an antiquated variant etc).

We should eventually switch to the elastic search version as mentioned in #19 , but a more immediate fix for this might be to add a parameter to the command, or an additional command, or check if the item name is a quoted string... just some way to flag that the user wants an 'exact' query. If it is, we can append to the existing xivapi query "&string_algo=match", which will then return the correct result at the expense of the user having to type the full item name.

Note the algo change won't address the problem(s) in #19 so we'll still need to switch to elastic search at some point to handle everything.

I think the size of currentWorld and homeWorld should be ushort instead of byte at Actor.cs#L71.
You can see World.csv for ref.

Good Morning!, I just found out about the xivlauncher and I was trying it out. Everything installed just fine and when I tried to use it, it gave me this error :

"Failed to inject the XIVLauncher in-game addon. Please try restarting your game and your PC. If this keeps happening, please report this error."

I restarted the game, and PC, and it did not fix it. I tried to run as administrator as well, did not fix. I googled the issue but I did not find anything really about it, maybe I didn't word it correctly. I found an old post about a Discord issue, but that seems to of been fixed back in Dec. 2019. I have discord installed but it is not running at all. I am currently on Windows 10 also. If you need other information I will be happy to try and get it for you.

Thank you

Dalamud uses some wrong naming for classes related to game UI because I didn't know any better. Would be nice to fix those.

We can use this issue to collect them.

From looking through the code, it seems like 'all' might be the intended way to cancel these, but that isn't very intuitive and should be clarified in the help text somewhere if so.

It also looks like the effectively-hidden 'none' option would work but the code makes that seem less intentional.

Either way, the messaging should probably be clarified a bit.

Describe the bug here:
Game crashes when I typed /xlplugins.
It opens the window briefly and the FF14 crashes 4 seconds later.

Steps to reproduce the bug:
typing /xlplugins.
Plugins still work outside of typing to get plugin list. I tested everything that i have installed.

Expected behavior
typing /xlplugins should populate a list of plugins and their config.

Other information (please complete the following information):
Operating System: Windows 10 latest update
XIVLauncher version: 5.1.1.0
Launching as admin?: no
Using Steam?: no
Addons/Plugins enabled:
mouseover, soundsetter, xivcombo, and marketplace.

Gshade also installed. But i've tested with and without and still get the crashes. I've also tested in a base game install with no addons, plugins etc, just fresh install and I do not get crashes. Something with XIV Launcher is crashing the game.

They're excluded by ImGui's input filter in a hardcoded manner.

When eventually making our own builds of ImGui, we should address this.

https://github.com/goatcorp/Dalamud/blob/master/Dalamud/Game/Chat/SeStringHandling/Payloads/ItemPayload.cs

Collectible item ids need to be shifted -500000 before querying Lumina, otherwise the Item property will be null.

TBD

This should not be a thing

Bring back my Meli, please

Description

You can move your mouse cursor in FFXIV with your controller in virtual mouse mode. I would like Dalamud to be able to send mouse presses to the ImGui interaction layer using that virtual mouse.

More info

Despite being a "virtual" mouse mode, FFXIV actually moves your physical mouse cursor (if the cursor was in FFXIV's window to begin with). Since turning all of ImGui controller friendly feels very infeasible to me, just being able to interact with ImGui via the virtual mouse mode would already improve the usability for couch potatoes and other controller-only players. For instance, FFXIV on Linux currently suffers from having to decide between Mouse OR Gamepad, because enabling Gamepad locks up FFXIV if you do movement with your hardware mouse.

Fulfilling this feature request would entail:

• Noticing that FFXIV is in Virtual Mouse Mode
• Knowing when a "virtual" mouse is hovering over ImGui elements (already done by virtue that the actual cursor is moved, not just a fake one)
• Disabling clicking on the actual in-game UI when hovered over an ImGui element
• Simulating a mouse-click for the hovered ImGui element

• I checked if this request wasn't already proposed
• I consider this request not to be out of scope for Dalamud

game crashes on startup. ive dived through the logs and found that the game exits directly after [INF] Started dalamud!. so i dug around and found the dalamud log files and discovered the following error:

[ERR] Could not get SwapChain address via sig method, falling back to vtable...
System.Collections.Generic.KeyNotFoundException: Can't find a signature of 48 8B C4 55 41 54 41 55 41 56 41 57 48 8D 68 ?? 48 81 EC C0 00 00 00
   at Dalamud.Game.SigScanner.Scan(IntPtr baseAddress, Int32 size, String signature)
   at Dalamud.Game.SigScanner.ScanModule(String signature)
   at Dalamud.Game.Internal.DXGI.SwapChainSigResolver.Setup64Bit(SigScanner sig)
   at Dalamud.Game.Internal.BaseAddressResolver.Setup(SigScanner scanner)
   at Dalamud.Interface.InterfaceManager..ctor(Dalamud dalamud, SigScanner scanner)

this error was caused by simply logging in. the game window opens up, gets to the "Square Enix" logo, then immediately crashes.

Operating System: Win10x64 v1909
XIVLauncher version: xivlauncher-4.7.3.0-a55b6fb
Launching as admin?: no, doing so gives different errors. if you want those, ill make a new report
Using Steam?: no
Addons/Plugins enabled: Rich Presence

• Implement Lumina DI to resolve payloads that depend on game data

TextPayload:

• Handle special unicode characters

ItemPayload:

• Switch resolve to Lumina once ready, should not be using XIVAPI anymore

Good afternoon.

Since the last update, every time the duty window comes up (commence, wait, etc), my FFXIV becomes 'unfocused' (aka if you alt tabbed, getting the momentary black screen) and then 'refocused' (switches back to the game, prompting another brief black screen).

This used to never happen before with the launcher. It would just pop, I'd get a notification in the chat, and we're in business. Also, related or unrelated, I cannot get my duty windows to show what duty is it anymore for combat queues; I only get notifications of what instance I am entering from non-combat duties (i.e. Gold Saucer, Ocean Fishing).

I have 2 monitors. One is an old 60Hz, the other is newer, 144 but @120hz. I run the game at uncapped FPS with an Nvidia driver cap of 120FPS to match Hz:fps and not strain my GPU. I currently run in Full Screen.

Before ShB, I used to alt tab between monitors easily; I'd get a brief 2 second black screen on the FF monitor. Since ShB, somehow it takes longer, like 6 seconds; I blame the weird changes to the internal FPS cap that they were messing with. Now, again, ever since this launcher update, whenever the duty window appears, it seems like your launcher executable is trying to 'focus' itself briefly.

Please let me know what else I can do to provide more help/information.

[FieldOffset(2)] public short DarksideTimeRemaining

I believe this should be an ushort as it ranges from 0 to 60000 milliseconds.

I think it would be worthwhile to have these, as the protocol is a bit weird and it's easy to mess things up when refactoring/changing/implementing new payloads.

Not needed for our use case

Per https://discordapp.com/channels/581875019861328007/684745859497590843/753028227932356618, I'll probably do this tomorrow

I thought everyone was experiencing this, but I haven't seen any issue created about it in the last few weeks, so...

Describe the bug here:
When in-game features are enabled, XIV launcher forces FFXIV to the front when a duty is found. This even includes forcing it OUT of focus then back INTO focus, which is utterly bizarre and quite disruptive.

Additionally, if remained out of focus, it will continue to blink into and out of focus indefinitely, until you click back inside the game window.

Steps to reproduce the bug:

1) Enable in-game features.
2) Queue for duty.
3) Wait until queue pops (do a solo duty for testing)
3a) Optionally, click outside of the game window.
4) Watch as the game is brought out of focus then back into focus.
4a) If clicked outside of window, watch as it cycles focus indefinitely.

Expected behavior
The launcher not to interrupt the user and have the game behave as normal (as it did prior to the 5.2 update fix).

Screenshots
Video showcase: https://gfycat.com/thirdboldgallinule

Other information (please complete the following information):
Operating System: Win10 x64 v1703
XIVLauncher version: Latest at time of writing
Launching as admin?: User account is admin (UAC disabled)
Using Steam?: No
Addons/Plugins enabled: Just the standard Discord rich presence and "in-game features" that come with the program.

Additional information

Roulettes don't show the found duty anymore. It just says "Duty pop: Duty Roulette".

Did they remove the ability to extract the duty information from the game (obfuscate) or was this a deliberate change to avoid people bailing on duty they didn't want to do?

If possible, prevent Dalamud from being affected by GShade/Reshade post processing effects.

Can reproduce this locally, with newest GShade.

Wine installs .net4.8 in windows 7 mode
.net4.8 officially doesnt support websockets on windows 7 (and 8 as well for that matter)

to make websockets work on Windows 8 and lower (and thus wine) for discord.net, you have to install an alternative websocket provider.

Discord.net provides one such websocket provider: https://www.nuget.org/packages/Discord.Net.Providers.WS4Net/
Here would be an example how to use it: https://github.com/discord-net/Discord.Net/blob/322d46e47b47e44f8b62b1ddcdcf39280cac6771/docs/guides/getting_started/samples/netstd11.cs#L7

This is the dalamud.exe log throwing a platform not supported exception:
https://zerotsu.z0ne.moe/share/dalamud.txt

Somewhat minor issue, but with the change to territory type, the value is now not set until you zone somewhere else from where you logged in.

This mainly affects the RP plugin, but it is kind of unfortunate to have your location be invalid if you happen to stay in town etc.

Example item "Elemental Blade +2" (ID 24068)

This is annoying and appears to be a limitation of xivapi's actual query handling, as even manually searching for anything with a '+', encoded or not, will fail.

Their docs mention querystring/GET search is deprecated and they now use elasticsearch via json body data. I was able to get a query with a '+' working in their search playground using that, but I didn't spend enough time to figure out what is necessary to make that work at least on parity with the existing search.

Example post body for searching for that particular item (git formatting hates me): { "indexes": "item", "columns": "ID,Name,Icon", "body": { "query": { "wildcard": { "NameCombined_en": "*blade +2*" } }, "from": 0, "size": 1 } }

Periodically I run across issues with ImGui that are already fixed in upstream. I know this affects other people, and generally we can find workarounds, but it would be nice to just... have the fixes.

Dalamud uses a version of ImGui released on 31 July 2019. It would be nice to update it.

I am very unsure if this behavior is intentional but using the /xlbgmset command will force the music to never change between locations, instances, or areas beyond the set song. Additionally this change will only be turned when when re-logging, or closing and relaunching the client entirely. There appears to be neither an option for turning off this change, nor an option to find out what bgm id corresponds to what. Parsing through at least 708 numbers for songs isn't exactly desirable when I wish to reset the bgm itself.

As of now, Japanese players don't have a way to type in ImGui text areas.

When the value of RawX and RawY are technically supposed to go into the negative, instead, since they are interpreted as uints, the value shoots up:

Steps to reproduce:

1. Go to Lakeland
2. Go to X: 20.9 Y: 21.0 Z:0
3. Send an /e <pos> and log the value of the produced MapLinkPayload

Is this a bug?
This was previously attempted to be fixed by #84.

The following code worked until 2 days ago. Now the code crashes or prints a blank chat entry when wrapped in try/catch. Everything works as it should in debugging. Printing the coordinates in Chat.Print displays the correct values. ffxiv_dx11.exe + 0x1C63F34 shows the correct Map value. I'm not sure if I'm doing something wrong that somehow just worked until the latest version, or if an update broke it. It appears to be referencing Dalamud 5.0.0.2 currently. Here's the affected code:

var currentActor = this.pluginInterface.ClientState.Actors[i];
var MapID = (ushort)Marshal.ReadInt16(pluginInterface.TargetModuleScanner.Module.BaseAddress + 0x1C63F34);
var TerritoryType = pluginInterface.ClientState.TerritoryType;

XivChatEntry entry = new XivChatEntry() { MessageBytes = new 
Dalamud.Game.Chat.SeStringHandling.Payloads.MapLinkPayload(TerritoryType, MapID, convertCoord(currentActor.Position.X, 100), 
convertCoord(currentActor.Position.Y, 100)).Encode(), Type = XivChatType.Echo };````

where convertCoords is:

   public static float convertCoord(double coord, double scale)
    {
        var c = scale / 100.0;
        coord *= c;
        return float.Parse(((41.0 * c) * ((coord + 1024.0) / 2048.0)).ToString("#.#"));
    }

I also the function this way to no avail:

var currentActor = this.pluginInterface.ClientState.Actors[i];
var MapID = (ushort)Marshal.ReadInt16(pluginInterface.TargetModuleScanner.Module.BaseAddress + 0x1C63F34);
var TerritoryType = pluginInterface.ClientState.TerritoryType;

XivChatEntry entry = new XivChatEntry() { MessageBytes = new 
Dalamud.Game.Chat.SeStringHandling.Payloads.MapLinkPayload(TerritoryType, MapID, (int)currentActor.Position.X, (int)currentActor.Position.Y).Encode(), Type = XivChatType.Echo };```

Describe the bug here:
Since the 4.8.1 update, occasionally when logging out of a character to the title from the main menu, the game will completely exit without a visible error message. Some users have told me this situationally occurred prior to this release, however I never personally saw this begin happening until the latest release.

Steps to reproduce the bug:

1. Open the System menu in FFXIV
2. Choose Log Out
3. Game may or may not crash

Expected behavior
Game should return to title menu so another character or world may be selected.

Other information (please complete the following information):
Operating System: Windows 10 Pro (1908)
XIVLauncher version: 4.8.1
Launching as admin?: No
Using Steam?: No
Addons/Plugins enabled: Discord Rich Presence v1.1.0.0

Additional information
I noticed in the Dalamud.txt logfile that it was attempting to load an older version of Discord Rich Presence (v1.0.0.0) but there was a bug in that version that prevented it from loading. I deleted the extra copy of the plugin from the AppData folder and there are no other errors in the Dalamud log file.

Describe the bug here:
When streaming using the Go Live feature in Discord, if FFXIV was launched using XIVLauncher, the entire feed jitters as if it's rendering then going back 2 frames, then going forward 4 frames, then back 2 frames, etc.

I have tried disabling XIVLauncher's Discord Rich-presence, Steam Integration, and In-Game additions... still doesn't fix it.

Steps to reproduce the bug:

1. Launch game with XIVLauncher.
2. Start Go Live stream in a Discord server voice-chat, select the game application "Final Fantasy XIV".

Expected behavior
Launches stream and the game flows normally.

Screenshots
Video Link

Other information (please complete the following information):
Operating System: Windows 10 1909
XIVLauncher version: 4.7.2.0
Launching as admin?: No
Using Steam?: Launching XIVLauncher through Steam, but the game is not the Steam version.
Addons/Plugins enabled: Reshade, various mods with TexTools, All other hooks in XIVLauncher disabled, but changing them does not change anything.

Additional information
Starting game vanilla without XIVLauncher works just fine with Discord Go Live.

I am using 2x GTX 1070's in SLI.

All the overlays seem to have an occasional flicker like they are briefly losing focus and then regaining focus again. It is especially noticeable in the "Teleporter" plugin on the AetherGate overlay. When adding new teleport buttons if it flickers the new button edit window closes and has to be reopened again to continue adding the information in for it. This only started to occur on the last couple updates to the Launcher and/or the plugin.

Describe the bug here:
XIVLauncher plugin GUI not loading with /xlplugins, nor any other plugin command
when RTTS (https://www.guru3d.com/files-details/rtss-rivatuner-statistics-server-download.html) is running.

Steps to reproduce the bug:
Have RTTS (https://www.guru3d.com/files-details/rtss-rivatuner-statistics-server-download.html) running as an overlay, or FPS limiter before launching the game with XIVLauncher

Expected behavior
I expected the /xlplugins command to output a GUI, and /pcombo command to output the plugin GUI.

Other information (please complete the following information):
Operating System: Windows 10, 2004
XIVLauncher version: v4.7.12.0
Launching as admin?: No
Using Steam?: No
Addons/Plugins enabled: XIVCombo 5.2

Additional information
When I launch the game with RTTS off and turn it on after the plugins have loaded, the GUI's load fine.

Hi,

Requesting a QOL improvement.

Currently after some game patches / updates, some plugins are automatically disabled (which is great - no game crashes with incompatible plugins).

However, when using /xlplugins and selecting "update" those plugins are not reinstalled at all.

Now that we have a healthy amount of plugins, it can be pretty tedious to reinstall the ones that were disabled, and also a bit of a pain mid-dungeon if you missed MouseOver plugin or XIVCombo.

It would be great if plugins previously installed but not loaded ingame were somehow flagged so running a plugin update would reinstall the latest version.

for big resolutions

having the MB plugin loaded when chat extender tries to load (either from a fresh install or an update from old version but not on just a regular game launch with no updates or installs to CE) seems to break chat extender applying changes to the font size. font size seems to be set to 20ish and no amount of spamming the apply button or disabling/re-enabling any plugin including MB on that particular launch will not fix, the changes do take effect on game relaunch and then the apply button also functions as normal. tested with only those 2 plugins loaded and all 11 that i use, repeatable every time.

troubleshooting done:

deleting all old versions of MB, plugin folders (not config folders) - didn't work
deleting all old versions of CE, plugin folders (not config folders) - didn't work

when launching launching the game after deleting both plugin folders (not config folders):
installing CE after MB, did not work, as expected..... thank god or i would have lost my shit
installing MB after ce installed 2.0.2.3 - worked, cuz it's like loading CE without MB loaded?

i really dun wanna delete the config folders for troubleshooting so i'll let Haplo do that xD

Experienced by Jazzy#9999 on Discord.

Have Discord bot setup

Dalamud output:

2019-12-31 16:33:06.058 -06:00 [ERR] Could not get XIVAPI character search result.
System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at Dalamud.XivApi.<Get>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Dalamud.XivApi.<GetCharacterSearch>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Dalamud.DiscordBot.DiscordBotManager.<GetCharacterInfo>d__19.MoveNext()

logging map POS and unsupported map bytes from dalamud.txt.
Holminster Switch ( 8.9 , 9.3 ) Unsupported map bytes FE 03 45 02 20 FE FF FE 36 F8 FD FF FE 89 FF 01

Holminster Switch ( 12.4 , 9.8 ) Unsupported map bytes FE 03 45 02 20 F2 F2 3E FD FF FE EB FF 01

azim step 12.4, 9.3 Unsupported map bytes FE 02 6E 01 74 FE FF F9 12 90 FD FF F6 B9 FF 01

[azim step Unsupported map bytes FE 02 6E 01 74 F6 02 24 CA F5 06 54 FF 01] - possibly not correct, working on finding coordinates for this

The Azim Steppe ( 31.0 , 9.3 ) Unsupported map bytes FE 02 6E 01 74 F5 07 53 FD FF F6 B9 FF 01

Don't crash in ImGuiScene dispose during init (this is done while resizing, apparently?)
This null refs
https://github.com/ff-meli/ImGuiScene/blob/d5b9345dc1463d746b832843bd7c81b753d4e5b0/ImGuiScene/RawDX11Scene.cs#L290

If this is not intentional, I'll push a PR to fix it.
d4b5262