goatcorp / dalamudpluginsd17 Goto Github PK

View Code? Open in Web Editor NEW

69.0 69.0 192.0 74.5 MB

Dalamud plugin manifests

Python 100.00%

dalamudpluginsd17's People

Contributors

Stargazers

Watchers

Forkers

notnite lmcintyre kazwolfe nonowazu infiziert90 wolfcomp punishedpineapple tischel xpahtalo aireil 0ceal0t sheepgomeh meisterlala mgal2o4 ottercorp reiichi001 kalilistic critical-impact styr1x fitzchivalrik daemitus anna-is-cute kouzukii karashiiro ladydefile cairthenn initialdet tesu unknownx7 chalkos attickdoor marconsou xorus khloeleclair lokinmodar d87 redmage1993 kissorjeyabalan meoiswa chickenstew fmauneko jaycewhite bluefissure eja-git jessidhia cmdrnuffin maia-everett rreminy electr0sheep dormanil nadyanayme haplo064 yomishino fpc-pm squidmade pilzinsel64 pythyu wesselkuipers koenari zacharied cadaeix helios747 sersorrel kirrana lharz midorikami caraxi sevii77 kaminaris rosella500 belzaru17 ottermandias mustafakalash drahsid ffxiv-sonar rootdarkarchon solimproper projectmimer frogworks-interactive edg-l yestarone danielbrenom apetih npittinger princessrtfm lerofni raylavaldez zhudotexe awgil berna-l aelexe kebinuchiousu rekyuu lynesth rokaskil hakyeong img02 ikr4-m neneppie chunghyang

dalamudpluginsd17's Issues

Invalid Git repository URL message is incorrect

Otter didn't put the ".git" at the end of his repo URLs, and got an error that "only HTTPS addresses may be used for your plugin". This shouldn't be the error message.

Api level override warning

Bleatbot should complain during the build process if a manifest contains a apilevel override.

Dalamud packager should be responsible for setting the correct apilevel

Plugin Icons mandatory?

This just came up. If icons are mandatory - maybe strengthen the wording on this.

Mention common failure cases

Owners needs to be the GitHub username the PR is being submitted with
Need to ensure you have a lockfile present
Need to make sure you're not using Windows Forms or similar - for audio, use NAudio (?)
Need to make sure you have DalamudPackager as a dependency and that it's set up correctly in your solution
Internal name must be the same as the folder used for the plugin in the repo

Only one I'm not sure about is the audio. @kalilistic can you tell me what the correct fix for that is?

Figure out how icons are gonna work

images folder next to manifest and we just copy it over? idk Lol

Plogon fails don't actually error the action

It sets the exit code to -1, but that doesn't work?

I think we can safely say that all the plugins that were going to be ported have been ported by now. Making an issue, not a PR, as I don't know if other parts of the build system need to be changed to do this. (Might be nice to have docs on adding or removing test channels?)