goinstant / chat Goto Github PK

sinon error: TypeError: argument at index 2 is not a function: undefined

culprite:

on: sinon.stub().callsArg(2)

The avatarUrl var in the message-template is susceptible to XSS, since it is inserted into our CSS without sanitation and users have permission the set the avatarUrl to anything.

This should be moved out of the template to use DOM instead. Similar to message text.

rather than begin at the top.

should be an option to specify message order, like { gradualPopulation: true} or something

The widget should remember the open/closed status of a given user on their last page load. This enables multi-page apps to retain a memory rather than always loading closed or always loading open.

If I am typing a message and navigate to another page with the chat widget, it would be nice if my chat message I was in the middle of typing was there on the next page. Currently, when you leave the current page, you lose everything in your text box.

EDIT: This will help if someone navigates during a collaboration bundle session, and the people they're in the session with are typing at the time.

In chat things like " should work.

Currently the collapse button toggles a class .collapsed on a few individual elements, it should be applied to .gi-chat with the class name .gi-collapsed to keep consistent with the other widgets (user-list specifically).

chat messages should be able to expire so that we don't have to keep a long history.

Separate the message view (_createMessage _renderText, and _validateUrl) from the main view.

Just want to get a checklist of what has to be done to launch the Chat Widget for real.

• Tests
• Documentation
• Example
• Basic styling
• Security Review

What else?

I'll leave the UX + UI suggestions up to @ntassone

It would be nice to have url hyperlinked when users share an url in chat.

The tests are stubbing the user cache internals instead of the user cache interface itself meaning that these tests will need to be rewritten any time user cache changes.

Put in a todo list for this please.

Add a generic set of emotes :) ;) :O :( ...
Maybe add an option for adding custom emotes.

This could be a good widget to validate our key expiry. Afaik it doesn't get much use in any of our other demo apps, so perhaps using it here to delete old messages (declared when widget is instantiated?) might be a good idea !

@ntassone need to design the out-of-the-box / default experience for this.

Store a historical user list separately instead of storing the userObj in each message. Should only be storing the userId on each message.

travis is not setup to run chat currently, it should match all of the other component repositories

Add new message indicators.

Options (default):

{
  windowBlink: true,
  chatBlink: true,
  blinkText: 'New Message',
  sound: true,
  soundURL: 'https://cdn.goinstant.net/widgets/chat/latest/chat/sounds/ding.mp3'
}

1. windowBlink: If window is not focused, blink the page title with "New Message" until window gets focused.
2. chatBlink: If chat is collapsed, blink the chat header with "New Message" until chat gets expanded.
3. sound: If window is not focused or chat is collapsed play sound once.

https://github.com/web-mech/badwords

For performance reasons we should limit the amount of messages that will appear in the chat widget, if you scroll to the top you should be able to "load more" messages.

The maximum number of messages to display could be an option.