goinstant / rich-text-editor Goto Github PK

https://github.com/goinstant/rich-text-editor/blob/master/lib/rich_text_editor.js#L17 Could be moved to its own file.

https://github.com/goinstant/rich-text-editor/blob/master/lib/rich_text_editor.js#L115

To reproduce:

1. open the demo with two browsers.
   https://developers.goinstant.com/v1/widgets/rich_text_editor.html
2. Clear the page and enter some text with browser 1.
3. With browser 2, place the cursor in the middle of the text and start typing.
   The cursor will jump to a different place.

Is it possible to get a private editor on the demo page?
Currently the demo doesn't reflects a realistic usage because there are many users trying to break it at the same time.
A button that will let us create a private instance with a random URL that we can share will be great to test the editor with 2 or three collaborators in a realistic scenario.

Thanks

https://github.com/goinstant/rich-text-editor/blob/master/lib/rich_text_editor.js#L20

This should be separated into templates. See how chat does it:

https://github.com/goinstant/chat/tree/master/templates
https://github.com/goinstant/chat/blob/master/lib/view.js#L253

If I am editing a line while someone above is making new lines my cursor gets bumped out of my viewport

Tried to down arrow to where the new lines are, but my cursor doesn't move, ends up typing on top of other text.

https://github.com/goinstant/rich-text-editor/blob/master/lib/rich_text_editor.js#L6

Yeah a history would be nice, also a notification to tell me when someone is editing below my view

Code blocks like this violate our coding standards.

Should be:

var moveCursor = function(quill, user, index) {
  var cursorManager = quill.getModule('multi-cursor');
  var cursorColor = user.avatarColor || DEFAULT_USER_COLOR;

  if (cursorManager.cursors[user.id]) {
    cursorManager.removeCursor(user.id);
  }

  cursorManager.setCursor(user.id, index, user.displayName, cursorColor);
};

This should be a configurable option and the default should be more like 3 seconds instead of 10

https://github.com/goinstant/rich-text-editor/blob/master/lib/rich_text_editor.js#L195

Destroy should call #destroy on the usercache, clean up any listeners, and remove the widget from the DOM.

See UserList#destroy: https://github.com/goinstant/user-list/blob/master/index.js#L437

Doesn't look like there's a publicly exposed method for retrieve the editor contents programatically.

Since the widget is built on top of Quill, which does expose this functionality, perhaps the internal Quill instance should just be exposed publicly and documented?

Alternatively there could be interfaces that call through to the Quill instance if you don't want to expose that for encapsulation reasons.

https://github.com/goinstant/rich-text-editor/blob/master/lib/rich_text_editor.js#L10

This module is using lodash but is not requiring it. The example only works because lodash is on the window.

If you can not solve the img delete problem, this thing is bullshit

Uncaught HierarchyRequestError: Failed to execute 'insertBefore' on 'Node': Nodes of type 'HTML' may not be inserted inside nodes of type '#document'. platform.min.js:2

Uncaught TypeError: Cannot read property 'parentNode' of null rich-text-editor.min.js:6

This is getting spammed in the console:

Trying to apply delta to incorrect doc length 
a {startLength: 70, endLength: 71, ops: Array[2], apply: function, applyToText: function…}

n {startLength: 0, endLength: 71, ops: Array[38], savedOpIndex: 38, savedOpOffset: 71…}