Proper popup position for multimonitor boxes. about goldendict

[sencer]

Same problem. This is very annoying.

[sencer]

Solution seems to be pretty easy though!

change

QRect desktop = QApplication::desktop()->screenGeometry();

in scanpopup.cc to

QRect desktop = QApplication::desktop()->screenGeometry(1);

that's all!

[Tvangeste]

@sencer, why specifically screen 1? What if user tries to work with GoldenDict on screen 2 or 3 or 4? :) I would say that the 100% correct fix would be to detect the current screen and limit the pop-up to this particular current screen.

[sencer]

Because screen(1) gives the current screen?

[Tvangeste]

Looking at the docs:

const QRect QDesktopWidget::screenGeometry(int screen = -1) const
Returns the geometry of the screen with index screen.
The default screen is used if screen is -1.

So it looks like the screen(1) would just return the first screen, it might not be the default one, and it might not be the current one.

[sencer]

Interesting, since I just compiled goldendict on my ubuntu box with two screens and the scan popup window appears in which ever monitor I am on.

Hence, either qt indexes screens with the active one being the 1st, or there is a handy bug here.

[sencer]

While currently this works, I guess something including QDesktopWidget::screenNumber would be a better way of doing it. Perhaps just?

QRect desktop = QApplication::desktop()->screenGeometry(QDesktopWidget::screenNumber());

[chulai]

@sencer, even if this change is trivial we have to test in different platforms: OS X, Windows (XP, Vista, 7, 8) and Linux with different Window Managers.

[sencer]

Sure.

[Tvangeste]

Once we are done with 1.5 release, I'll take a closer look. I wanted to install Linux on my main workstation (with two monitors) for quite some time already... :)