goldmansachs / gs-collections-kata Goto Github PK

The .settings/org.eclipse.jdt.core.prefs file specifies jdk1.6 as the compiler compliance level. The kata code does not compile as a result. Should be 1.8. Something like:

eclipse.preferences.version=1
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
org.eclipse.jdt.core.compiler.compliance=1.8
org.eclipse.jdt.core.compiler.debug.lineNumber=generate
org.eclipse.jdt.core.compiler.debug.localVariable=generate
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
org.eclipse.jdt.core.compiler.source=1.8

as stated

The .classpath file is left over from before the upgrade to the new gs-collections libraries. The contents should be:

Does the contributions policy of this project follow gs-collections?

#1

Exercise2 answer is not seem to answer of Exercise2.

Problem of Exercise2
https://github.com/goldmansachs/gs-collections-kata/blob/master/src/test/java/com/gs/collections/kata/Exercise2Test.java

Answer of Exercise2
https://github.com/goldmansachs/gs-collections-kata/blob/solutions/src/test/java/com/gs/collections/kata/Exercise2Test.java

The PDF links in the README.md ¹:

appear to redirect to another repo: https://github.com/eclipse/eclipse-collections — is that intentional? If so, maybe it would make sense to update the links to point to the documentation that's hosted in that repo or elsewhere? As it is, it's confusing:

• the raw links aren't rendered correctly
• copy-pasting the full URLs to those PDFs redirects to another (seemingly unrelated) GitHub collections repo