GithubHelp home page GithubHelp logo

Comments (4)

patrick-kidger avatar patrick-kidger commented on July 28, 2024

A first recourse would be to report this as a bug in Flax. I suspect they'd be amenable to a PR fixing this.

An alternative option is to use Equinox instead, of course!

How are you applying jaxtyping's typechecking? For the more general problem of skipping certain modules then usually the import hook will only add those modules you explicitly ask it to typecheck. (Where you can list your own modules and not list third-party modules.)

from jaxtyping.

kvablack avatar kvablack commented on July 28, 2024

An alternative option is to use Equinox instead, of course!

If only it were that easy, migrating the entire codebase to Equinox is a bit out of scope unfortunately 😅

Upon further inspection, it looks like this only happens when typechecking a flax.struct.dataclass.

I'm using the decorator syntax to only typecheck certain functions and dataclasses, so I'm not sure how the import hook would help. The problem is that jaxtyping is working great most of the time (during init/apply/etc), and I would really like to typecheck my dataclasses at those times! It just breaks during tabulate. Are there any other ways that you know of to disable typechecking just for that one call?

I also tried defining Array = jax.Array | flax.linen.summary._ArrayRepresentation and using that type annotation instead, to no avail.

from jaxtyping.

patrick-kidger avatar patrick-kidger commented on July 28, 2024

Ah sorry, I had to go look up the source code for tabulate to understand what you're referring to. IIUC they're actually initialising the dataclass for you, but with the arguments of the wrong type?

For what it's worth, jaxtyping (for historical reasons) actually checks the attributes of the class after initialisation, not the arguments to __init__. When you report things not working above, it might be that you're doing this for the arguments of a custom __init__ despite it being the types of the fields that you'd need to change? (To e.g. Float[Array, "foo bar"] | flax.linen.summary._ArrayRepresentation.)

Other than that jaxtyping does offer an opt-out flag that you could set for the duration of the call:

if item.lower() == "jaxtyping_disable":

from jaxtyping.

kvablack avatar kvablack commented on July 28, 2024

Ah thanks, the opt-out flag is the escape hatch I'm looking for!

It seems like the reason jax.Array | flax.linen.summary._ArrayRepresentation didn't work, though, is a separate issue with Unions. Let me open a separate issue.

from jaxtyping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.