Comments (4)
See #73.
TL;DR: don't do isinstance(..., Union[Foo, Bar])
. You want isinstance(..., typing.get_args(Union[Foo, Bar]))
. This is a known Python misfeature/bug.
from jaxtyping.
Ahh thanks, that is very unfortunate....
To make sure I understand fully, in #73 you write:
And so for some weird reason, as A | B is a different object to Union[A, B], here we find that the former is compatible with isinstance checks in the way you're doing
That seems to imply that the A | B syntax should work, at least as long as jaxtyping supports it, which it seems like it does since #77 ?
Also, to doubly clarify, both types of Unions should work when using the @jaxtyped
decorator since you use typing.get_args
internally?
from jaxtyping.
Yes to everything!
Although note that whilst isinstance(..., A | B)
should work, isinstance(..., Float[A | B, ...])
will not, I think. 🙃
from jaxtyping.
Thanks!
from jaxtyping.
Related Issues (20)
- Issues with torch.compile HOT 5
- Functions without type hints and import hook HOT 1
- Compatibility with multiprocessing / joblib - AttributeError: type object 'Float[Tensor, 'batch_size num_classes']' has no attribute 'index_variadic' HOT 4
- Can typeguard be an optional dependency? HOT 8
- Are pytorch named tensors supported, like in torchtyping? HOT 1
- How to properly escape `*` and `_` when rendering docs with Sphinx HOT 3
- numpy structured dtype support HOT 1
- Bug with default argument binding HOT 2
- Incompatibility with flax.linen.tabulate HOT 4
- jaxtyping with JAX severely slowing down training speed HOT 6
- `install_import_hook` skip `no_type_check` HOT 1
- add type annotation for jaxtyped HOT 1
- Installing `jaxtyping` makes Pytest slow(er) HOT 3
- Annotations for tensors with dynamics dimensions HOT 2
- Leading integer and ellipses in pytree raises error HOT 2
- `mypy` gives error for `np.ndarray` as container type HOT 2
- Misleading exception when runtime type checker is used directly HOT 4
- Creating instances of `jaxtyped` dataclasses is slow HOT 3
- Inconsistent shape checking for lists of tensors HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jaxtyping.