GithubHelp home page GithubHelp logo

Unions not working about jaxtyping HOT 4 CLOSED

kvablack avatar kvablack commented on July 28, 2024
Unions not working

from jaxtyping.

Comments (4)

patrick-kidger avatar patrick-kidger commented on July 28, 2024

See #73.

TL;DR: don't do isinstance(..., Union[Foo, Bar]). You want isinstance(..., typing.get_args(Union[Foo, Bar])). This is a known Python misfeature/bug.

from jaxtyping.

kvablack avatar kvablack commented on July 28, 2024

Ahh thanks, that is very unfortunate....

To make sure I understand fully, in #73 you write:

And so for some weird reason, as A | B is a different object to Union[A, B], here we find that the former is compatible with isinstance checks in the way you're doing

That seems to imply that the A | B syntax should work, at least as long as jaxtyping supports it, which it seems like it does since #77 ?

Also, to doubly clarify, both types of Unions should work when using the @jaxtyped decorator since you use typing.get_args internally?

from jaxtyping.

patrick-kidger avatar patrick-kidger commented on July 28, 2024

Yes to everything!

Although note that whilst isinstance(..., A | B) should work, isinstance(..., Float[A | B, ...]) will not, I think. 🙃

from jaxtyping.

kvablack avatar kvablack commented on July 28, 2024

Thanks!

from jaxtyping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.