GithubHelp home page GithubHelp logo

Comments (4)

antonmedv avatar antonmedv commented on May 4, 2024 7

Interesting idea. I like it. Let me think about it for some time. 🙃

from zx.

kapouer avatar kapouer commented on May 4, 2024

Note that adding more dependencies makes the tool less simple to maintain and distribute,
which is a nice thing to keep in mind if "xz" is meant to be some kind of "shell" alternative.
I have debian in mind of course - where the situation is actually pretty good, only "shq" needs to be packaged,
and "shelljs" has already all its dependencies packaged (maybe more work is required for the tests suites).

from zx.

rattrayalex avatar rattrayalex commented on May 4, 2024

I think shelljs seems to be implemented in pure JS (for example, echo is basically process.stdout.write) so it's portable across platforms.

I would hope that adding a library like it would be very simple to maintain; just something like this:

import shell from 'shelljs';

const {sed, cp, ls, rm, which, /*etc*/} = shell;
export {
  shell,
  
  sed,
  cp,
  ls,
  rm,
  which,
  /*etc*/
}

I do predict some slightly tricky questions around whether to use shelljs's implementation of cd or keep the current one, and of course you'd have to document that you need to use shell.exec() to access that functionality instead of just exec() (since it'd conflict with the evil builtin function). There may be other conflicts or difficulties I'm not thinking of.

If shelljs were included, it might also be worth considering using it under the hood for $`cmd`, since it returns the nice ShellString response with .code, .stdout, .stderr, but that would not need to happen right away by any means.

Worth noting that shelljs is 211kb unpackaged according to npm (probably fine for the use-case, but much larger than zxs current 24kb) and gets almost 7mm downloads/wk, indicating it's very widely used for this purpose.

from zx.

antonmedv avatar antonmedv commented on May 4, 2024

Including shelljs isn't planned for zx.
It can be easily done on user side:

require('shelljs/global');

from zx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.