GithubHelp home page GithubHelp logo

Comments (36)

tomsawada avatar tomsawada commented on July 17, 2024 12

@alexpryshchepa > For those who are still facing this problem, most likely in the assetlinks.json you are using SHA256 from the "Upload certificate" and not from the "App signing certificate". You can find both certificates in Google Play Console -> Release management -> App signing.

I owe you a beer. ;)

from svgomg-twa.

navinSing avatar navinSing commented on July 17, 2024 10

@andreban
note: add to home screen works correctly(correct launch icon and no address bar). But app apk on the path does not. How should i debug.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024 10

@pranaykothari It seems https://xyz.in redirects to https://www.xyz.in. The first is listed to be verified in the app, the second is not. Try changing the hostName to www.xyz.in.

PS: This sounds like a great question for Stack Overflow. Could you please post it there? I'm happy to provide the answer there.

from svgomg-twa.

bantyK avatar bantyK commented on July 17, 2024 5

Hey @andreban thanks for the response. I was able to just fix it. In my case it was an issue related to signin config. I was running my app in debug version but my app was signed only for release version.

However, I think information like this should be added in the documentation.

from svgomg-twa.

alexpryshchepa avatar alexpryshchepa commented on July 17, 2024 5

For those who are still facing this problem, most likely in the assetlinks.json you are using SHA256 from the "Upload certificate" and not from the "App signing certificate". You can find both certificates in Google Play Console -> Release management -> App signing.

from svgomg-twa.

PEConn avatar PEConn commented on July 17, 2024 4

Hey, I'm one of the maintainers for this and TWA related stuff.

You can use Peter's Asset Link Took to generate your Digital Asset Links file for an Android app. Just install it on your device and pick your package.

from svgomg-twa.

kimuradev avatar kimuradev commented on July 17, 2024 2

@andreban

I did not publish my app yet because I'm afraid this behaviour is happening for all users.

My question is if the url bar will disapear after I publish my app on Play Store and it is expected when I'm installing my app locally on my device?

Bellow the image using this project example and installed the apk directly from Android Studio on my device:

image

And just to your understand after I added it as my home screen icon and access throught this it is not ocurring:

image

I also tested in 2 devices: Azus zenfone 2 (Android 5.0) and Samsung J5 Prime (Android 8.0)

from svgomg-twa.

GF- avatar GF- commented on July 17, 2024 2

Hi all,
a heads up: if Firefox is set as a default browser on the Android settings of your device, then the address bar will show up regardless.
In my case assetlinks and signatures were all configured correctly, but the address bar went away once I actually set Chrome as default browser.

I hope that helps.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024 1

@bantyK issues with showing the top are usually related to the misconfiguring Digital Asset Links. I haven't a case where the setup is correct and the top bar is showing. I'm happy to take a look on why it's not working for you, if you can share the APK with me.

@leandro2ki we have discussed this offline. Could you please confirm the issue has been fixed for you?

I'm closing this issue, as it's misleading folks to believe there's an issue causing the top bar to show.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024 1

This section was recently added to the documentation for the sample. Does it help?

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

Would you be able to link to your assetlinks.json file?

from svgomg-twa.

navinSing avatar navinSing commented on July 17, 2024

yes i am able to access
https://a.b.com/.well-known/assetlinks.json in browser

[{"relation":["delegate_permission/common.handle_all_urls"],"target":{"namespace":"android_app","package_name":"zzz.a.b.com","sha256_cert_fingerprints":["............................."]}}]

Access-Control-Allow-Headers: Origin, Accept, Accept-Version, Content-Length, Content-MD5, Content-Type, Date, X-Api-Version, X-Response-Time, X-PINGOTHER, X-CSRF-Token,Authorization
Access-Control-Allow-Methods: *
Access-Control-Allow-Origin: *
ACCESS-CONTROL-MAX-AGE: 1000
Content-type: application/json
Date: Tue, 16 Apr 2019 05:55:05 GMT
Transfer-Encoding: chunked

from svgomg-twa.

navinSing avatar navinSing commented on July 17, 2024

Any idea what is wrong.(What all things i should verify)
I still see address bar. Also the custom icon was not showing up.

i rebuild the app and published again.. but still showing up the address bar

please help

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

Hi @navinSing, if you have the APK published somewhere, I'd be happy to take a look in it and help understand what is going wrong.

from svgomg-twa.

navinSing avatar navinSing commented on July 17, 2024

Please find the apk

app-release.zip

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

The APK and the site are configured correctly, and I'm able to see it working on my device.
Screenshot_20190417-120803

Could you confirm the Android version (Settings > System > About Phone) and the Chrome version (chrome://version) you have installed?

from svgomg-twa.

navinSing avatar navinSing commented on July 17, 2024

yes .. may be ..

Android version (Settings > System > About Phone)
7.0 NRD90M

Chrome version (chrome://version) you have installed?
72.0.3626.105

from svgomg-twa.

navinSing avatar navinSing commented on July 17, 2024

I am available on hangout : [email protected]

from svgomg-twa.

kimuradev avatar kimuradev commented on July 17, 2024

I'm getting the same issue here. I'm still seeing my url bar from my app and when I add it to home screen then url bar disapear. Anyone has a solution for it?

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

@leandro2ki Is there anywhere I can download the APK to check it out?

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

@leandro2ki It seems the assetlinks validation is failing. Configuring Digital AssetLinks has a few moving parts. If you can make the APK or the source code available I can check if there are any issues with the configuration. Otherwise, we need to confirm its a bug and create an issue in Chrome. Feel free to share the APK on e-mail, if that helps. My e-mail is the same as my Github username, but @google.com

from svgomg-twa.

kimuradev avatar kimuradev commented on July 17, 2024

@andreban I sent you an e-mail with my apk. I'll appreciate if you could take a look there. Thanks.

from svgomg-twa.

bantyK avatar bantyK commented on July 17, 2024

I am still facing this issue ? Is this resolved ? I am facing this issue on Samsung S7 edge device but it is working fine in 1+ 5T

from svgomg-twa.

pranaykothari avatar pranaykothari commented on July 17, 2024

signin

Hi @bantyK , how did you fix the issue related to signin config you mentioned? We have the exact same issue, but can't figure the solution. In our case we have a SHA256 fingerprint that we use to sign the app and publish to app store. The same key is used in digital asset link, and the TEST succeeds. Unfortunately, the app still opens up with the address bar.

@andreban I believe the documentation link you mentioned is good, but we still could not resolve the issue mentioned above.

Any insight will really help.

Thanks,
Pranay.

from svgomg-twa.

bantyK avatar bantyK commented on July 17, 2024

Hey @pranaykothari, in my case only the release flavor of the app was signed and I was running the app in debug version which is causing the address bar to show up. Try to run the app in the release version and it should work.

from svgomg-twa.

pranaykothari avatar pranaykothari commented on July 17, 2024

@bantyK I verified that we are running a release signed build (and the same is published in app store) using the following command, and it does mention APK is in the release mode.

command: jarsigner -verify -verbose -certs your_apk.apk

(command reference)

Also, here is the relevant content of the app/build.gradle file.

   buildTypes {
        release {
            minifyEnabled true
            debuggable false
        }
    }

And here is the twamanifest info:

def twaManifest = [
    applicationId: 'in.xyz.app',
    hostName: 'xyz.in', // The domain being opened in the TWA.
    launchUrl: '/', // The start path for the TWA. Must be relative to the domain.
    name: 'XYZ', // The name shown on the Android Launcher.
    themeColor: '#FFCD59', // The color used for the status bar.
    backgroundColor: '#ffcc99' // The color used for the splash screen background.
]

I wonder what are we still missing?

Pranay.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

@pranaykothari Is the URL you are trying to open https://xyz.in/ ? That URL returns connection refused for me. Even though http://xyz.in/ works, TWAs require HTTPS.

from svgomg-twa.

pranaykothari avatar pranaykothari commented on July 17, 2024

@andreban Your answer is spot on! That seems to be the issue. Changed the hostname to www.xyz.in in app/build.gradle and it stops showing the address bar. Appreciate your help.

Created a stack overflow question as requested:
https://stackoverflow.com/questions/56629441/twa-has-assetlinks-but-is-still-opening-with-address-bar

Thanks,
Pranay.

from svgomg-twa.

amirmujtaba avatar amirmujtaba commented on July 17, 2024

@andreban can you please help me on same issue?

from svgomg-twa.

PEConn avatar PEConn commented on July 17, 2024

from svgomg-twa.

Rishabh-sx avatar Rishabh-sx commented on July 17, 2024

Hi @andreban,

I have verified my web asset linking on
https://developers.google.com/digital-asset-links/tools/generator
and SHA fingerprint from
https://play.google.com/store/apps/details?id=dev.conn.assetlinkstool

I have done asset linking with 5 servers and observing weird things happening with my app.

  1. On one device 2 different domain URLS are working fine but the other 3 are showing up with URL bar.
  2. On one device all 5 URLs are showing up with URL bar.
  3. Also, My standalone sample that means a project from which I use to create an artifact for my main app & integrate it for production. In that sample app, everything is working perfectly in terms of hiding URL.

Can you please help me?

Initially, we tested it on the sample & everything worked perfectly & everyone was excited for its integration it into the main app but now we are facing weird things & near to our production deadlines :(

from svgomg-twa.

infinitycodio avatar infinitycodio commented on July 17, 2024

Hi.. I've followed this.. But still the issue persists. Verified SHA256 certificate from Play Console as well.

Hi @andreban,

I have verified my web asset linking on
https://developers.google.com/digital-asset-links/tools/generator
and SHA fingerprint from
https://play.google.com/store/apps/details?id=dev.conn.assetlinkstool

I have done asset linking with 5 servers and observing weird things happening with my app.

  1. On one device 2 different domain URLS are working fine but the other 3 are showing up with URL bar.
  2. On one device all 5 URLs are showing up with URL bar.
  3. Also, My standalone sample that means a project from which I use to create an artifact for my main app & integrate it for production. In that sample app, everything is working perfectly in terms of hiding URL.

Can you please help me?

Initially, we tested it on the sample & everything worked perfectly & everyone was excited for its integration it into the main app but now we are facing weird things & near to our production deadlines :(

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

This repository has been deprecated and we're not actively looking into issues here. I'd recommend asking questions on StackOverflow, on the specific trusted-web-activity tag or, if this is a bug, filing against https://github.com/GoogleChrome/android-browser-helper

from svgomg-twa.

dazzledinil avatar dazzledinil commented on July 17, 2024

@alexpryshchepa > For those who are still facing this problem, most likely in the assetlinks.json you are using SHA256 from the "Upload certificate" and not from the "App signing certificate". You can find both certificates in Google Play Console -> Release management -> App signing.

I owe you a beer. ;)

Thank you So Much . I was having the same issue

from svgomg-twa.

skolhustick avatar skolhustick commented on July 17, 2024

For anyone using bubblewrap-cli and still confused about how to do this :

  1. Go to your Google Play Console and click on your app to open the app's Dashboard
  2. Then on the left menu go to App integrity and copy the SHA-256 certificate fingerprint under App signing key certificate
  3. In your terminal, enter command bubblewrap fingerprint add {SHA-256-that you copied}. E.g : bubblewrap fingerprint add 43:51:43:a1:b5:fc:8b:b7:0a:3a:a9:b1:0f:66:73:a8
  4. Bubblewrap will produce a file called assetlinks.json
  5. Host this file on your website so that the directory is https://yourdomain.com/.well-known/assetlinks.json
  6. The address bar should disappear now. I reinstalled my app to see the update. I DID NOT need to reupload another app bundle.

Hope this helps.

from svgomg-twa.

josh-collinsworth avatar josh-collinsworth commented on July 17, 2024

Hi all, a heads up: if Firefox is set as a default browser on the Android settings of your device, then the address bar will show up regardless. In my case assetlinks and signatures were all configured correctly, but the address bar went away once I actually set Chrome as default browser.

I hope that helps.

Thank you for saving my sanity @GF-. (PS it also works if you set Edge as the default browser. Guess Chromium is needed.)

from svgomg-twa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.