GithubHelp home page GithubHelp logo

Comments (18)

nirmalraghavan avatar nirmalraghavan commented on July 17, 2024 1

Can you confirm the version of the Support Library being used? The latest version is 91b4a1270b.

How do we find the latest version?
From Google's documentation, they says to use 7a2c1374a3. But this didn't work for me. Is there way to find the latest version support library? How we will know when a new version is released?

91b4a1270b also didn't work for me. From Logcat it says,
java.lang.IllegalAccessError: Method 'android.os.Bundle android.support.customtabs.CustomTabColorSchemeParams.toBundle()' is inaccessible to class 'androidx.browser.customtabs.CustomTabsIntent$Builder'

From a different example, I got this version 7ab7178ae0 and it worked for me.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024 1

+1 to that. The Feature Request is being tracked in this issue: http://crbug.com/989606 It'd be great if you could chime in and add any details you can on what you are building.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

Can you confirm the version of the Support Library being used? The latest version is 91b4a1270b.

from svgomg-twa.

Jcholerton avatar Jcholerton commented on July 17, 2024

We were using an earlier version but updated to 91b4a1270b on Friday. Over the weekend we've still seen some instances of the same error.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

Can you confirm those errors are happening on the latest version of your app (the one that uses the latest version of the library).

from svgomg-twa.

Jcholerton avatar Jcholerton commented on July 17, 2024

Yes, the errors are happening on the latest version.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

Thanks for confirming. Can you file a bug against the library using this template?

from svgomg-twa.

rockeynebhwani avatar rockeynebhwani commented on July 17, 2024

@andreban - We are using latest library version (91b4a1270b) for our TWA but we are seeing similar errors.

from svgomg-twa.

rockeynebhwani avatar rockeynebhwani commented on July 17, 2024

Yes, the errors are happening on the latest version.

@Jcholerton - Did you file bug with chromium team as suggested by @andreban ?

from svgomg-twa.

passiondroid avatar passiondroid commented on July 17, 2024

Filed a bug -
https://bugs.chromium.org/p/chromium/issues/detail?id=1004115

from svgomg-twa.

rockeynebhwani avatar rockeynebhwani commented on July 17, 2024

See this - https://bugs.chromium.org/p/chromium/issues/detail?id=988346

from svgomg-twa.

PEConn avatar PEConn commented on July 17, 2024

(sorry for the noise!)

@andreban This issue has been fixed on the custom-tabs-client, I think all we need to do is update the version we depend on.

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

@rockeynebhwani Could you update to the latest version and let us know if you still see the issue on that?

I have updated svgomg-twa to use the latest on #51

from svgomg-twa.

rockeynebhwani avatar rockeynebhwani commented on July 17, 2024

@andreban - I have asked our dev team to upgrade to latest version but currently we are blocked on rolling out our app to more users due to paypal issue (on another thread we talked about) so it may take some time before new users download the app. We don't want to roll out to more customers with known issue with Paypal

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

Closing the issue here, in favour of tracking in chromium bugs.

from svgomg-twa.

AlexBorsody avatar AlexBorsody commented on July 17, 2024

Got a similar error today in the logs, should this be filed in chromium bugs instead?

Huawei HUAWEI Y7 Prime 2018 (HWLDN-Q), 3072MB RAM, Android 8.0

java.lang.RuntimeException: 
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3303)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3411)
  at android.app.ActivityThread.-wrap12 (Unknown Source)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1994)
  at android.os.Handler.dispatchMessage (Handler.java:108)
  at android.os.Looper.loop (Looper.java:166)
  at android.app.ActivityThread.main (ActivityThread.java:7529)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:245)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:921)
Caused by: java.lang.IllegalStateException: 
  at android.app.Activity.onCreate (Activity.java:1081)
  at androidx.core.app.ComponentActivity.onCreate (ComponentActivity.java)
  at androidx.fragment.app.FragmentActivity.onCreate (FragmentActivity.java:6)
  at androidx.appcompat.app.AppCompatActivity.onCreate (AppCompatActivity.java:42)
  at com.google.androidbrowserhelper.trusted.LauncherActivity.onCreate (LauncherActivity.java)
  at android.app.Activity.performCreate (Activity.java:7383)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1218)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3256)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3411)
  at android.app.ActivityThread.-wrap12 (Unknown Source)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1994)
  at android.os.Handler.dispatchMessage (Handler.java:108)
  at android.os.Looper.loop (Looper.java:166)
  at android.app.ActivityThread.main (ActivityThread.java:7529)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:245)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:921)

from svgomg-twa.

andreban avatar andreban commented on July 17, 2024

@AlexBorsody filing on https://bugs.chromium.org/ or https://github.com/GoogleChrome/android-browser-helper is best - This repository is a demo app that uses the library.

It's also helpful to attach AndroidManifest.xml and build.gradle, so we know which parameters are being passed to the LauncherActivity, which support library version is being used, etc.

This specific error seems to come from the onCreate, which is really the entry-point for the application and the issue happens on a call to the framework (super.onCreate()).

The stack trace doesn't gives a full picture (eg: error message), but I wonder if it's related to this section of code: https://android.googlesource.com/platform/frameworks/base/+/refs/heads/oreo-release/core/java/android/app/Activity.java#986, although we don't request an specific orientation (we to target Android10 and use a transparent Activity).

from svgomg-twa.

AlexBorsody avatar AlexBorsody commented on July 17, 2024

OK I think I see what it is, it would be cool if there was a way we could fix the orientation to portrait. The "added from home screen" version respects the orientation set in the website's manifest.json so portrait is locked in that version but not in the TWA build.

from svgomg-twa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.