GithubHelp home page GithubHelp logo

Comments (5)

rosmo avatar rosmo commented on May 27, 2024

I created support for multiple backends a bit over a year ago and we are now revisiting the issue. I suggest the following (and I'm very happy to hear any opinions on these):

  1. Add a new annotation syntax matching the cloud.google.com/neg annotation:
cloud.google.com/neg: '{"exposed_ports": {"80":{},"443":{}}}'
controller.autoneg.dev/neg: '{ "backend_services": { "80": { "name": "foo", "max_rate_per_endpoint": 1000 } , "443": { "name": "bar", "max_connections_per_endpoint": 42 } } }'
  1. We keep the existing annotation style for backwards compatibility for "version 1.0", but emit a deprecation warning.
  2. We report status via both via new and old status annotations when there is a single port installed, only via new one when multiple ports are specified.
  3. We remove the old-style annotation in "version 1.x".

from gke-autoneg-controller.

rwkarg avatar rwkarg commented on May 27, 2024

I did basically the same thing as @rosmo mentioned in point 1 with the addition of an optional internal property (bool) to handle regional backend services on Internal Load Balancers (region pulled from http://metadata.google.internal/computeMetadata/v1/instance/attributes/cluster-location). That addressed #23, too

from gke-autoneg-controller.

rosmo avatar rosmo commented on May 27, 2024

@rwkarg would you be willing to do a PR?

from gke-autoneg-controller.

rwkarg avatar rwkarg commented on May 27, 2024

I wrote our not-autoneg controller in C# so while it was a great learning experience into how Kubernetes controllers work, it's not conducive to a PR.

One thing to keep in mind is that Internal LBs currently have regional backend services. I don't know what the structure would be with potential globally routable Internal LBs (similar to how L4 Internal load balancer can be configured to be globally routable) would look like. A simple bool for internal may or may not be appropriate for some future state.

from gke-autoneg-controller.

soellman avatar soellman commented on May 27, 2024

Fixed by #34

from gke-autoneg-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.