Comments (5)
I created support for multiple backends a bit over a year ago and we are now revisiting the issue. I suggest the following (and I'm very happy to hear any opinions on these):
- Add a new annotation syntax matching the
cloud.google.com/neg
annotation:
cloud.google.com/neg: '{"exposed_ports": {"80":{},"443":{}}}'
controller.autoneg.dev/neg: '{ "backend_services": { "80": { "name": "foo", "max_rate_per_endpoint": 1000 } , "443": { "name": "bar", "max_connections_per_endpoint": 42 } } }'
- We keep the existing annotation style for backwards compatibility for "version 1.0", but emit a deprecation warning.
- We report status via both via new and old status annotations when there is a single port installed, only via new one when multiple ports are specified.
- We remove the old-style annotation in "version 1.x".
from gke-autoneg-controller.
I did basically the same thing as @rosmo mentioned in point 1 with the addition of an optional internal
property (bool) to handle regional backend services on Internal Load Balancers (region pulled from http://metadata.google.internal/computeMetadata/v1/instance/attributes/cluster-location
). That addressed #23, too
from gke-autoneg-controller.
@rwkarg would you be willing to do a PR?
from gke-autoneg-controller.
I wrote our not-autoneg
controller in C# so while it was a great learning experience into how Kubernetes controllers work, it's not conducive to a PR.
One thing to keep in mind is that Internal LBs currently have regional backend services. I don't know what the structure would be with potential globally routable Internal LBs (similar to how L4 Internal load balancer can be configured to be globally routable) would look like. A simple bool
for internal may or may not be appropriate for some future state.
from gke-autoneg-controller.
Fixed by #34
from gke-autoneg-controller.
Related Issues (20)
- Autoneg does not provide default configuration for max-rate-per-endpoint and max-connections-per-endpoint HOT 1
- Do not set status annotation when backendservice does not exist
- Reconcile error: network endpoint group in a specific zone not found HOT 4
- Terraform configuration unusable for multiple clusters HOT 1
- NEGs not being deregistered on Service deletion HOT 3
- Controller manager service account forbidden listing api resources
- Workload identity 401 invalid credentials error
- deploy/autoneg.yaml referring incorrect kubernetes service account HOT 3
- Configurable default capacityScaler HOT 1
- Custom role error when recreating project
- Unauthorized metrics endpoint HOT 2
- error CONNECTION balancing mode is not supported for protocol HTTP, invalid HOT 8
- Observing ACCESS_TOKEN_SCOPE_INSUFFICIENT when creating service HOT 11
- NEGs are not deleted during service deletion HOT 7
- Update Ginkgo due to deprecation warning HOT 1
- Controller user agent hardcoded to 0.9.7-dev HOT 1
- Update guide or description of compatibility guarantees HOT 3
- Additional pod and container hardening HOT 1
- Mixed logging when configuring structured logging
- Unused ConfigMap in deploy manifest HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gke-autoneg-controller.